1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C7F41431FCF
\r
6 for <notmuch@notmuchmail.org>; Wed, 14 Mar 2012 04:12:34 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id HkbjKcee0I-W for <notmuch@notmuchmail.org>;
\r
17 Wed, 14 Mar 2012 04:12:34 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E4343431FAE
\r
22 for <notmuch@notmuchmail.org>; Wed, 14 Mar 2012 04:12:33 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1S7m83-0004fW-Mq; Wed, 14 Mar 2012 11:12:28 +0000
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1S7m83-000728-8j; Wed, 14 Mar 2012 11:12:27 +0000
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 0/2] A bug in the exclude code
\r
35 In-Reply-To: <87mx7kndd3.fsf@awakening.csail.mit.edu>
\r
36 References: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com>
\r
37 <87mx7kndd3.fsf@awakening.csail.mit.edu>
\r
38 User-Agent: Notmuch/0.11.1+299~gc586c0b (http://notmuchmail.org) Emacs/23.3.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Mux_Client_Request_Session: read from master failed: Broken pipe
\r
41 Date: Wed, 14 Mar 2012 11:12:32 +0000
\r
42 Message-ID: <871uovjv1b.fsf@qmul.ac.uk>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 X-Sender-Host-Address: 94.192.233.223
\r
46 X-QM-SPAM-Info: Sender has good ham record. :)
\r
47 X-QM-Body-MD5: 3d492a7bf2f5f568a7c8bb2f82bf86a9 (of first 20000 bytes)
\r
48 X-SpamAssassin-Score: -1.8
\r
49 X-SpamAssassin-SpamBar: -
\r
50 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
52 spam. We require at least 5.0 points to mark a message as spam.
\r
53 This message scored -1.8 points.
\r
54 Summary of the scoring:
\r
55 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
57 * [138.37.6.40 listed in list.dnswl.org]
\r
58 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
59 provider * (markwalters1009[at]gmail.com)
\r
60 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
62 * 0.5 AWL AWL: From: address is in the auto white-list
\r
63 X-QM-Scan-Virus: ClamAV says the message is clean
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Wed, 14 Mar 2012 11:12:35 -0000
\r
78 On Tue, 13 Mar 2012 22:08:24 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
\r
79 > On Mon, 12 Mar 2012 11:31:52 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
\r
80 > > There is a bug in the exclude code (found by jrollins in the
\r
81 > > --with-excluded series) but also present in master. None of the
\r
82 > > current tests were finding it so the first patch adds two tests.
\r
84 > > The bug (and test failure) do not appear in all configuations: on my
\r
85 > > main test machine (an oldish debian testing 32bit userspace with a
\r
86 > > 64bit kernel and xapian 1.2.7) all tests pass. On my laptop (a recent
\r
87 > > debian testing 64bit userspace and xapian 1.2.8) one of the new tests
\r
90 > > The second patch fixes the behaviour for me but I don't see why it
\r
91 > > should make a difference: searches for A and not B should give the
\r
92 > > same results as A and not (A and B). It could be a bug in xapian, it
\r
93 > > could be that I am not allowed to reuse queries as I do (is query1 =
\r
94 > > query1 and query2 allowed?) or it could be some memory use bug on my
\r
97 > > Anyway the "fix" is small which should help narrow down the actual
\r
100 > LGTM. Even if we don't totally understand the root cause here, this
\r
101 > change is the right thing to do anyway.
\r
103 > I think it's fine to go ahead and push this ahead of the other exclude
\r
104 > updates, though obviously those will need a little rebasing on top of
\r
107 Please don't push exactly this one: I will try and send a version with
\r
108 a better commit message and a test that shows what is failing better
\r
109 later today. (The functional part will be unchanged.)
\r