1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 94EB3431FBC
\r
6 for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 14:32:36 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id NB2mmMHQy7Nb for <notmuch@notmuchmail.org>;
\r
16 Tue, 28 Oct 2014 14:32:29 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 665F5431FB6
\r
19 for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 14:32:29 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 933CB100051;
\r
22 Tue, 28 Oct 2014 23:32:11 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] test: use LDFLAGS in test/Makefile.local
\r
26 In-Reply-To: <1413817401-6058-1-git-send-email-jani@nikula.org>
\r
27 References: <1413817401-6058-1-git-send-email-jani@nikula.org>
\r
28 User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Tue, 28 Oct 2014 23:32:11 +0200
\r
34 Message-ID: <m2ioj3dgo4.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Tue, 28 Oct 2014 21:32:36 -0000
\r
51 On Mon, Oct 20 2014, Jani Nikula wrote:
\r
53 > Apparently the test binaries are built with minimal LDFLAGS, only
\r
54 > adding dependency specific LDFLAGS as needed. However because some of
\r
55 > the test binaries incorporate notmuch object files, it is necessary to
\r
56 > use the same link flags as notmuch. For example user provided
\r
57 > CFLAGS/CXXFLAGS/LDFLAGS with -fsanitize=undefined fails to build the
\r
58 > test binaries if the flags differ.
\r
62 > With this I could do
\r
64 > CFLAGS="-fsanitize=undefined -g" CXXFLAGS="-fsanitize=undefined -g" LDFLAGS="-fsanitize=undefined -g" ./configure
\r
66 > to try ubsan with gcc 4.9. No problems found while running make test
\r
67 > (and it did find an UB I planted to ensure I had it all set up right).
\r
69 > test/Makefile.local | 14 +++++++-------
\r
70 > 1 file changed, 7 insertions(+), 7 deletions(-)
\r
72 > diff --git a/test/Makefile.local b/test/Makefile.local
\r
73 > index a2d58fc1a1b0..2331ceb15e33 100644
\r
74 > --- a/test/Makefile.local
\r
75 > +++ b/test/Makefile.local
\r
76 > @@ -13,10 +13,10 @@ smtp_dummy_srcs = \
\r
77 > smtp_dummy_modules = $(smtp_dummy_srcs:.c=.o)
\r
79 > $(dir)/arg-test: $(dir)/arg-test.o command-line-arguments.o util/libutil.a
\r
80 > - $(call quiet,CC) $^ -o $@
\r
81 > + $(call quiet,CC) $^ -o $@ $(LDFLAGS)
\r
83 > $(dir)/hex-xcode: $(dir)/hex-xcode.o command-line-arguments.o util/libutil.a
\r
84 > - $(call quiet,CC) $^ $(TALLOC_LDFLAGS) -o $@
\r
85 > + $(call quiet,CC) $^ -o $@ $(LDFLAGS) $(TALLOC_LDFLAGS)
\r
87 LGTM; especially the above change which moves all *LDFLAGS after -o $@...
\r
92 > random_corpus_deps = $(dir)/random-corpus.o $(dir)/database-test.o \
\r
93 > notmuch-config.o command-line-arguments.o \
\r
94 > @@ -24,19 +24,19 @@ random_corpus_deps = $(dir)/random-corpus.o $(dir)/database-test.o \
\r
95 > parse-time-string/libparse-time-string.a
\r
97 > $(dir)/random-corpus: $(random_corpus_deps)
\r
98 > - $(call quiet,CXX) $(CFLAGS_FINAL) $^ -o $@ $(CONFIGURE_LDFLAGS)
\r
99 > + $(call quiet,CXX) $^ -o $@ $(LDFLAGS) $(CONFIGURE_LDFLAGS)
\r
101 > $(dir)/smtp-dummy: $(smtp_dummy_modules)
\r
102 > - $(call quiet,CC) $^ -o $@
\r
103 > + $(call quiet,CC) $^ -o $@ $(LDFLAGS)
\r
105 > $(dir)/symbol-test: $(dir)/symbol-test.o lib/$(LINKER_NAME)
\r
106 > - $(call quiet,CXX) $^ -o $@ -Llib -lnotmuch $(XAPIAN_LDFLAGS)
\r
107 > + $(call quiet,CXX) $^ -o $@ $(LDFLAGS) -Llib -lnotmuch $(XAPIAN_LDFLAGS)
\r
109 > $(dir)/parse-time: $(dir)/parse-time.o parse-time-string/parse-time-string.o
\r
110 > - $(call quiet,CC) $^ -o $@
\r
111 > + $(call quiet,CC) $^ -o $@ $(LDFLAGS)
\r
113 > $(dir)/make-db-version: $(dir)/make-db-version.o
\r
114 > - $(call quiet,CXX) $^ -o $@ $(XAPIAN_LDFLAGS)
\r
115 > + $(call quiet,CXX) $^ -o $@ $(LDFLAGS) $(XAPIAN_LDFLAGS)
\r
117 > .PHONY: test check
\r
122 > _______________________________________________
\r
123 > notmuch mailing list
\r
124 > notmuch@notmuchmail.org
\r
125 > http://notmuchmail.org/mailman/listinfo/notmuch
\r