1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 41A5C431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 23 Jul 2012 06:48:35 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id j1apbmqJ79fI for <notmuch@notmuchmail.org>;
\r
16 Mon, 23 Jul 2012 06:48:34 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 7F5DD431FAE
\r
20 for <notmuch@notmuchmail.org>; Mon, 23 Jul 2012 06:48:34 -0700 (PDT)
\r
21 X-AuditID: 12074422-b7f1f6d00000090b-b0-500d56312734
\r
22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
23 by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 43.B3.02315.1365D005; Mon, 23 Jul 2012 09:48:33 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q6NDmXJN004159;
\r
27 Mon, 23 Jul 2012 09:48:33 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6NDmVdF010846
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Mon, 23 Jul 2012 09:48:32 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1StIzu-0002CZ-U7; Mon, 23 Jul 2012 09:48:30 -0400
\r
37 Date: Mon, 23 Jul 2012 09:48:30 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
40 Subject: Re: [PATCH v8 0/3] notmuch-search: Structured Output Formatters
\r
41 Message-ID: <20120723134808.GF31834@mit.edu>
\r
42 References: <1343039986-2732-1-git-send-email-craven@gmx.net>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 Content-Disposition: inline
\r
46 In-Reply-To: <1343039986-2732-1-git-send-email-craven@gmx.net>
\r
47 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
48 X-Brightmail-Tracker:
\r
49 H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hRV1jUM4w0weHDZ0mJvQzujxfWbM5kd
\r
50 mDwWb9rP5vFs1S3mAKYoLpuU1JzMstQifbsErozLh5YwF1zhr/g47wZbA+MBni5GTg4JAROJ
\r
51 +8dXsUHYYhIX7q0Hsrk4hAT2MUo8v/mMGcLZwCjxau4PFgjnJJPEvt/7WCGcJYwSy5e+ZALp
\r
52 ZxFQlehf8grMZhPQkNi2fzkjiC0iICQx6csrFhCbWUBa4tvvZrAaYQEPiSfNz8HivAI6Egsm
\r
53 zmQFsYUEbCX6vp5ghIgLSpyc+QSqV0vixj+QXRxgc5b/4wAJcwrYSTSt3MsMYosKqEhMObmN
\r
54 bQKj0Cwk3bOQdM9C6F7AyLyKUTYlt0o3NzEzpzg1Wbc4OTEvL7VI11QvN7NELzWldBMjKLDZ
\r
55 XZR2MP48qHSIUYCDUYmH17KKJ0CINbGsuDL3EKMkB5OSKG99KG+AEF9SfkplRmJxRnxRaU5q
\r
56 8SFGCQ5mJRHey9e5A4R4UxIrq1KL8mFS0hwsSuK811Ju+gsJpCeWpGanphakFsFkZTg4lCR4
\r
57 O0CGChalpqdWpGXmlCCkmTg4QYbzAA1fDVLDW1yQmFucmQ6RP8WoKCXOWwqSEABJZJTmwfXC
\r
58 Es8rRnGgV4R5y0GqeIBJC677FdBgJqDB0llcIINLEhFSUg2MBf8vmRo7B/U+Xf7sot0xtvfK
\r
59 n389W74x7mqRvmOEkm6u51HNv0LrD280te2U9rS7s+44268Fx7Jrg74zcSz7L6qSfXGzVfH3
\r
60 a99FWyIiNt1ijY877e7v6SJ3dUJZutOKXYcOLWoO+9oUJ6/56Zn4hMex2t9td1W4inr4imZP
\r
61 +3A8uj7yqv9cJZbijERDLeai4kQAzTga7xcDAAA=
\r
62 Cc: notmuch@notmuchmail.org
\r
63 X-BeenThere: notmuch@notmuchmail.org
\r
64 X-Mailman-Version: 2.1.13
\r
66 List-Id: "Use and development of the notmuch mail system."
\r
67 <notmuch.notmuchmail.org>
\r
68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
71 List-Post: <mailto:notmuch@notmuchmail.org>
\r
72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
74 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
75 X-List-Received-Date: Mon, 23 Jul 2012 13:48:35 -0000
\r
79 Quoth craven@gmx.net on Jul 23 at 12:39 pm:
\r
80 > From: <craven@gmx.net>
\r
82 > Currently there is no easy way to add support for different structured
\r
83 > formatters (like JSON). For example, adding support for S-Expressions
\r
84 > would result in code duplication.
\r
86 > This patch series amends the situation by introducing structured
\r
87 > formatters, which allow different implementations of structures like
\r
88 > lists, maps, strings and numbers.
\r
90 > The new code in sprinter.h and sprinter-json.c can be used instead of
\r
91 > the current ad-hoc output in all parts of notmuch, a patch for
\r
92 > notmuch-search.c is included.
\r
94 > In a later patch, all other parts of notmuch should be adapted to the
\r
95 > structured formatters, and the creation of formatters should be
\r
96 > centralised (to make adding new formatters easier).
\r
98 > A "structured" formatter is provided for notmuch-search that prints the
\r
99 > current text format. This removes almost all the special-casing from
\r
100 > notmuch-search.c.
\r
102 > Changes versus v7 of this patch:
\r
103 > - added {} around "else" blocks (as mentioned in
\r
104 > id:20120722160843.GC31834@mit.edu)
\r
105 > - added fallback to INTERNAL_ERROR (which should never be called) in
\r
106 > notmuch-search.c if format is unknown (as mentioned in
\r
107 > id:m2r4s694ly.fsf@guru.guru-group.fi).
\r
112 > Add support for structured output formatters.
\r
113 > Add structured output formatter for JSON and plain text (but don't
\r
115 > Use the structured formatters in notmuch-search.c.
\r
117 > Makefile.local | 2 +
\r
118 > notmuch-search.c | 304 ++++++++++++++---------------------------------
\r
119 > sprinter-json.c | 187 +++++++++++++++++++++++++++++
\r
120 > sprinter-text.c | 126 ++++++++++++++++++++
\r
121 > sprinter.h | 68 +++++++++++
\r
122 > test/json | 34 +++---
\r
123 > 6 files changed, 489 insertions(+), 232 deletions(-)
\r
124 > create mode 100644 sprinter-json.c
\r
125 > create mode 100644 sprinter-text.c
\r
126 > create mode 100644 sprinter.h
\r