1 Return-Path: <markwalters1009@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 07C90431FDC
\r
6 for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 12:57:37 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.201 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,
\r
14 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id T8MRLgXCK1K7 for <notmuch@notmuchmail.org>;
\r
18 Mon, 26 Aug 2013 12:57:31 -0700 (PDT)
\r
19 Received: from mail-we0-f172.google.com (mail-we0-f172.google.com
\r
20 [74.125.82.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 5D663431FD4
\r
23 for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 12:57:31 -0700 (PDT)
\r
24 Received: by mail-we0-f172.google.com with SMTP id t60so3106632wes.17
\r
25 for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 12:57:30 -0700 (PDT)
\r
26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
27 h=from:to:cc:subject:date:message-id:in-reply-to:references;
\r
28 bh=CmHzUJdg5ZBIo+pOnnddlDrDdHXzrhG74ixLgfTxc78=;
\r
29 b=t22fnuf1EgkZ3AN5OV6NhyHFPCaQIGke95KtuJXYc3yPV6NKooI6VOFWNZ9nOrobyF
\r
30 dWdDQDvydie7uh5F4egeEfC5Gi1DWJl+Edr0wKpu8WvELiLnb0JQFpd9l2YFeuZaqwxq
\r
31 J+szpJS6rKg1tHXaz2tFanstUR3KUiuiDMBlyx+4zejy+w3RtKM1RmqFY5r+vp0h1Jp6
\r
32 eWyDGULPnfam2Jbwrn8qoLsZyQZk1SVVe/zYAZi+IGPnt/aeVWvcSYXzD3Cw1X8P7eQ/
\r
33 p6uc08JBrGIT12K5zI+3FLK19Q8hCBsMMe5P2HN1EyB3xavXJil5IKFbR4q9PkT8Q0yP
\r
35 X-Received: by 10.180.91.82 with SMTP id cc18mr8639363wib.7.1377547050235;
\r
36 Mon, 26 Aug 2013 12:57:30 -0700 (PDT)
\r
37 Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])
\r
38 by mx.google.com with ESMTPSA id li9sm20986335wic.4.1969.12.31.16.00.00
\r
39 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
40 Mon, 26 Aug 2013 12:57:29 -0700 (PDT)
\r
41 From: Mark Walters <markwalters1009@gmail.com>
\r
42 To: notmuch@notmuchmail.org
\r
43 Subject: [PATCH 1/2] contrib: pick: remove sync parser
\r
44 Date: Mon, 26 Aug 2013 20:57:22 +0100
\r
45 Message-Id: <1377547043-17584-2-git-send-email-markwalters1009@gmail.com>
\r
46 X-Mailer: git-send-email 1.7.9.1
\r
47 In-Reply-To: <1377547043-17584-1-git-send-email-markwalters1009@gmail.com>
\r
48 References: <1377547043-17584-1-git-send-email-markwalters1009@gmail.com>
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Mon, 26 Aug 2013 19:57:37 -0000
\r
63 Previously pick had the option of using an async parser like search or
\r
64 a sync parser like show. The async parser has always been the default
\r
65 and it seems fine so we can remove the sync one and the corresponding
\r
68 contrib/notmuch-pick/notmuch-pick.el | 36 ++++++++++-----------------------
\r
69 1 files changed, 11 insertions(+), 25 deletions(-)
\r
71 diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
\r
72 index 37dc161..8c499b0 100644
\r
73 --- a/contrib/notmuch-pick/notmuch-pick.el
\r
74 +++ b/contrib/notmuch-pick/notmuch-pick.el
\r
76 :type '(alist :key-type (string) :value-type (string))
\r
77 :group 'notmuch-pick)
\r
79 -(defcustom notmuch-pick-asynchronous-parser t
\r
80 - "Use the asynchronous parser."
\r
82 - :group 'notmuch-pick)
\r
84 ;; Faces for messages that match the query.
\r
85 (defface notmuch-pick-match-date-face
\r
86 '((t :inherit default))
\r
87 @@ -817,26 +812,17 @@ Complete list of currently available key bindings:
\r
88 (message-arg "--entire-thread"))
\r
89 (if (equal (car (process-lines notmuch-command "count" search-args)) "0")
\r
90 (setq search-args basic-query))
\r
91 - (if notmuch-pick-asynchronous-parser
\r
92 - (let ((proc (notmuch-start-notmuch
\r
93 - "notmuch-pick" buffer #'notmuch-pick-process-sentinel
\r
94 - "show" "--body=false" "--format=sexp"
\r
95 - message-arg search-args))
\r
96 - ;; Use a scratch buffer to accumulate partial output.
\r
97 - ;; This buffer will be killed by the sentinel, which
\r
98 - ;; should be called no matter how the process dies.
\r
99 - (parse-buf (generate-new-buffer " *notmuch pick parse*")))
\r
100 - (process-put proc 'parse-buf parse-buf)
\r
101 - (set-process-filter proc 'notmuch-pick-process-filter)
\r
102 - (set-process-query-on-exit-flag proc nil))
\r
104 - (notmuch-pick-insert-forest
\r
105 - (notmuch-query-get-threads
\r
106 - (list "--body=false" message-arg search-args)))
\r
108 - (goto-char (point-max))
\r
109 - (insert "End of search results.\n"))))))
\r
111 + (let ((proc (notmuch-start-notmuch
\r
112 + "notmuch-pick" buffer #'notmuch-pick-process-sentinel
\r
113 + "show" "--body=false" "--format=sexp"
\r
114 + message-arg search-args))
\r
115 + ;; Use a scratch buffer to accumulate partial output.
\r
116 + ;; This buffer will be killed by the sentinel, which
\r
117 + ;; should be called no matter how the process dies.
\r
118 + (parse-buf (generate-new-buffer " *notmuch pick parse*")))
\r
119 + (process-put proc 'parse-buf parse-buf)
\r
120 + (set-process-filter proc 'notmuch-pick-process-filter)
\r
121 + (set-process-query-on-exit-flag proc nil))))
\r
123 (defun notmuch-pick (&optional query query-context target buffer-name open-target)
\r
124 "Run notmuch pick with the given `query' and display the results.
\r