1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 9A6E16DE17EE
\r
6 for <notmuch@notmuchmail.org>; Mon, 18 Jan 2016 04:25:11 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.309 tagged_above=-999 required=5 tests=[AWL=0.242,
\r
12 RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id kXW4jvx62y_V for <notmuch@notmuchmail.org>;
\r
16 Mon, 18 Jan 2016 04:25:07 -0800 (PST)
\r
17 Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
\r
18 by arlo.cworth.org (Postfix) with ESMTPS id 166956DE17DC
\r
19 for <notmuch@notmuchmail.org>; Mon, 18 Jan 2016 04:25:06 -0800 (PST)
\r
20 Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
\r
21 (envelope-from <david@tethera.net>)
\r
22 id 1aL8rB-0004AY-4E; Mon, 18 Jan 2016 07:24:25 -0500
\r
23 Received: (nullmailer pid 29568 invoked by uid 1000);
\r
24 Mon, 18 Jan 2016 12:25:00 -0000
\r
25 From: David Bremner <david@tethera.net>
\r
26 To: Gaute Hope <eg@gaute.vetsj.com>, notmuch@notmuchmail.org
\r
27 Subject: Re: talloc_abort in notmuch_thread_get_tags () when db has been
\r
29 In-Reply-To: <1453106256-astroid-0-0ubhau8qws-26019@strange>
\r
30 References: <1453106256-astroid-0-0ubhau8qws-26019@strange>
\r
31 User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1
\r
32 (x86_64-pc-linux-gnu)
\r
33 Date: Mon, 18 Jan 2016 08:25:00 -0400
\r
34 Message-ID: <87k2n72hyb.fsf@zancas.localnet>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.20
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Mon, 18 Jan 2016 12:25:11 -0000
\r
51 Gaute Hope <eg@gaute.vetsj.com> writes:
\r
55 > a user of astroid [0] ran into a issue [1] (full trace at issue) where
\r
56 > reading a long query causes a talloc_abort in notmuch_thread_get_tags
\r
57 > (). 'notmuch new' is running at the same time, and most likely a thread
\r
58 > in the query has been modified since the query was done. Note that a
\r
59 > notmuch_thread_get_authors () call returns NULL without causing a full
\r
60 > crash. The code causing the crash is:
\r
63 > for (tags = notmuch_thread_get_tags (nm_thread);
\r
64 > notmuch_tags_valid (tags);
\r
65 > notmuch_tags_move_to_next (tags))
\r
67 > tag = notmuch_tags_get (tags); // tag belongs to tags
\r
70 > // or db.cc:508 in astroid/src.
\r
74 The most likely cause of such a crash looks to me like nm_thread is NULL
\r
75 or corrupted when passed in to get_tags. It's used without checking as a
\r
76 talloc context, and that call to talloc never returns.
\r