1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2B70A431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 21 Feb 2013 04:23:01 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id XjtF4rQ2vQFw for <notmuch@notmuchmail.org>;
\r
16 Thu, 21 Feb 2013 04:22:59 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id C6FEB431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 21 Feb 2013 04:22:59 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id A53AB10014F;
\r
22 Thu, 21 Feb 2013 14:22:42 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag
\r
26 In-Reply-To: <87k3q151fx.fsf@zancas.localnet>
\r
27 References: <1361399077-7737-1-git-send-email-david@tethera.net>
\r
28 <1361399077-7737-2-git-send-email-david@tethera.net>
\r
29 <m27gm2ax1k.fsf@guru.guru-group.fi>
\r
30 <87k3q151fx.fsf@zancas.localnet>
\r
31 User-Agent: Notmuch/0.15.2+41~g0ce9bd4 (http://notmuchmail.org) Emacs/24.2.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Thu, 21 Feb 2013 14:22:42 +0200
\r
37 Message-ID: <m2y5ehvotp.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Thu, 21 Feb 2013 12:23:01 -0000
\r
54 On Thu, Feb 21 2013, David Bremner <david@tethera.net> wrote:
\r
56 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
59 >> This patch series looks good to me (as far as I can understand, I did
\r
60 >> not find the "silly bug" in your previous patch...)
\r
65 > + print $notmuch $A_action.$TAGPREFIX.$pair->{tag}, " -- ",
\r
66 > + 'id:'.$pair->{id};
\r
70 > + print $notmuch $D_action.$TAGPREFIX.$pair->{tag},
\r
71 > + 'id:'.$pair->{id};
\r
75 > I obviously did not test that version very well.
\r
77 IIRC that has happened to some other people, too ;(
\r
79 >> Instead of mentioning that "calls are _not_ passed to shell" here,
\r
80 >> that could be briefly mentioned just before system() calls in the
\r
81 >> script -- and that definitely should not be 'At the moment' feature.
\r
83 > Sure, the "At the moment" is meant to modify "relies". In the next
\r
84 > patch, we stop relying on this feature of Perl.
\r
86 Well, one have to expect the execution to happen one way or another
\r
87 (and arrange quoting accordingly); for example:
\r
89 $ echo; perl -e 'exec q/echo "foobar"/'
\r
95 $ echo; perl -e 'exec qw/echo "foobar"/'
\r
99 first gave exec one arg, 'echo "foobar"' and due to "":s perl used sh
\r
100 to execute it, second gave exec list [ 'echo', '"foobar"' ] and therefore
\r
101 echo got foobar with quotes as a command line argument.
\r
103 Anyone interested for more information, see 'perldoc -f exec'.
\r
106 >> the system() function in perl(1) never pass execution through the
\r
107 >> shell in case the args are list more than one arg:
\r
109 > right. that's what I meant by "is a documented feature of perl's system
\r
112 > So I think we mean to say the same thing here; but I could I add a
\r
113 > comment in this patch (to delete it in the next). Or maybe reword that
\r
114 > commit message somehow.
\r
116 Yes, the message is the same, just that there should not be need for that..
\r