1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2A4CE431FC2
\r
6 for <notmuch@notmuchmail.org>; Sun, 20 Oct 2013 05:18:19 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 2zl1+2PhLtE2 for <notmuch@notmuchmail.org>;
\r
16 Sun, 20 Oct 2013 05:18:14 -0700 (PDT)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 6B8A0431FC0
\r
21 for <notmuch@notmuchmail.org>; Sun, 20 Oct 2013 05:18:14 -0700 (PDT)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1VXrxR-0006WF-FA; Sun, 20 Oct 2013 09:18:09 -0300
\r
25 Received: (nullmailer pid 23056 invoked by uid 1000); Sun, 20 Oct 2013
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Ben Gamari <bgamari.foss@gmail.com>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH 1/3] test: Add compact test
\r
30 In-Reply-To: <1381799585-16274-2-git-send-email-bgamari.foss@gmail.com>
\r
31 References: <1381799585-16274-1-git-send-email-bgamari.foss@gmail.com>
\r
32 <1381799585-16274-2-git-send-email-bgamari.foss@gmail.com>
\r
33 User-Agent: Notmuch/0.16+97~g6878b0b (http://notmuchmail.org) Emacs/24.3.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Sun, 20 Oct 2013 09:18:05 -0300
\r
36 Message-ID: <874n8cw2yq.fsf@zancas.localnet>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sun, 20 Oct 2013 12:18:19 -0000
\r
56 Thanks for writing these tests. I have some proposed changes. I didn't
\r
57 understand why you called notmuch search twice, and for whatever reason
\r
58 test_begin_subtest doesn't pair up with test_expect_success
\r
60 diff --git a/test/compact b/test/compact
\r
61 index 54e85ab..5bb5cea 100755
\r
64 @@ -10,11 +10,9 @@ notmuch tag +tag1 \*
\r
65 notmuch tag +tag2 subject:Two
\r
66 notmuch tag -tag1 +tag3 subject:Three
\r
68 -test_begin_subtest "Compacting"
\r
70 -test_expect_success "compact" "notmuch compact"
\r
71 +test_expect_success "Running compact" "notmuch compact"
\r
74 +test_begin_subtest "Compact preserves database"
\r
75 output=$(notmuch search \* | notmuch_search_sanitize)
\r
76 test_expect_equal "$output" "\
\r
77 thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; One (inbox tag1 unread)
\r
78 @@ -25,7 +23,6 @@ test_begin_subtest "Restoring backup"
\r
79 rm -Rf ${TEST_TMPDIR}/mail/xapian
\r
80 mv ${TEST_TMPDIR}/mail/xapian.old ${TEST_TMPDIR}/mail/xapian
\r
83 output=$(notmuch search \* | notmuch_search_sanitize)
\r
84 test_expect_equal "$output" "\
\r
85 thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; One (inbox tag1 unread)
\r