9c/ceefa741d91f06f258d3b176f403a46a9c92de

   1 Return-Path: <amthrax@awakening.csail.mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 371DC429E25\r
   6         for <notmuch@notmuchmail.org>; Sun, 20 Nov 2011 17:04:40 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id 6VJG0PyrpLfd for <notmuch@notmuchmail.org>;\r
  16         Sun, 20 Nov 2011 17:04:39 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
  18         [18.9.25.14])\r
  19         by olra.theworths.org (Postfix) with ESMTP id A6F38431FD0\r
  20         for <notmuch@notmuchmail.org>; Sun, 20 Nov 2011 17:04:39 -0800 (PST)\r
  21 X-AuditID: 1209190e-b7f4a6d0000008e5-dc-4ec9a3a6b070\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 91.91.02277.6A3A9CE4; Sun, 20 Nov 2011 20:04:38 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id pAL14bLd002238; \r
  27         Sun, 20 Nov 2011 20:04:37 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pAL14ala014947\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Sun, 20 Nov 2011 20:04:37 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amthrax@awakening.csail.mit.edu>)\r
  36         id 1RSILf-0002IA-N5; Sun, 20 Nov 2011 20:07:03 -0500\r
  37 From: Austin Clements <amdragon@MIT.EDU>\r
  38 To: notmuch@notmuchmail.org\r
  39 Subject: [PATCH] emacs: Avoid unnecessary markers.\r
  40 Date: Sun, 20 Nov 2011 20:07:02 -0500\r
  41 Message-Id: <1321837622-8755-1-git-send-email-amdragon@mit.edu>\r
  42 X-Mailer: git-send-email 1.7.7.2\r
  43 X-Brightmail-Tracker:\r
  44  H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsUixCmqrbts8Uk/g4kbpC2u35zJ7MDo8WzV\r
  45         LeYAxigum5TUnMyy1CJ9uwSujPubV7IXXOCpWL/6H2MD41KuLkZODgkBE4k5LTeYIWwxiQv3\r
  46         1rN1MXJxCAnsY5TYeH0plLOBUeLeya+MIFVCAieZJB5M54ZIbGaUuHN6KytIgk1AQ2Lb/uVg\r
  47         RSIC0hI7784GinNwMAuoSfzpUgEJCwsYScxdfQFsG4uAqsSaaRvAbF4Be4lnG++yQVyhIDFj\r
  48         yhXGCYy8CxgZVjHKpuRW6eYmZuYUpybrFicn5uWlFuka6+VmluilppRuYgQHgSTfDsavB5UO\r
  49         MQpwMCrx8AoGnvATYk0sK67MPcQoycGkJMq7Y9FJPyG+pPyUyozE4oz4otKc1OJDjBIczEoi\r
  50         vDnOQDnelMTKqtSifJiUNAeLkjjv6h0OfkIC6YklqdmpqQWpRTBZGQ4OJQnefyBDBYtS01Mr\r
  51         0jJzShDSTBycIMN5gIY/BKnhLS5IzC3OTIfIn2JUlBKHSAiAJDJK8+B6YVH6ilEc6BVhXrWZ\r
  52         QFU8wAiH634FNJgJaPC0tSdABpckIqSkGhg57kW6VFS8spSIaUzvZg1WvnF4wXvhemYN++B/\r
  53         3KrX3L3dD1x/qF+U6KCqPMHYe8r0rESmtRrqJhstN0uI6ocfvS9SVt90l2HfVvcvK2eG1Px1\r
  54         XhTedo7p9zJLo80fN+5cfXOFtMhWoRVc35uOn12s4CN451lxztMkxx75P8wTo5fnn28OZldi\r
  55         Kc5INNRiLipOBAC2TekFrQIAAA==\r
  56 X-BeenThere: notmuch@notmuchmail.org\r
  57 X-Mailman-Version: 2.1.13\r
  58 Precedence: list\r
  59 List-Id: "Use and development of the notmuch mail system."\r
  60         <notmuch.notmuchmail.org>\r
  61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  62         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  64 List-Post: <mailto:notmuch@notmuchmail.org>\r
  65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  67         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  68 X-List-Received-Date: Mon, 21 Nov 2011 01:04:40 -0000\r
  69 \r
  70 This is just cleanup.  These markers are all immediately resolved to\r
  71 points by Emacs, so using markers here is just unncessary overhead.\r
  72 ---\r
  73 I originally did this for performance, since Emacs has to scan all\r
  74 un-GC'd markers on every buffer change, but it turns out to matter\r
  75 notmuch.\r
  76 \r
  77  emacs/notmuch.el |   10 +++++-----\r
  78  1 files changed, 5 insertions(+), 5 deletions(-)\r
  79 \r
  80 diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
  81 index a8e4d62..f15a75b 100644\r
  82 --- a/emacs/notmuch.el\r
  83 +++ b/emacs/notmuch.el\r
  84 @@ -805,12 +805,12 @@ non-authors is found, assume that all of the authors match."\r
  85                       (goto-char (point-max))\r
  86                       (if (/= (match-beginning 1) line)\r
  87                           (insert (concat "Error: Unexpected output from notmuch search:\n" (substring string line (match-beginning 1)) "\n")))\r
  88 -                     (let ((beg (point-marker)))\r
  89 +                     (let ((beg (point)))\r
  90                         (notmuch-search-show-result date count authors subject tags)\r
  91 -                       (notmuch-search-color-line beg (point-marker) tag-list)\r
  92 -                       (put-text-property beg (point-marker) 'notmuch-search-thread-id thread-id)\r
  93 -                       (put-text-property beg (point-marker) 'notmuch-search-authors authors)\r
  94 -                       (put-text-property beg (point-marker) 'notmuch-search-subject subject)\r
  95 +                       (notmuch-search-color-line beg (point) tag-list)\r
  96 +                       (put-text-property beg (point) 'notmuch-search-thread-id thread-id)\r
  97 +                       (put-text-property beg (point) 'notmuch-search-authors authors)\r
  98 +                       (put-text-property beg (point) 'notmuch-search-subject subject)\r
  99                         (if (string= thread-id notmuch-search-target-thread)\r
 100                             (progn\r
 101                               (set 'found-target beg)\r
 102 -- \r
 103 1.7.7.2\r
 104 \r