1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B959B40D144
\r
6 for <notmuch@notmuchmail.org>; Tue, 12 Oct 2010 04:21:54 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5
\r
12 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id i3Fu2vm-oewm for <notmuch@notmuchmail.org>;
\r
16 Tue, 12 Oct 2010 04:21:44 -0700 (PDT)
\r
17 Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
\r
18 by olra.theworths.org (Postfix) with ESMTP id D4DE940D143
\r
19 for <notmuch@notmuchmail.org>; Tue, 12 Oct 2010 04:21:43 -0700 (PDT)
\r
20 Received: from rocinante.cs.unb.ca
\r
21 (fctnnbsc30w-142167176217.pppoe-dynamic.High-Speed.nb.bellaliant.net
\r
22 [142.167.176.217]) (authenticated bits=0)
\r
23 by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id o9CBLbIP021014
\r
24 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
\r
25 Tue, 12 Oct 2010 08:21:38 -0300
\r
26 Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.72)
\r
27 (envelope-from <bremner@unb.ca>)
\r
28 id 1P5cvJ-0003N9-Nd; Tue, 12 Oct 2010 08:21:37 -0300
\r
29 From: David Bremner <david@tethera.net>
\r
30 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
31 Subject: Re: First draft of logging functionality.
\r
32 In-Reply-To: <87zkuj3hme.fsf@steelpick.2x.cz>
\r
33 References: <1286803617-17328-1-git-send-email-david@tethera.net>
\r
34 <87zkuj3hme.fsf@steelpick.2x.cz>
\r
35 User-Agent: Notmuch/0.3.1-59-g676d251 (http://notmuchmail.org) Emacs/23.2.1
\r
36 (x86_64-pc-linux-gnu)
\r
37 Date: Tue, 12 Oct 2010 08:21:37 -0300
\r
38 Message-ID: <87hbgrhd1a.fsf@rocinante.cs.unb.ca>
\r
40 Content-Type: text/plain; charset=us-ascii
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Tue, 12 Oct 2010 11:21:54 -0000
\r
55 On Tue, 12 Oct 2010 11:06:17 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
57 > I'm not sure whether implementing logging facility outside of notmuch
\r
58 > library is a good thing. If somebody will use a third-party tool (such
\r
59 > as python bindings) to manipulate his tags, they won't appear in the
\r
62 Yeah, thanks for that. I had been worrying about the same thing, but
\r
63 your message helped clarify things for me.
\r
65 I guess log files should be opened in notmuch_database_open, and the
\r
66 actual logging in this case could happen from notmuch_message_add_tag.
\r
68 >From an atomicity point of view it might make more sense to store up a
\r
69 list of log lines, and dump them all from _notmuch_message_sync.
\r
70 One could attach a log buffer to a message, and flush that atomically
\r
71 when syncing the message back to the database. In this context, it is a
\r
72 little more tedious to have more than one log file.
\r