1 Return-Path: <teythoon@jade-hamburg.de>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4984C431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 24 Sep 2012 03:32:27 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.001 tagged_above=-999 required=5
\r
12 tests=[UNPARSEABLE_RELAY=0.001] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id PgEv+DP61ste for <notmuch@notmuchmail.org>;
\r
16 Mon, 24 Sep 2012 03:32:26 -0700 (PDT)
\r
17 Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])
\r
18 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id AB500431FC9
\r
21 for <notmuch@notmuchmail.org>; Mon, 24 Sep 2012 03:32:20 -0700 (PDT)
\r
22 Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])
\r
23 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
24 (No client certificate requested)
\r
25 by mail.cryptobitch.de (Postfix) with ESMTPSA id 7794E5AA9C9
\r
26 for <notmuch@notmuchmail.org>; Mon, 24 Sep 2012 12:32:19 +0200 (CEST)
\r
27 Received: by mail.jade-hamburg.de (Postfix, from userid 401)
\r
28 id DA1CFDF2A7; Mon, 24 Sep 2012 12:32:18 +0200 (CEST)
\r
29 Received: from thinkbox.jade-hamburg.de (unknown
\r
30 [IPv6:fe80::216:d3ff:fe3e:5058%br0])
\r
31 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
32 (No client certificate requested) (Authenticated sender: teythoon)
\r
33 by mail.jade-hamburg.de (Postfix) with ESMTPSA id 367BDDF2A4;
\r
34 Mon, 24 Sep 2012 12:32:12 +0200 (CEST)
\r
35 Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.80)
\r
36 (envelope-from <teythoon@thinkbox.jade-hamburg.de>)
\r
37 id 1TG5xR-0002iH-UN; Mon, 24 Sep 2012 12:32:09 +0200
\r
38 From: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
39 To: notmuch@notmuchmail.org
\r
40 Subject: [PATCH 5/5] Avoid potentially dereferencing a NULL pointer
\r
41 Date: Mon, 24 Sep 2012 12:31:57 +0200
\r
43 <1348482717-10340-6-git-send-email-4winter@informatik.uni-hamburg.de>
\r
44 X-Mailer: git-send-email 1.7.10.4
\r
46 <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
47 References: <20120922161256.GE26662@mit.edu>
\r
48 <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Mon, 24 Sep 2012 10:32:28 -0000
\r
63 GMIME_IS_MULTIPART and GMIME_IS_MESSAGE both handle NULL pointers
\r
64 gracefully, but the G_OBJECT_TYPE used in the error handling block
\r
65 dereferences it without checking it first.
\r
67 Fix this by checking whether parent->part is valid.
\r
69 Found using the clang static analyzer.
\r
71 Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
74 1 file changed, 1 insertion(+), 1 deletion(-)
\r
76 diff --git a/mime-node.c b/mime-node.c
\r
77 index 97e8b48..839737a 100644
\r
80 @@ -291,7 +291,7 @@ mime_node_child (mime_node_t *parent, int child)
\r
84 - if (!parent || child < 0 || child >= parent->nchildren)
\r
85 + if (!parent || !parent->part || child < 0 || child >= parent->nchildren)
\r
88 if (GMIME_IS_MULTIPART (parent->part)) {
\r