1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 129BC6DE1601
\r
6 for <notmuch@notmuchmail.org>; Wed, 30 Dec 2015 07:22:16 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.312 tagged_above=-999 required=5 tests=[AWL=0.239,
\r
12 RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id fqSVquFYDfIZ for <notmuch@notmuchmail.org>;
\r
16 Wed, 30 Dec 2015 07:22:14 -0800 (PST)
\r
17 Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
\r
18 by arlo.cworth.org (Postfix) with ESMTPS id 566B76DE14A8
\r
19 for <notmuch@notmuchmail.org>; Wed, 30 Dec 2015 07:22:14 -0800 (PST)
\r
20 Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
\r
21 (envelope-from <david@tethera.net>)
\r
22 id 1aEIZg-00074a-CV; Wed, 30 Dec 2015 10:22:04 -0500
\r
23 Received: (nullmailer pid 5772 invoked by uid 1000);
\r
24 Wed, 30 Dec 2015 15:22:09 -0000
\r
25 From: David Bremner <david@tethera.net>
\r
26 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
27 Subject: Re: [PATCH v2] emacs: Improve notmuch-message-mode initialization
\r
28 In-Reply-To: <1450690875-2111-2-git-send-email-sojkam1@fel.cvut.cz>
\r
29 References: <1450690875-2111-1-git-send-email-sojkam1@fel.cvut.cz>
\r
30 <1450690875-2111-2-git-send-email-sojkam1@fel.cvut.cz>
\r
31 User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1
\r
32 (x86_64-pc-linux-gnu)
\r
33 Date: Wed, 30 Dec 2015 11:22:09 -0400
\r
34 Message-ID: <87y4cc3qse.fsf@zancas.localnet>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.20
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Wed, 30 Dec 2015 15:22:16 -0000
\r
51 Michal Sojka <sojkam1@fel.cvut.cz> writes:
\r
53 > Recent addition of notmuch-message-mode introduced several problems:
\r
55 > 1. When message-setup-hook is used to set buffer local variables,
\r
56 > these settings are not effective, because all buffer local
\r
57 > variables are immediately erased by notmuch-message-mode
\r
60 > 2. message-mode-hook gets invoked twice - first when message-mail
\r
61 > invokes message-mode and second when notmuch-mua-mail invokes
\r
62 > notmuch-message-mode.
\r
64 > This commit fixes these problems by replacing a call to message-mail
\r
65 > with notmuch-specific code that is (hopefully) equivalent to
\r
66 > message-mail functionality before introduction of
\r
67 > notmuch-message-mode.
\r
69 > We first initialize notmuch-message-mode with
\r
70 > notmuch-mua-pop-to-buffer, which is a modified version of
\r
71 > message-pop-to-buffer and then call message-setup-1, which is the only
\r
72 > functionality of message-mail that is needed for notmuch.
\r
74 This doesn't break anything for me, and looks fairly sane. I'm not sure
\r
75 if the indirectrion of notmuch-mua-get-switch-function is still needed,
\r
76 but that can wait for an optional followup patch.
\r