1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 39E9B431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 10 Nov 2012 08:23:45 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YJWXgOTmVhzl for <notmuch@notmuchmail.org>;
\r
16 Sat, 10 Nov 2012 08:23:44 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 99787431FAF
\r
19 for <notmuch@notmuchmail.org>; Sat, 10 Nov 2012 08:23:44 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 64EA5100094;
\r
22 Sat, 10 Nov 2012 18:23:43 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH v2] contrib: pick: bugfix when trying to show a
\r
27 In-Reply-To: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>
\r
28 References: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>
\r
29 User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Sat, 10 Nov 2012 18:23:43 +0200
\r
35 Message-ID: <m2y5i94eb4.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Sat, 10 Nov 2012 16:23:45 -0000
\r
52 On Sat, Nov 10 2012, Mark Walters <markwalters1009@gmail.com> wrote:
\r
54 > If the user pressed return on the end result status line it gave a
\r
55 > blank message. Modify the function notmuch-pick-get-message-id to
\r
56 > return nil rather than an empty message-id in this case to fix this.
\r
58 > This also fixes a bug in the (lack of) quoting of the id string.
\r
66 > id:1351797983-19707-1-git-send-email-markwalters1009@gmail.com
\r
68 > This version changes the `when' to and `if' and adds the fix for the
\r
75 > contrib/notmuch-pick/notmuch-pick.el | 4 +++-
\r
76 > 1 files changed, 3 insertions(+), 1 deletions(-)
\r
78 > diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
\r
79 > index 15ac5e8..bbfa6fb 100644
\r
80 > --- a/contrib/notmuch-pick/notmuch-pick.el
\r
81 > +++ b/contrib/notmuch-pick/notmuch-pick.el
\r
82 > @@ -241,7 +241,9 @@ Some useful entries are:
\r
84 > (defun notmuch-pick-get-message-id ()
\r
85 > "Return the message id of the current message."
\r
86 > - (concat "id:\"" (notmuch-pick-get-prop :id) "\""))
\r
87 > + (let ((id (notmuch-pick-get-prop :id)))
\r
89 > + (notmuch-id-to-query id))))
\r
91 > (defun notmuch-pick-get-match ()
\r
92 > "Return whether the current message is a match."
\r
96 > _______________________________________________
\r
97 > notmuch mailing list
\r
98 > notmuch@notmuchmail.org
\r
99 > http://notmuchmail.org/mailman/listinfo/notmuch
\r