1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3BEA4431FAF
\r
6 for <notmuch@notmuchmail.org>; Fri, 21 Sep 2012 13:31:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id CJsAeyzVXRex for <notmuch@notmuchmail.org>;
\r
16 Fri, 21 Sep 2012 13:31:39 -0700 (PDT)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id BE20F431FAE
\r
21 for <notmuch@notmuchmail.org>; Fri, 21 Sep 2012 13:31:39 -0700 (PDT)
\r
22 Received: from convex-new.cs.unb.ca ([131.202.245.35])
\r
23 by tesseract.cs.unb.ca with esmtpsa
\r
24 (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
\r
25 (envelope-from <bremner@unb.ca>)
\r
26 id 1TF9sn-0001Mq-RQ; Fri, 21 Sep 2012 17:31:34 -0300
\r
27 Received: from bremner by convex-new.cs.unb.ca with local (Exim 4.80)
\r
28 (envelope-from <bremner@unb.ca>)
\r
29 id 1TF9sN-0001cA-ER; Fri, 21 Sep 2012 17:31:03 -0300
\r
30 From: David Bremner <david@tethera.net>
\r
31 To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH 1/2] Annotate internal_error with the attribute noreturn
\r
34 <1348231837-21700-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
36 <1348231837-21700-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
37 User-Agent: Notmuch/0.14+20~g69843dd (http://notmuchmail.org) Emacs/24.2.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Fri, 21 Sep 2012 17:31:03 -0300
\r
40 Message-ID: <87fw6bdsoo.fsf@convex-new.cs.unb.ca>
\r
42 Content-Type: text/plain
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Fri, 21 Sep 2012 20:31:40 -0000
\r
58 Justus Winter <4winter@informatik.uni-hamburg.de> writes:
\r
60 > Annotating functions that do not return with the noreturn attribute
\r
61 > (which is understood by both gcc and clang) prevents static analyzers
\r
62 > from generating false positives (internal_error is used to terminate
\r
63 > the process and is used extensively in error handling code paths).
\r
65 > Remove the return statement that was placed there to appease the
\r
66 > compiler. Functions annotated with noreturn are not supposed to return
\r
70 This patch looks OK (although I don't know the pragma details). Do you
\r
71 (or anyone) happen to know why _internal_error is an int function?
\r
72 Making it void wouldn't fix the problem with static analzers, but having
\r
73 an int function without a return looks ugly to me.
\r