93/856dede8ed2afc729ed48c5ce29f9fbe52f404

   1 Return-Path: <tomi.ollila@iki.fi>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 16B9C431FAF\r
   6         for <notmuch@notmuchmail.org>; Tue,  6 May 2014 12:09:18 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 0\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
  12         autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id DUYYKJk2lNJZ for <notmuch@notmuchmail.org>;\r
  16         Tue,  6 May 2014 12:09:10 -0700 (PDT)\r
  17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
  18         by olra.theworths.org (Postfix) with ESMTP id 1A3CF431FC2\r
  19         for <notmuch@notmuchmail.org>; Tue,  6 May 2014 12:09:10 -0700 (PDT)\r
  20 Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
  21         by guru.guru-group.fi (Postfix) with ESMTP id 9472B1000E5;\r
  22         Tue,  6 May 2014 22:09:05 +0300 (EEST)\r
  23 From: Tomi Ollila <tomi.ollila@iki.fi>\r
  24 To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org\r
  25 Subject: Re: [PATCH 4/5] T360-symbol-hiding: Added code to support testing\r
  26         on      Mac     OS X.\r
  27 In-Reply-To: <m2d2fqrc0v.fsf@jane.lan>\r
  28 References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu>\r
  29         <1399395748-44920-2-git-send-email-cceleri@cs.stanford.edu>\r
  30         <1399395748-44920-3-git-send-email-cceleri@cs.stanford.edu>\r
  31         <1399395748-44920-4-git-send-email-cceleri@cs.stanford.edu>\r
  32         <1399395748-44920-5-git-send-email-cceleri@cs.stanford.edu>\r
  33         <m21tw6ix8o.fsf@guru.guru-group.fi> <m2d2fqrc0v.fsf@jane.lan>\r
  34 User-Agent: Notmuch/0.18+12~gbfbd199 (http://notmuchmail.org) Emacs/24.3.1\r
  35         (x86_64-unknown-linux-gnu)\r
  36 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
  37         $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
  38         !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
  39 Date: Tue, 06 May 2014 22:09:05 +0300\r
  40 Message-ID: <m2ppjqhgha.fsf@guru.guru-group.fi>\r
  41 MIME-Version: 1.0\r
  42 Content-Type: text/plain\r
  43 X-BeenThere: notmuch@notmuchmail.org\r
  44 X-Mailman-Version: 2.1.13\r
  45 Precedence: list\r
  46 List-Id: "Use and development of the notmuch mail system."\r
  47         <notmuch.notmuchmail.org>\r
  48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  49         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  51 List-Post: <mailto:notmuch@notmuchmail.org>\r
  52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  54         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  55 X-List-Received-Date: Tue, 06 May 2014 19:09:18 -0000\r
  56 \r
  57 On Tue, May 06 2014, Charles Celerier <cceleri@cs.stanford.edu> wrote:\r
  58 \r
  59 > Tomi Ollila <tomi.ollila@iki.fi> writes:\r
  60 >\r
  61 >> On Tue, May 06 2014, Charles Celerier <cceleri@cs.stanford.edu> wrote:\r
  62 >>\r
  63 >>> The Mac OS X platform uses *.dylib object files instead of *.so object\r
  64 >>> files for linking. Adding the path to notmuch.dylib to the end of\r
  65 >>> DYLD_FALLBACK_LIBRARY_PATH has a similar effect to adding the path to\r
  66 >>> notmuch.so to LD_LIBRARY_PATH on most Linux-based platforms (see\r
  67 >>> dyld(1)).\r
  68 >>\r
  69 >> This series LGTM. I don't understand this difference suffixing\r
  70 >> DYLD_FALLBACK_LIBRARY_PATH with $TEST_DIRECTORY/../lib on Mac OS X\r
  71 >> compared to prefixing LD_LIBRARY_PATH with the same on other\r
  72 >> systems, so I take your word that it works :D\r
  73 >\r
  74 > I just went back and read dyld(1) again. Prefixing would be fine, and I\r
  75 > agree it would look cleaner.\r
  76 \r
  77 That would also be less confusing. \r
  78 \r
  79 You could send a replacement patch 4/5 and use\r
  80 id:1399395748-44920-5-git-send-email-cceleri@cs.stanford.edu\r
  81 as reply-to: let's see how nmbug sorts those patches, then :D\r
  82 \r
  83 Tomi\r
  84 \r
  85 \r
  86 >\r
  87 >>>\r
  88 >>> Signed-off-by: Charles Celerier <cceleri@cs.stanford.edu>\r
  89 >>> ---\r
  90 >>>  test/T360-symbol-hiding.sh | 9 ++++++++-\r
  91 >>>  1 file changed, 8 insertions(+), 1 deletion(-)\r
  92 >>>\r
  93 >>> diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh\r
  94 >>> index 636ec91..97c734a 100755\r
  95 >>> --- a/test/T360-symbol-hiding.sh\r
  96 >>> +++ b/test/T360-symbol-hiding.sh\r
  97 >>> @@ -12,7 +12,14 @@ test_description='exception symbol hiding'\r
  98 >>>  . ./test-lib.sh\r
  99 >>>  \r
 100 >>>  run_test(){\r
 101 >>> -    result=$(LD_LIBRARY_PATH="$TEST_DIRECTORY/../lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" $TEST_DIRECTORY/symbol-test 2>&1)\r
 102 >>> +    case $(uname -s) in\r
 103 >>> +    Darwin)\r
 104 >>> +        result=$(DYLD_FALLBACK_LIBRARY_PATH="${DYLD_FALLBACK_LIBRARY_PATH:+$DYLD_FALLBACK_LIBRARY_PATH:}$TEST_DIRECTORY/../lib" $TEST_DIRECTORY/symbol-test 2>&1)\r
 105 >>> +        ;;\r
 106 >>> +    *)\r
 107 >>> +        result=$(LD_LIBRARY_PATH="$TEST_DIRECTORY/../lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" $TEST_DIRECTORY/symbol-test 2>&1)\r
 108 >>> +        ;;\r
 109 >>> +    esac\r
 110 >>>  }\r
 111 >>>  \r
 112 >>>  output="A Xapian exception occurred opening database: Couldn't stat 'fakedb/.notmuch/xapian'\r
 113 >>> -- \r
 114 >>> 1.8.5.2 (Apple Git-48)\r
 115 >>>\r
 116 >>> _______________________________________________\r
 117 >>> notmuch mailing list\r
 118 >>> notmuch@notmuchmail.org\r
 119 >>> http://notmuchmail.org/mailman/listinfo/notmuch\r
 120 > _______________________________________________\r
 121 > notmuch mailing list\r
 122 > notmuch@notmuchmail.org\r
 123 > http://notmuchmail.org/mailman/listinfo/notmuch\r