1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id AC738431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 3 Dec 2012 01:28:02 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id kTOv39+p1ytV for <notmuch@notmuchmail.org>;
\r
17 Mon, 3 Dec 2012 01:28:02 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id BF016431FAE
\r
22 for <notmuch@notmuchmail.org>; Mon, 3 Dec 2012 01:28:01 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1TfSJe-0005uU-W7; Mon, 03 Dec 2012 09:27:55 +0000
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1TfSJe-0006HL-Jd; Mon, 03 Dec 2012 09:27:54 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Austin Clements <amdragon@MIT.EDU>
\r
33 Subject: Re: [PATCH] emacs: stash bugfix
\r
34 In-Reply-To: <20121203013402.GC1020@mit.edu>
\r
35 References: <1354443068-5030-1-git-send-email-markwalters1009@gmail.com>
\r
36 <20121203013402.GC1020@mit.edu>
\r
37 User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Mon, 03 Dec 2012 09:27:57 +0000
\r
40 Message-ID: <87ehj71o4i.fsf@qmul.ac.uk>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-Sender-Host-Address: 93.97.24.31
\r
44 X-QM-SPAM-Info: Sender has good ham record. :)
\r
45 X-QM-Body-MD5: c8fefd036ec0434acef57d560fb3d19d (of first 20000 bytes)
\r
46 X-SpamAssassin-Score: -1.7
\r
47 X-SpamAssassin-SpamBar: -
\r
48 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
50 spam. We require at least 5.0 points to mark a message as spam.
\r
51 This message scored -1.7 points.
\r
52 Summary of the scoring:
\r
53 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
55 * [138.37.6.40 listed in list.dnswl.org]
\r
56 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
57 provider * (markwalters1009[at]gmail.com)
\r
58 * 0.6 AWL AWL: From: address is in the auto white-list
\r
59 X-QM-Scan-Virus: ClamAV says the message is clean
\r
60 Cc: notmuch@notmuchmail.org
\r
61 X-BeenThere: notmuch@notmuchmail.org
\r
62 X-Mailman-Version: 2.1.13
\r
64 List-Id: "Use and development of the notmuch mail system."
\r
65 <notmuch.notmuchmail.org>
\r
66 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
68 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
69 List-Post: <mailto:notmuch@notmuchmail.org>
\r
70 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
71 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
73 X-List-Received-Date: Mon, 03 Dec 2012 09:28:02 -0000
\r
76 On Mon, 03 Dec 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
77 > Quoth Mark Walters on Dec 02 at 10:11 am:
\r
78 >> Currently an attempt to stash a non-existent field (eg cc when not
\r
79 >> present) throws an error. Catch this case and give the user a warning
\r
83 >> While messing around with notmuch-pick key bindings I found the
\r
84 >> following bug. The easiest way I have found to trigger it is cc
\r
85 >> (stash-cc) in show mode on a message with no cc header.
\r
91 >> emacs/notmuch-lib.el | 7 +++++--
\r
92 >> 1 files changed, 5 insertions(+), 2 deletions(-)
\r
94 >> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
\r
95 >> index 1d0ec17..c7d8e02 100644
\r
96 >> --- a/emacs/notmuch-lib.el
\r
97 >> +++ b/emacs/notmuch-lib.el
\r
98 >> @@ -183,8 +183,11 @@ user-friendly queries."
\r
100 >> (defun notmuch-common-do-stash (text)
\r
101 >> "Common function to stash text in kill ring, and display in minibuffer."
\r
102 >> - (kill-new text)
\r
103 >> - (message "Stashed: %s" text))
\r
106 >> + (kill-new text)
\r
107 >> + (message "Stashed: %s" text))
\r
108 >> + (message "Warning: Nothing to stash!")))
\r
110 > Without the unnecessary "Warning:" bit of the message, LGTM.
\r
112 I am obviously happy to remove the "warning": however do you think
\r
113 stashing a non-existent thing should empty the kill-ring? I am a little
\r
114 worried about someone stashing something, not noticing the "nothing to
\r
115 stash" and then pasting some random thing somewhere (eg something
\r