1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 579044196F2
\r
6 for <notmuch@notmuchmail.org>; Wed, 5 May 2010 00:24:02 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.8 tagged_above=-999 required=5 tests=[BAYES_50=0.8]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id D1GDSRf4o5wG for <notmuch@notmuchmail.org>;
\r
16 Wed, 5 May 2010 00:24:01 -0700 (PDT)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 4AF584196F0
\r
19 for <notmuch@notmuchmail.org>; Wed, 5 May 2010 00:24:01 -0700 (PDT)
\r
20 Received: from localhost (unknown [192.168.200.4])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id 65D7E19F340B;
\r
22 Wed, 5 May 2010 09:24:00 +0200 (CEST)
\r
23 X-Virus-Scanned: IMAP AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,
\r
27 with ESMTP id OKJzucNZPh0k; Wed, 5 May 2010 09:23:59 +0200 (CEST)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id D9C2B19F3378;
\r
30 Wed, 5 May 2010 09:23:58 +0200 (CEST)
\r
31 Received: from steelpick.2x.cz (k335-30.felk.cvut.cz [147.32.86.30])
\r
32 (Authenticated sender: sojkam1)
\r
33 by imap.feld.cvut.cz (Postfix) with ESMTPSA id 4366BFA003;
\r
34 Wed, 5 May 2010 09:23:58 +0200 (CEST)
\r
35 Received: from wsh by steelpick.2x.cz with local (Exim 4.71)
\r
36 (envelope-from <sojkam1@fel.cvut.cz>)
\r
37 id 1O9YxZ-0004NY-W8; Wed, 05 May 2010 09:23:58 +0200
\r
38 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
39 To: Jesse Rosenthal <jrosenthal@jhu.edu>,
\r
40 Notmuch developer list <notmuch@notmuchmail.org>
\r
41 Subject: Re: [PATCH] Modularize test suite
\r
42 In-Reply-To: <87sk6cdbxz.fsf@jhu.edu>
\r
43 References: <87sk6cdbxz.fsf@jhu.edu>
\r
44 User-Agent: Notmuch/0.3.1-31-g60b2517 (http://notmuchmail.org) Emacs/23.1.1
\r
45 (x86_64-pc-linux-gnu)
\r
46 Date: Wed, 05 May 2010 09:23:57 +0200
\r
47 Message-ID: <87bpcustf6.fsf@steelpick.2x.cz>
\r
49 Content-Type: text/plain; charset=us-ascii
\r
50 X-BeenThere: notmuch@notmuchmail.org
\r
51 X-Mailman-Version: 2.1.13
\r
53 List-Id: "Use and development of the notmuch mail system."
\r
54 <notmuch.notmuchmail.org>
\r
55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
58 List-Post: <mailto:notmuch@notmuchmail.org>
\r
59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
62 X-List-Received-Date: Wed, 05 May 2010 07:24:02 -0000
\r
64 On Fri, 30 Apr 2010, Jesse Rosenthal wrote:
\r
65 > Responding to this email is a patch to modularize the test suite. It
\r
66 > follows a relatively simple model, but it does seem like it will offer
\r
67 > some degree of flexibility. Plus, no relicensing is necessary.
\r
71 Junio has just applied relicensing patch for the Git test suite
\r
72 (http://git.kernel.org/?p=git/git.git;a=commit;h=64b90323f65d2a3ac8d1ff4ed73be881f76aac8a)
\r
73 so we can use it for notmuch.
\r
75 I have quickly looked at your modularization and I do not like that each
\r
76 test resided in a separate file. I've done similar test suite for one of
\r
77 my projects and it is a pain to modify the tests. If one test depends on
\r
78 the previous ones, you always have to switch between multiple files in
\r
81 If you agree, I can refresh my git based modularization and send
\r
82 the patches. What do you (and others) think?
\r