1 Return-Path: <james@jameswestby.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 606A7418C25
\r
6 for <notmuch@notmuchmail.org>; Tue, 13 Apr 2010 08:36:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.8 tagged_above=-999 required=5 tests=[BAYES_50=0.8]
\r
12 autolearn=unavailable
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ie2gjn-23Ke3 for <notmuch@notmuchmail.org>;
\r
16 Tue, 13 Apr 2010 08:36:38 -0700 (PDT)
\r
17 Received: from jameswestby.net (jameswestby.net [89.145.97.141])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 4D00A431FC1
\r
19 for <notmuch@notmuchmail.org>; Tue, 13 Apr 2010 08:36:38 -0700 (PDT)
\r
20 Received: from cpc4-aztw22-2-0-cust59.aztw.cable.virginmedia.com
\r
21 ([94.169.116.60] helo=flash)
\r
22 by jameswestby.net with esmtpa (Exim 4.69)
\r
23 (envelope-from <james@jameswestby.net>)
\r
24 id 1O1iAG-0007KY-MD; Tue, 13 Apr 2010 16:36:36 +0100
\r
25 Received: by flash (Postfix, from userid 1000)
\r
26 id A8A176E54D9; Tue, 13 Apr 2010 11:36:30 -0400 (EDT)
\r
27 From: James Westby <jw+debian@jameswestby.net>
\r
28 To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
\r
29 Subject: Re: [notmuch] [PATCH] Store thread ids for messages that we haven't
\r
31 In-Reply-To: <87sk6ze5v3.fsf@yoom.home.cworth.org>
\r
32 References: <87fx72o8pq.fsf@yoom.home.cworth.org>
\r
33 <1268515677-12692-1-git-send-email-jw+debian@jameswestby.net>
\r
34 <87sk6ze5v3.fsf@yoom.home.cworth.org>
\r
35 Date: Tue, 13 Apr 2010 16:36:30 +0100
\r
36 Message-ID: <874ojftldt.fsf@jameswestby.net>
\r
38 Content-Type: text/plain; charset=us-ascii
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Tue, 13 Apr 2010 15:36:40 -0000
\r
53 On Tue, 13 Apr 2010 08:20:48 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
54 > Thanks for this patch, James! It's especially nice to have the fix come
\r
55 > in with additions to the test suite as well.
\r
57 Thanks for including a test suite I could add to!
\r
59 > I did split up the commit so the addition to the test suite happens
\r
60 > first. That way it's easy to test the test itself, (verifying that it
\r
61 > fails before the fix, and then passes after the fix).
\r
63 Your choice. I prefer putting them in the same commit to be more
\r
64 self-documenting, and then using the capabilities of my VCS to verify
\r
65 the change if i desire.
\r
67 > I also added a few documentation and other cleanups as follow-on
\r
68 > commits. Hopefully, they don't change the logic at all, but make things
\r
69 > easier to understand.
\r
71 > So that's all pushed.
\r
75 > Then, I started implementing support for retroactively storing
\r
76 > thread_ids for non-existing messages references in already-existing
\r
77 > messages. It took me perhaps too long that a change like that, (while
\r
78 > useful), is too invasive for the current 0.2 release, and not essential
\r
79 > for this particular feature.
\r
81 This would fix up threads for all existing messages? Probably a good
\r
82 thing to have, but not that important to me. In my case I can always
\r
83 open the bug in my browser if I want to see the full conversation.
\r
85 > So I've postponed that part at least. I hope to make a database-schema
\r
86 > upgrade a key part of a release in a couple of cycles, (for this
\r
87 > feature and for "list:" and "folder:").
\r
89 Cool, I look forward to it.
\r