1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 02D1A429E21
\r
6 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 05:56:45 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id CS13BJ4JNLeF for <notmuch@notmuchmail.org>;
\r
16 Wed, 16 Nov 2011 05:56:44 -0800 (PST)
\r
17 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
18 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 1B610431FB6 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 05:56:43 -0800
\r
22 Received: by wwf10 with SMTP id 10so599255wwf.2
\r
23 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 05:56:41 -0800 (PST)
\r
24 Received: by 10.180.73.130 with SMTP id l2mr6008216wiv.21.1321451801412;
\r
25 Wed, 16 Nov 2011 05:56:41 -0800 (PST)
\r
26 Received: from localhost ([109.131.148.49])
\r
27 by mx.google.com with ESMTPS id co5sm16398747wib.8.2011.11.16.05.56.39
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Wed, 16 Nov 2011 05:56:40 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Austin Clements <amdragon@MIT.EDU>, David Bremner <david@tethera.net>
\r
32 Subject: Re: [PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on
\r
33 threads, not messages
\r
34 In-Reply-To: <20111112163502.GE2658@mit.edu>
\r
35 References: <1310313335-4159-1-git-send-email-pieter@praet.org>
\r
36 <1310313335-4159-7-git-send-email-pieter@praet.org>
\r
37 <87fwht2u9k.fsf@rocinante.cs.unb.ca>
\r
38 <20111112163502.GE2658@mit.edu>
\r
39 User-Agent: Notmuch/0.9+76~g2fd88e6 (http://notmuchmail.org) Emacs/23.3.1
\r
40 (x86_64-unknown-linux-gnu)
\r
41 Date: Wed, 16 Nov 2011 14:55:41 +0100
\r
42 Message-ID: <871ut8f9ya.fsf@praet.org>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Wed, 16 Nov 2011 13:56:45 -0000
\r
60 On Sat, 12 Nov 2011 11:35:02 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
61 > Quoth David Bremner on Nov 12 at 11:13 am:
\r
62 > > On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet <pieter@praet.org> wrote:
\r
63 > > > In order to be consistent with `notmuch-search-{add,remove}-tag' ("+"/"-"),
\r
64 > > > `notmuch-search-operate-all' ("*") should operate on matching threads
\r
65 > > > instead of matching messages.
\r
68 > > As far as I can tell, the follow-up series for the race condition kindof
\r
69 > > got stalled. Am I right in thinking this bug fix should still be
\r
70 > > applied? I didn't see any review/feedback on the list.
\r
72 > We concluded that fixing the tagging race correctly was actually a lot
\r
73 > of work, which should be done but hasn't yet. We have to add message
\r
74 > IDs or docids to the search results, which is difficult to do with the
\r
75 > current text format, so rather than further entrenching ourselves, we
\r
76 > should first we should migrate Emacs to using the JSON-based search
\r
80 Yeah, sorry I haven't replied there yet. Still haven't found a
\r
81 sufficiently uninterrupted stretch of time to give the *massive*
\r
82 amount of work you did the attention it deserves.
\r
84 > However, this series doesn't actually have much to do with the race.
\r
86 Correct. Only patch #4 is more or less relevant to fixing the
\r
87 `notmuch-search-operate-all' race condition (safety net for when
\r
88 I make stupid mistakes).
\r
90 Patches #1-3 should have been in a separate thread (or as updates in
\r
91 their original thread [1]), but since #1 and #2 are mainly there to
\r
92 support #3 and #3 is tagging-related, I though it wouldn't hurt to
\r
95 Patches #5-6 are a matter of opinion:
\r
97 > I think the question here is whether notmuch-search-operate-all should
\r
98 > affect only matched messages or entire threads. It seems to me it
\r
99 > should affect all threads, since that's what you're seeing visually,
\r
100 > but other people may disagree.
\r
103 Same here. I don't use it that often, but if its name includes
\r
104 "operate-all", it should do just that, or the function should be
\r
107 > The test patches seem reasonable, though they could use a little
\r
108 > review before being pushed.
\r
110 I'd really appreciate it.
\r
112 AFAIC, increasing test coverage should be a top priority.
\r
120 [1] id:"1305275652-22956-1-git-send-email-pieter@praet.org"
\r