1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0FFA2429E21
\r
6 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 03:08:25 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YJuOSRW949ps for <notmuch@notmuchmail.org>;
\r
16 Wed, 16 Nov 2011 03:08:24 -0800 (PST)
\r
17 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
18 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 D3BC9431FB6 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 03:08:23 -0800
\r
22 Received: by wwf10 with SMTP id 10so374600wwf.2
\r
23 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 03:08:21 -0800 (PST)
\r
24 Received: by 10.216.229.27 with SMTP id g27mr453732weq.67.1321441701248;
\r
25 Wed, 16 Nov 2011 03:08:21 -0800 (PST)
\r
26 Received: from localhost ([109.131.148.49]) by mx.google.com with ESMTPS id
\r
27 fy13sm32345923wbb.18.2011.11.16.03.08.19
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Wed, 16 Nov 2011 03:08:20 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Jani Nikula <jani@nikula.org>, David Bremner <david@tethera.net>,
\r
32 notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH] add `tag:' prefix to `--output=tags' results
\r
34 In-Reply-To: <87k474cdo4.fsf@nikula.org>
\r
35 References: <877hbiep5g.fsf@SSpaeth.de>
\r
36 <1309422029-22924-1-git-send-email-pieter@praet.org>
\r
37 <87k475mktx.fsf@rocinante.cs.unb.ca> <87k474cdo4.fsf@nikula.org>
\r
38 User-Agent: Notmuch/0.9+76~g2fd88e6 (http://notmuchmail.org) Emacs/23.3.1
\r
39 (x86_64-unknown-linux-gnu)
\r
40 Date: Wed, 16 Nov 2011 12:07:22 +0100
\r
41 Message-ID: <87hb24fhqt.fsf@praet.org>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Wed, 16 Nov 2011 11:08:25 -0000
\r
58 On Sun, 13 Nov 2011 16:14:35 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
59 > On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner <david@tethera.net> wrote:
\r
60 > > On Thu, 30 Jun 2011 10:20:29 +0200, Pieter Praet <pieter@praet.org> wrote:
\r
61 > > > Alter `do_search_tags()' to prepend each result with `tag:',
\r
62 > > > and update affected test.
\r
64 > > > This makes its output consistent with `do_search_threads()' and
\r
65 > > > `do_search_messages()'.
\r
67 > > What do people think about this change? Personally I will have change
\r
68 > > some scripts to not add "tag:", but it isn't that big of a deal.
\r
70 > I'm curious why this change is needed in the first place. What is gained
\r
71 > from this in addition to consistency? It seems I don't have enough list
\r
72 > history to find the referenced discussion.
\r
75 Here's the original thread:
\r
76 http://comments.gmane.org/gmane.mail.notmuch.general/3562
\r
78 > The command line interface is an API, and this change causes regressions
\r
79 > in all scripts and programs using it, including the emacs ui. [...]
\r
81 Indeed. There's something to be said for consistency, but a change like
\r
82 this is likely to cause more problems than it will solve.
\r
85 > should probably be fixed with something other than "...a quick'n'dirty
\r
86 > patch, thus probably not fit for consumption.")
\r
89 Couldn't agree more. I wrongly assumed that the test suite would
\r
90 sufficiently cover such fundamental functionality, and upon realizing
\r
91 that it didn't, I quickly submitted some half-baked fixes for the most
\r
92 glaringly obvious breakage, right before abandoning the whole deal.
\r