1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 18A75431FBD
\r
6 for <notmuch@notmuchmail.org>; Wed, 15 Jan 2014 10:03:22 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id kxjfNEXX5el4 for <notmuch@notmuchmail.org>;
\r
16 Wed, 15 Jan 2014 10:03:14 -0800 (PST)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 83439431FAF
\r
21 for <notmuch@notmuchmail.org>; Wed, 15 Jan 2014 10:03:14 -0800 (PST)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1W3Uo3-0007WZ-5c; Wed, 15 Jan 2014 14:03:11 -0400
\r
25 Received: (nullmailer pid 8859 invoked by uid 1000); Wed, 15 Jan 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime
\r
30 In-Reply-To: <cover.1385825425.git.jani@nikula.org>
\r
31 References: <cover.1385825425.git.jani@nikula.org>
\r
32 User-Agent: Notmuch/0.17+30~g50677dd (http://notmuchmail.org) Emacs/24.3.1
\r
33 (x86_64-pc-linux-gnu)
\r
34 Date: Wed, 15 Jan 2014 14:03:06 -0400
\r
35 Message-ID: <87ob3di0md.fsf@zancas.localnet>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Wed, 15 Jan 2014 18:03:22 -0000
\r
52 Jani Nikula <jani@nikula.org> writes:
\r
54 > This is v2 of id:cover.1381948853.git.jani@nikula.org with more polish.
\r
56 > Patches 1-4 do prep work to fix some of the differences in the parsers
\r
57 > in advance. Arguably they are not that bad regardless of the parser
\r
60 > Patches 5-6 actually make the change. Having two patches is a somewhat
\r
61 > artificial division, but perhaps makes it easier to review.
\r
64 I had a quick look at these changes, and nothing jumped out at me. I'd
\r
65 appreciate a second pair of eyes on them.
\r
67 I ran the performance suite, and there is only one message (in version
\r
68 0.4 of the corpus) newly classified as non-mail. Of course I did clean
\r
69 up the corpus a bunch from 0.3 to 0.4. I didn't see any shocking changes
\r
70 in performance before and after the patches. I only had patience enough
\r
71 to run twice in both cases.
\r