1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 672FE429E21
\r
6 for <notmuch@notmuchmail.org>; Thu, 17 Nov 2011 03:20:25 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 6WRi8OUMgSIV for <notmuch@notmuchmail.org>;
\r
17 Thu, 17 Nov 2011 03:20:24 -0800 (PST)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 96A91431FD0
\r
22 for <notmuch@notmuchmail.org>; Thu, 17 Nov 2011 03:20:24 -0800 (PST)
\r
23 Received: by bkaq10 with SMTP id q10so1984095bka.26
\r
24 for <notmuch@notmuchmail.org>; Thu, 17 Nov 2011 03:20:23 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=UbgsyoAh8M4+MU5rtHVfIcNvDEK9ICzEedcPLcFhauk=;
\r
29 b=IVH1qJoMZp24Y1HLZVBsxYUMIogucGyJqV1MCJdN/s6q8WkNYNzQ8f3+l4tt1MUFdF
\r
30 LdidVOxxZjK+3kh0CYl6tVCNF2DZe35FrzCYlYNGVhY349pR/sxgYlsIf8Sfa8te99QB
\r
31 Ht0z6F30ziz/ux02o8XowGdVdlipDBxPG9zqI=
\r
32 Received: by 10.205.119.11 with SMTP id fs11mr33714353bkc.58.1321528823228;
\r
33 Thu, 17 Nov 2011 03:20:23 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id f14sm18506161bkv.3.2011.11.17.03.20.22
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Thu, 17 Nov 2011 03:20:22 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
40 notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH 0/9] test: (hopefully) better test prerequisites
\r
42 In-Reply-To: <874ny36rhc.fsf@servo.finestructure.net>
\r
43 References: <1321494986-18998-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <874ny36rhc.fsf@servo.finestructure.net>
\r
45 User-Agent: Notmuch/0.10_rc1+9~g8270095 (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Thu, 17 Nov 2011 15:20:07 +0400
\r
48 Message-ID: <87hb23nggo.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Thu, 17 Nov 2011 11:20:25 -0000
\r
67 On Thu, 17 Nov 2011 01:14:07 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
68 > On Thu, 17 Nov 2011 05:56:17 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
69 > > The following patch series is an attempt to introduce proper
\r
70 > > dependencies for external binaries in a less intrusive way than
\r
71 > > [1]. The primary aim was to avoid changing every subtest that
\r
72 > > uses external binaries.
\r
74 > Hey, Dmitry. Thanks so much for reworking Pieter's original test suite
\r
75 > improvements. I think this new approach is a bit less invasive and a
\r
76 > little more elegant to work with.
\r
78 > I've looked through the patchs, and they all look ok on first glance
\r
79 > (barring any possibly needed modifications that I'm not seeing). I have
\r
80 > a couple of comments to follow.
\r
82 > However, when I tried to test the tests with the patch applied I ran
\r
83 > into one problem. If I try to run the test suite with dtach
\r
84 > uninstalled, it looks like I'm experiencing a hang on
\r
85 > emacs_deliver_message call. I wonder if either emacs_deliver_message or
\r
86 > test_emacs is not doing the right thing in the case of no dtach. I
\r
87 > think emacs_deliver_message should somehow not require dtach, since it's
\r
88 > not actually testing any display stuff, but because it's currently using
\r
89 > test_emacs, it is somehow implicitly depending on it. Any thoughts on
\r
93 I bet you stumbled upon a hanging smtp-dummy. There is a patch [1] to
\r
94 fix that. Hopefully it would get pushed soon.
\r
96 As for not requiring dtach for emacs_deliver_message, that is definitely
\r
97 possible. Currently, there is only one way to run emacs to keep it
\r
98 simple. And I am not sure if running emacs_deliver_message without
\r
99 dtach costs extra code.
\r
104 [1] id:"yf639dnsqtc.fsf@taco2.nixu.fi"
\r