1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C742F431FBC
\r
6 for <notmuch@notmuchmail.org>; Mon, 20 May 2013 08:45:56 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id FZiuxsSOfsIN for <notmuch@notmuchmail.org>;
\r
16 Mon, 20 May 2013 08:45:49 -0700 (PDT)
\r
17 Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 257FB431FB6
\r
21 for <notmuch@notmuchmail.org>; Mon, 20 May 2013 08:45:49 -0700 (PDT)
\r
22 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
23 by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4KFjl4H008228;
\r
24 Mon, 20 May 2013 12:45:47 -0300
\r
25 Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
26 ([156.34.82.78] helo=zancas.localnet)
\r
27 by tesseract.cs.unb.ca with esmtpsa
\r
28 (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
\r
29 (envelope-from <david@tethera.net>)
\r
30 id 1UeSHT-0007T2-CW; Mon, 20 May 2013 12:45:47 -0300
\r
31 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
32 (envelope-from <david@tethera.net>)
\r
33 id 1UeSHN-0007hv-HX; Mon, 20 May 2013 12:45:41 -0300
\r
34 From: David Bremner <david@tethera.net>
\r
35 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
36 Subject: Re: [PATCH] emacs: Avoid deprecated function flet
\r
37 In-Reply-To: <1368976447-5153-1-git-send-email-amdragon@mit.edu>
\r
38 References: <87vc6fjjdp.fsf@zancas.localnet>
\r
39 <1368976447-5153-1-git-send-email-amdragon@mit.edu>
\r
40 User-Agent: Notmuch/0.15.2+105~ge63aa66 (http://notmuchmail.org) Emacs/24.3.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 Date: Mon, 20 May 2013 12:45:41 -0300
\r
43 Message-ID: <8761ydr6xm.fsf@zancas.localnet>
\r
45 Content-Type: text/plain
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Mon, 20 May 2013 15:45:57 -0000
\r
61 Austin Clements <amdragon@MIT.EDU> writes:
\r
63 > flet was deprecated in Emacs 24.3 and replaced with cl-flet. However,
\r
64 > cl-flet lexically binds the function symbol, while we depend on flet
\r
65 > dynamically binding the function symbol. Hence, this patch replaces
\r
66 > the deprecated flet use with letf, which lets us dynamically bind the
\r
67 > function symbol, while remaining compatible with both Emacs 23 and 24.
\r
69 The bad news: letf is also marked as obsolete, although there is no
\r
70 yelling from the byte-compiler yet.
\r
72 In my simple tests, it _seemed_ to work to replace letf with cl-letf,
\r
75 - that would require some kind of compatability alias
\r
76 - the docstring for letf mutters something about "deprecated usage of
\r
77 `symbol-function' in place forms.
\r
81 http://www.gnu.org/software/emacs/manual/html_node/elisp/Setting-Generalized-Variables.html#Setting-Generalized-Variables
\r
83 suggests using symbol-function with setf is legitimate.
\r