1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 16662431FBC
\r
6 for <notmuch@notmuchmail.org>; Wed, 21 May 2014 12:34:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Tb8XHnW9gdn8 for <notmuch@notmuchmail.org>;
\r
16 Wed, 21 May 2014 12:34:32 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 68EAB431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 21 May 2014 12:34:32 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 8E87C100090;
\r
22 Wed, 21 May 2014 22:34:26 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Fraser Tweedale <frase@frase.id.au>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib
\r
26 In-Reply-To: <20140521091304.GT62147@bacardi.hollandpark.frase.id.au>
\r
27 References: <1399753646-3026-1-git-send-email-xico@atelo.org>
\r
28 <536e965c9415e_300d7772fc9@nysa.notmuch>
\r
29 <m261ldi98h.fsf@guru.guru-group.fi>
\r
30 <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch>
\r
31 <20140521091304.GT62147@bacardi.hollandpark.frase.id.au>
\r
32 User-Agent: Notmuch/0.18+12~g9d41f94 (http://notmuchmail.org) Emacs/24.3.1
\r
33 (x86_64-unknown-linux-gnu)
\r
34 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
35 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
36 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
37 Date: Wed, 21 May 2014 22:34:25 +0300
\r
38 Message-ID: <m2ioozori6.fsf@guru.guru-group.fi>
\r
40 Content-Type: text/plain; charset=utf-8
\r
41 Content-Transfer-Encoding: quoted-printable
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Wed, 21 May 2014 19:34:40 -0000
\r
56 On Wed, May 21 2014, Fraser Tweedale <frase@frase.id.au> wrote:
\r
58 > On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote:
\r
59 >> Tomi Ollila wrote:
\r
60 >> > On Sun, May 11 2014, Felipe Contreras <felipe.contreras@gmail.com> wro=
\r
63 >> > > X=C4=ABc=C3=B2 wrote:
\r
64 >> > >> Since zlib is part of the base system, FreeBSD chose not to registe=
\r
66 >> > >> in pkg-config through zlib.pc. As a fallback test, configure will b=
\r
68 >> > >> and run a zlib version check and make sure the header and library
\r
69 >> > >> versions are compatible.
\r
71 >> > > We could try to generate our on zlib.pc, this way the configure scri=
\r
73 >> > > would be cleaner.
\r
75 >> > But for that we'd need to figure out the version, and is there simpler
\r
76 >> > robust way to do that some other way ?
\r
78 >> I don't meant to change the code that is checking for the version in the
\r
79 >> patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.c,
\r
83 > [please cc me in replies; I am not subscribed to the list]
\r
85 > I think that the additional complexity outweighs the benefit of a
\r
86 > somewhat cleaner build script.
\r
88 > If the $vz1, $vz2, et al. are what's bothering you, perhaps we could
\r
89 > push the complexity of version comparison into have_zlib.c and
\r
90 > supply the (string) version number as an argument to the program.
\r
91 > The have_zlib program could do the comparison and exit accordingly,
\r
92 > and plain old "1.2.5.2" can take its place in the configure script
\r
95 > However, I don't see any problems with the patch as it is; I have
\r
96 > tested it on FreeBSD 10.0 and it works.
\r
100 http://mid.gmane.org/1399864172-28227-1-git-send-email-felipe.contreras@gma=
\r
111 >> Felipe Contreras
\r