8a/296db0828c5e31509b062c74df05fdbb839e2d

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 75454431FAF\r
   6         for <notmuch@notmuchmail.org>; Thu,  9 Aug 2012 07:13:51 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id EMXdIqB+-vpR for <notmuch@notmuchmail.org>;\r
  16         Thu,  9 Aug 2012 07:13:51 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
  18         [18.9.25.12])\r
  19         by olra.theworths.org (Postfix) with ESMTP id D34FC431FAE\r
  20         for <notmuch@notmuchmail.org>; Thu,  9 Aug 2012 07:13:50 -0700 (PDT)\r
  21 X-AuditID: 1209190c-b7f806d000006b87-a4-5023c59eb429\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 4D.07.27527.E95C3205; Thu,  9 Aug 2012 10:13:50 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q79EDnHw025112; \r
  27         Thu, 9 Aug 2012 10:13:50 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q79EDl5B023933\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Thu, 9 Aug 2012 10:13:49 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SzTUg-0001bF-SU; Thu, 09 Aug 2012 10:13:46 -0400\r
  37 Date: Thu, 9 Aug 2012 10:13:46 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Jameson Graef Rollins <jrollins@finestructure.net>\r
  40 Subject: Re: [PATCH] emacs: Fix "not defined at runtime" warning\r
  41 Message-ID: <20120809141346.GH11179@mit.edu>\r
  42 References: <1344462010-5349-1-git-send-email-amdragon@mit.edu>\r
  43         <87628sa4a8.fsf@servo.finestructure.net>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: text/plain; charset=us-ascii\r
  46 Content-Disposition: inline\r
  47 In-Reply-To: <87628sa4a8.fsf@servo.finestructure.net>\r
  48 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  49 X-Brightmail-Tracker:\r
  50  H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1p13VDnA4NU7aYs9+7wsrt+cyezA\r
  51         5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgylj6ZwVxwmKvi3PLfLA2MKzm6GDk5JARMJLpX\r
  52         PGCBsMUkLtxbz9bFyMUhJLCPUWLHnUZ2CGc9o8TcI9+YIZwTTBINZ9cxQjhLGCU2HNrABNLP\r
  53         IqAi0bh1BZjNJqAhsW3/ckYQW0TATKLnyx8wm1lAWuLb72awGmEBB4mDW5ezgti8AjoSGxc0\r
  54         s4PYQgJZElfvb2eDiAtKnJz5hAWiV0vixr+XQL0cYHOW/wN7gVPAVKJp+TawVlGgE6ac3MY2\r
  55         gVFoFpLuWUi6ZyF0L2BkXsUom5JbpZubmJlTnJqsW5ycmJeXWqRrqJebWaKXmlK6iREc1JI8\r
  56         OxjfHFQ6xCjAwajEw3tprVKAEGtiWXFl7iFGSQ4mJVFetv3KAUJ8SfkplRmJxRnxRaU5qcWH\r
  57         GCU4mJVEeO/0AeV4UxIrq1KL8mFS0hwsSuK8l1Nu+gsJpCeWpGanphakFsFkZTg4lCR41x0B\r
  58         ahQsSk1PrUjLzClBSDNxcIIM5wEafgmkhre4IDG3ODMdIn+KUVFKnDcLJCEAksgozYPrhSWd\r
  59         V4ziQK8I8+4FqeIBJiy47ldAg5mABh8WVQIZXJKIkJJqYJR5WX36DN/x3rIVr/d/fzih7lB1\r
  60         cHvRRm4muXq33o0Lar4fyPVI2qKz5O/jWFE54Swew3Zt04ViTHxMAWGqHKHGVy9PXep+fvvk\r
  61         Z2ozJKQ6nv2tb54ettNAZJvRKu8onvpwm8Nv/92oi6h6l7PWKO8uT1Sgz47Qk5L33k/9PZPR\r
  62         y95/CbvCXyWW4oxEQy3mouJEAGP8D/0VAwAA\r
  63 Cc: notmuch@notmuchmail.org\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Thu, 09 Aug 2012 14:13:51 -0000\r
  77 \r
  78 Quoth Jameson Graef Rollins on Aug 09 at 12:54 am:\r
  79 > On Wed, Aug 08 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
  80 > > Previously, the Emacs byte compiler produced the warning\r
  81 > >\r
  82 > >     the function `remove-if-not' might not be defined at runtime.\r
  83 > >\r
  84 > > because we only required cl at compile-time (not runtime).  This fixes\r
  85 > > this warning by requiring cl at runtime, ensuring that the definition\r
  86 > > of remove-if-not is available.\r
  87 > > ---\r
  88 > >  emacs/notmuch-lib.el |    2 +-\r
  89 > >  1 file changed, 1 insertion(+), 1 deletion(-)\r
  90 > >\r
  91 > > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
  92 > > index 30db58f..900235b 100644\r
  93 > > --- a/emacs/notmuch-lib.el\r
  94 > > +++ b/emacs/notmuch-lib.el\r
  95 > > @@ -24,7 +24,7 @@\r
  96 > >  (require 'mm-view)\r
  97 > >  (require 'mm-decode)\r
  98 > >  (require 'json)\r
  99 > > -(eval-when-compile (require 'cl))\r
 100 > > +(require 'cl)\r
 101 > >  \r
 102 > >  (defvar notmuch-command "notmuch"\r
 103 > >    "Command to run the notmuch binary.")\r
 104 > \r
 105 > LGTM.  I think it would be good to finally just give in a require cl, so\r
 106 > we can finally put to rest the long standing schizophrenia we've had in\r
 107 > regards to using it, and maybe finally kill the compile warnings that\r
 108 > keep popping up.\r
 109 \r
 110 I think we already gave in [0], we just weren't very thorough about\r
 111 it.\r
 112 \r
 113 [0] id:"m262g864dz.fsf@wal122.wireless-pennnet.upenn.edu"\r