1 Return-Path: <telenczuk@unic.cnrs-gif.fr>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C3266431FCB
\r
6 for <notmuch@notmuchmail.org>; Mon, 12 Jan 2015 15:47:27 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
\r
12 tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id tW6xknrgwzbx for <notmuch@notmuchmail.org>;
\r
16 Mon, 12 Jan 2015 15:47:24 -0800 (PST)
\r
17 Received: from smtp.webfaction.com (mail6.webfaction.com [74.55.86.74])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 97CDD431FC3
\r
19 for <notmuch@notmuchmail.org>; Mon, 12 Jan 2015 15:47:24 -0800 (PST)
\r
20 Received: from localhost (87-231-242-54.rev.numericable.fr [87.231.242.54])
\r
21 by smtp.webfaction.com (Postfix) with ESMTP id 601EC26EA361;
\r
22 Mon, 12 Jan 2015 23:47:22 +0000 (UTC)
\r
23 Date: Tue, 13 Jan 2015 00:47:19 +0100
\r
24 From: Bartosz Telenczuk <telenczuk@unic.cnrs-gif.fr>
\r
25 To: Ian Main <imain@stemwinder.org>,
\r
26 notmuch@notmuchmail.org
\r
27 Message-ID: <54b45d071fd20_7f93fe5bd4401f087@bts-MacBook-Pro.local.notmuch>
\r
28 In-Reply-To: <1413828111-2879-1-git-send-email-imain@stemwinder.org>
\r
29 References: <1412618116-27586-1-git-send-email-imain@stemwinder.org>
\r
30 <1413828111-2879-1-git-send-email-imain@stemwinder.org>
\r
31 Subject: RE: [PATCH v3] VIM: Improve moving between messages in a thread
\r
33 Content-Type: text/plain;
\r
35 Content-Transfer-Encoding: 7bit
\r
36 X-Mailman-Approved-At: Tue, 13 Jan 2015 09:38:02 -0800
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Mon, 12 Jan 2015 23:47:27 -0000
\r
53 The patch looks good. I tested it on my system and it works fine. I just have one suggestion regarding coding style.
\r
55 > +function! s:show_prev_msg()
\r
56 > function! s:show_next_msg()
\r
58 Since these functions are almost the same, you could avoid code repetition by replacing them by a function which takes (positive or negative) increment as an argument.
\r