1 Return-Path: <BATV+47682ed40cd14f842012+2424+infradead.org+hohndel@bombadil.srs.infradead.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D16AF4196F2
\r
6 for <notmuch@notmuchmail.org>; Mon, 12 Apr 2010 21:10:41 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5
\r
12 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id SYLAS6cywp6N for <notmuch@notmuchmail.org>;
\r
16 Mon, 12 Apr 2010 21:10:40 -0700 (PDT)
\r
17 Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id DBA1E431FC1
\r
19 for <notmuch@notmuchmail.org>; Mon, 12 Apr 2010 21:10:40 -0700 (PDT)
\r
20 Received: from localhost ([::1] helo=x200.gr8dns.org)
\r
21 by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux))
\r
22 id 1O1XRt-0005iU-Fg; Tue, 13 Apr 2010 04:10:11 +0000
\r
23 Received: by x200.gr8dns.org (Postfix, from userid 500)
\r
24 id 09A3CC00E1; Mon, 12 Apr 2010 21:09:51 -0700 (PDT)
\r
25 From: Dirk Hohndel <hohndel@infradead.org>
\r
26 To: Tomas Carnecky <tom@dbservice.com>, Mikhail Gusarov
\r
27 <dottedmag@dottedmag.net>
\r
28 Subject: Re: Use of strcasestr
\r
29 In-Reply-To: <4BC3D137.6010801@dbservice.com>
\r
30 References: <4BC326F2.10300@dbservice.com>
\r
31 <87zl182znk.fsf@leibnitz.dottedmag.net>
\r
32 <4BC3D137.6010801@dbservice.com>
\r
33 Date: Mon, 12 Apr 2010 21:09:50 -0700
\r
34 Message-ID: <m3hbngc7sh.fsf@x200.gr8dns.org>
\r
36 Content-Type: text/plain; charset=us-ascii
\r
37 X-SRS-Rewrite: SMTP reverse-path rewritten from <hohndel@infradead.org> by
\r
38 bombadil.infradead.org See http://www.infradead.org/rpr.html
\r
39 Cc: notmuch <notmuch@notmuchmail.org>
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Tue, 13 Apr 2010 04:10:42 -0000
\r
54 On Tue, 13 Apr 2010 04:04:39 +0200, Tomas Carnecky <tom@dbservice.com> wrote:
\r
55 > On 4/12/10 10:18 PM, Mikhail Gusarov wrote:
\r
57 > > Twas brillig at 15:58:10 12.04.2010 UTC+02 when tom@dbservice.com did gyre and gimble:
\r
59 > > TC> In 4fd9ea0 (guess From address from Received headers, 2010-04-06) you introduced
\r
60 > > TC> strcasestr, which is not portable, see 82e47ec (notmuch reply: Use strstr
\r
61 > > TC> instead of strcasestr for portability., 2010-02-04).
\r
63 > > TC> Is strcasestr really necessary there or can it be replaced with strstr?
\r
65 > > strcasecmp is POSIX.1-2001.
\r
67 > Indeed it is, but the code uses strcasestr and I couldn't find any
\r
68 > indication which standard that function is part of.
\r
70 > Adding that function to compat/ probably is the way to go, but the whole
\r
71 > compat mechanism doesn't work here. It's like if compat/Makefile.local
\r
72 > was not included in the top-level makefile, notmuch_compat_srcs is empty
\r
73 > there. Any ideas how to debug that?
\r
75 While I don't have access to a system that doesn't provide strcasest
\r
76 right now... I'll submit a patch in a moment that should add a
\r
77 replacement function to compat.
\r
79 Please check and make sure this works...
\r
87 Intel Open Source Technology Center
\r