1 Return-Path: <jan@ryngle.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 74E87431FBF
\r
6 for <notmuch@notmuchmail.org>; Sun, 22 Nov 2009 18:47:26 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id sBBGF8vs6YUS for <notmuch@notmuchmail.org>;
\r
11 Sun, 22 Nov 2009 18:47:25 -0800 (PST)
\r
12 Received: from mail-bw0-f224.google.com (mail-bw0-f224.google.com
\r
14 by olra.theworths.org (Postfix) with ESMTP id 95837431FAE
\r
15 for <notmuch@notmuchmail.org>; Sun, 22 Nov 2009 18:47:25 -0800 (PST)
\r
16 Received: by bwz24 with SMTP id 24so3606156bwz.30
\r
17 for <notmuch@notmuchmail.org>; Sun, 22 Nov 2009 18:47:24 -0800 (PST)
\r
19 Received: by 10.204.26.152 with SMTP id e24mr4236487bkc.119.1258944444721;
\r
20 Sun, 22 Nov 2009 18:47:24 -0800 (PST)
\r
21 In-Reply-To: <876392ge3i.fsf@yoom.home.cworth.org>
\r
22 References: <1258893156-25849-1-git-send-email-jan@ryngle.com>
\r
23 <876392ge3i.fsf@yoom.home.cworth.org>
\r
24 Date: Mon, 23 Nov 2009 03:47:24 +0100
\r
25 Message-ID: <f35dbb950911221847h6afa4bd4n9a634426613fed5d@mail.gmail.com>
\r
26 From: Jan Janak <jan@ryngle.com>
\r
27 To: Carl Worth <cworth@cworth.org>
\r
28 Content-Type: text/plain; charset=UTF-8
\r
29 Cc: notmuch@notmuchmail.org
\r
30 Subject: Re: [notmuch] [PATCH] notmuch-new: Eliminate gcc warning caused by
\r
32 X-BeenThere: notmuch@notmuchmail.org
\r
33 X-Mailman-Version: 2.1.12
\r
35 List-Id: "Use and development of the notmuch mail system."
\r
36 <notmuch.notmuchmail.org>
\r
37 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
38 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
39 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
40 List-Post: <mailto:notmuch@notmuchmail.org>
\r
41 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
42 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
44 X-List-Received-Date: Mon, 23 Nov 2009 02:47:26 -0000
\r
46 On Mon, Nov 23, 2009 at 3:38 AM, Carl Worth <cworth@cworth.org> wrote:
\r
47 > On Sun, 22 Nov 2009 13:32:36 +0100, Jan Janak <jan@ryngle.com> wrote:
\r
48 >> The function passed to scandir in the fourth argument takes two
\r
49 >> const void* arguments. To eliminate the gcc warning about incompatible
\r
50 >> types, we change ino_cmp to match this and then re-type the parameters
\r
51 >> in the body of ino_cmp.
\r
53 > Actually, on my system at least, (Linux with glibc 2.10.1), our current
\r
54 > function matches the prototype. So applying your patch actually
\r
55 > *introduces* a warning where there was no warning before.
\r
57 > What a nuisance...
\r
59 > Any ideas for a good fix, anyone?
\r
61 OK, I have an older version of glibc. If the original code works with
\r
62 glibc 2.10 then just ignore the patch. I think testing for a
\r
63 particular version of glibc is not worth the effort (it's just a
\r