1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1AF08429E21
\r
6 for <notmuch@notmuchmail.org>; Sun, 8 Jan 2012 18:50:06 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Cwf2JEqR0gtG for <notmuch@notmuchmail.org>;
\r
16 Sun, 8 Jan 2012 18:50:05 -0800 (PST)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 9E229431FB6
\r
20 for <notmuch@notmuchmail.org>; Sun, 8 Jan 2012 18:50:05 -0800 (PST)
\r
21 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by earth-doxen-postvirus (Postfix) with ESMTP id 2A3E466E0023;
\r
23 Sun, 8 Jan 2012 18:50:04 -0800 (PST)
\r
24 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new
\r
25 Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com
\r
26 [76.174.137.84]) (Authenticated sender: jrollins)
\r
27 by earth-doxen-submit (Postfix) with ESMTP id 0884C66E00E0;
\r
28 Sun, 8 Jan 2012 18:49:59 -0800 (PST)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id 84794A4A; Sun, 8 Jan 2012 18:49:59 -0800 (PST)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Aaron Ecay <aaronecay@gmail.com>, Notmuch Mail <notmuch@notmuchmail.org>
\r
33 Subject: Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal
\r
34 function for general thread tagging
\r
35 In-Reply-To: <m239bpk7h0.fsf@gmail.com>
\r
36 References: <1325975294-646-1-git-send-email-jrollins@finestructure.net>
\r
37 <1325975294-646-2-git-send-email-jrollins@finestructure.net>
\r
38 <1325975294-646-3-git-send-email-jrollins@finestructure.net>
\r
39 <m239bpk7h0.fsf@gmail.com>
\r
40 User-Agent: Notmuch/0.10.2+168~g34b8bac (http://notmuchmail.org) Emacs/23.3.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 Date: Sun, 08 Jan 2012 18:49:56 -0800
\r
43 Message-ID: <87boqdr3mz.fsf@servo.finestructure.net>
\r
45 Content-Type: multipart/signed; boundary="=-=-=";
\r
46 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Mon, 09 Jan 2012 02:50:06 -0000
\r
62 Content-Type: text/plain; charset=utf-8
\r
63 Content-Transfer-Encoding: quoted-printable
\r
65 Thanks so much for the review, Aaron.
\r
67 On Sun, 08 Jan 2012 20:08:59 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
\r
68 > A couple of comments on the arguments:
\r
69 > - It would be good to make show-next &optional. This will enable code
\r
70 > to call the fn with only two arguments, and not showing next will be
\r
71 > the default behavior.
\r
73 That's a nice idea. Probably better for a separate patch, though.
\r
75 > - A more lispy way of specifying the sign would be to use a
\r
76 > boolean. Perhaps you could call this =E2=80=9Cremove=E2=80=9D; a value=
\r
77 of =E2=80=98t=E2=80=99 would
\r
78 > remove the tag; =E2=80=98nil=E2=80=99 would add it. Moving this argume=
\r
79 nt after =E2=80=98tag=E2=80=99
\r
80 > and also making it &optional woudl allow this fn to be called with one
\r
81 > arg to add a tag. (Maybe this is too minimalist and API, however.)=20
\r
83 That might be more lispy, but it seems a lot less clear to me. It might
\r
84 save a few keystrokes when coding, but it would definitely make the code
\r
85 a lot harder to read ("remove" to add a tag?). I think I would prefer
\r
86 people to give the sign explicitly.
\r
88 > No second set of parens is needed around tag-function.
\r
90 Yeah, I've seen this either way. I guess it's just a stylistic choice.
\r
92 I think it might make sense, but again I think that's out of the scope
\r
93 of this patch series. The point was to make a minimal set of
\r
94 modifications here. If we want to separate out the functionality, we
\r
95 should do that in a separate patch.
\r
97 Thanks again for the review.
\r
102 Content-Type: application/pgp-signature
\r
104 -----BEGIN PGP SIGNATURE-----
\r
105 Version: GnuPG v1.4.11 (GNU/Linux)
\r
107 iQIcBAEBCAAGBQJPClXVAAoJEO00zqvie6q88GcP/jPFYZv1beZqV9ohNEpF8vfo
\r
108 Jz+9rrKhW+85Sb2p6yjRq7F9zt4L6HBCLyhL6iIUOMgyD3RI/cSSGlOVqzc/sxPk
\r
109 8r5lYYIVa4J+61zXCh9anTh8VqKzCmVoVSGTlzCjzj4dfKAIyfI+HR7z86H3Egf3
\r
110 xDD5iMyt2SfiWOYmL3gCu2uYNKGvZ21okiRLbbbpfg5jZS9S/mZKlR9FvILxN1Le
\r
111 ftpEakv7qUkqfPL5yZOyZeoQ2/PyRf6hGeWswnqF/jJsliKhh0YmwkYkDcXk31XV
\r
112 2pSCAZcHJZCiFdZlA0OX1OJUWYLDlyeiKOOxZQcJMT1iUOTRN+YhGhRAy3NlmKvn
\r
113 9Oe3iuLhP0f7WG7/bXeuCAuO3LbQkaCZZnaDBHw3lz0coJPyM+2SYLnd2XJj9Q6T
\r
114 KRTP0ZwTNN/L0DBDmfS0i45oxFj4JXna5GVHfKnwTTf5EeXegs38VwAFgVY6I3ba
\r
115 Qki5KgTn1mNkmQBUIWYOwbb0HeIvaUhMInJKzoPWF3w42ZBUwa5Ak3LZ66lca3OW
\r
116 YuHZN3XRiiwOPNr4RHMT/ryrPvkZMq0/k1ejJVQ7A+EP5dVEfwBGGuwUBkHOX/Pj
\r
117 Bt1bPyNClwNblND3XbxXffP8W5iYpO4K8gQUvJjvMvUcsQr/yVJ1RFCyJjhxrbHr
\r
118 Jd+TLFsE/6X4XMX3kQ/H
\r
120 -----END PGP SIGNATURE-----
\r