1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 124546DE034D
\r
6 for <notmuch@notmuchmail.org>; Sat, 18 Jun 2016 14:33:11 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.563 tagged_above=-999 required=5 tests=[AWL=0.157,
\r
12 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7,
\r
13 RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled
\r
14 Received: from arlo.cworth.org ([127.0.0.1])
\r
15 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id DzYal-iuqjuB for <notmuch@notmuchmail.org>;
\r
17 Sat, 18 Jun 2016 14:33:01 -0700 (PDT)
\r
18 Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com
\r
19 [74.125.82.48]) by arlo.cworth.org (Postfix) with ESMTPS id F3C5E6DE009B for
\r
20 <notmuch@notmuchmail.org>; Sat, 18 Jun 2016 14:33:00 -0700 (PDT)
\r
21 Received: by mail-wm0-f48.google.com with SMTP id f126so26576607wma.1
\r
22 for <notmuch@notmuchmail.org>; Sat, 18 Jun 2016 14:32:59 -0700 (PDT)
\r
23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
24 d=nikula-org.20150623.gappssmtp.com; s=20150623;
\r
25 h=from:to:cc:subject:date:message-id;
\r
26 bh=1HS1uf1nFktnx1BeEDtd535w4FrnrNu2Y3povby2Kqw=;
\r
27 b=Ix+CM3+wGtB84LFUyD+FqV4tjjOycdw6xOB49NFmnlrFu/LGdBcMYY8igXIDbP9/FM
\r
28 OEtDlVgg5laLuGAwRWjQ3EJIUaeBHtfw9R5xxvWh+tnidYbSavBchd+WTQLp/uZ7IlxU
\r
29 PCKIAIKllgDE8VnTlr8J3XHU3eJB3MHnCrFSxUrYGB0+f/UQU2T7Risk5XizsNr/0DB5
\r
30 r3tlt5/TMpdSKJbHNyk71mrwlTCUGqkXtdIxn2NfSoUfRPRoW7CQdbY5W5gCNjh7BWkC
\r
31 6GMHbaqXdZb6N3t6e35z2EAog+NdY1uQlQCCBavtSF3503sWfoEbjDWDoWtR0ImJWk38
\r
33 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
34 d=1e100.net; s=20130820;
\r
35 h=x-gm-message-state:from:to:cc:subject:date:message-id;
\r
36 bh=1HS1uf1nFktnx1BeEDtd535w4FrnrNu2Y3povby2Kqw=;
\r
37 b=SlZWoTk/b36ozxBp0QC/U+WkJrRFQuJSGouaGQzqZ+C8XrY+iEfQQ9vQgE93wWP/Rz
\r
38 Yoen9nzHEvEXv/csv7VQaP5408F8LonDPnmYbJvIA2OarjXO6npYcyx+s3dnoI3ye82f
\r
39 VxWAbxE99vdl9h4LhtCr32BXWf1OipUsC9U7o2TdaPSMMqUGEhuOvWLz0+TQRuZYzENz
\r
40 XDQEuiN8TsKl6/x7FipP1AToE7wMftlonPJy8/1P1x/lNDB/sXEkVBgvRAi+R3Mdo0S0
\r
41 BxVAOYMW7R/2sLUJj7VNY0GbVrvJu697/eWvrdWbI1WWm4Ka/cBx3HZ+ngx8XGXF0yks
\r
44 ALyK8tKuNq3QZ1mpEWRzuWmCe5ojr6NgQDytkbePq8tf5eWBEQfB1J7dtiLiCsb6pMf2yA==
\r
45 X-Received: by 10.28.215.139 with SMTP id o133mr4203798wmg.74.1466285577830;
\r
46 Sat, 18 Jun 2016 14:32:57 -0700 (PDT)
\r
47 Received: from localhost (mobile-access-bcee4e-81.dhcp.inet.fi.
\r
49 by smtp.gmail.com with ESMTPSA id bb4sm15955208wjb.32.2016.06.18.14.32.56
\r
50 (version=TLSv1/SSLv3 cipher=OTHER);
\r
51 Sat, 18 Jun 2016 14:32:56 -0700 (PDT)
\r
52 From: Jani Nikula <jani@nikula.org>
\r
53 To: notmuch@notmuchmail.org
\r
54 Cc: jani@nikula.org,
\r
55 Daniel Kahn Gillmor <dkg@fifthhorseman.net>
\r
56 Subject: [PATCH 0/7] cli/reply: refactoring
\r
57 Date: Sun, 19 Jun 2016 00:31:26 +0300
\r
58 Message-Id: <cover.1466284726.git.jani@nikula.org>
\r
59 X-Mailer: git-send-email 2.1.4
\r
60 X-BeenThere: notmuch@notmuchmail.org
\r
61 X-Mailman-Version: 2.1.20
\r
63 List-Id: "Use and development of the notmuch mail system."
\r
64 <notmuch.notmuchmail.org>
\r
65 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
67 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
68 List-Post: <mailto:notmuch@notmuchmail.org>
\r
69 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
70 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
72 X-List-Received-Date: Sat, 18 Jun 2016 21:33:11 -0000
\r
76 I started looking at how to use GMimeMessage for the headers in notmuch
\r
77 reply, based on [1]. Turns out we *already* parse the message twice in
\r
78 most cases, once in the lib and once in mime_node_open(). However,
\r
79 notmuch reply is a mess, and passing that GMIME_MESSAGE (node->part)
\r
80 from the node to add_recipients_from_message() gets tricky. Here's a
\r
81 bunch of refactoring to make the future work easier. I like the diffstat
\r
84 Oh, as a bonus, if we ever try to get that "reply to multiple messages
\r
85 at once" feature back, this makes it easier too.
\r
90 [1] id:87bn30tdb0.fsf@nikula.org
\r
93 cli/reply: push notmuch reply format abstraction lower in the stack
\r
94 cli/reply: reuse show_reply_headers() in headers-only format
\r
95 cli/reply: unify reply format functions
\r
96 cli/reply: reorganize create_reply_message()
\r
97 cli/reply: make references header creation easier to follow
\r
98 cli/reply: reuse create_reply_message() also for headers-only format
\r
99 cli/reply: reduce the reply format abstractions
\r
101 notmuch-reply.c | 266 +++++++++++++++++---------------------------------------
\r
102 1 file changed, 79 insertions(+), 187 deletions(-)
\r