1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 64B9E429E25
\r
6 for <notmuch@notmuchmail.org>; Sat, 12 Nov 2011 01:57:28 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Ot5aNc25mLRp for <notmuch@notmuchmail.org>;
\r
16 Sat, 12 Nov 2011 01:57:27 -0800 (PST)
\r
17 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 908FA431FB6
\r
21 for <notmuch@notmuchmail.org>; Sat, 12 Nov 2011 01:57:27 -0800 (PST)
\r
22 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
23 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
24 pAC9vMjr004809; Sat, 12 Nov 2011 11:57:22 +0200
\r
25 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
26 To: Austin Clements <amdragon@mit.edu>
\r
27 Subject: [PATCH] smtp-dummy: clear sockaddr_in structure before use in bind()
\r
28 In-Reply-To: <20111112024004.GX2658@mit.edu>
\r
29 References: <yf6k477a70b.fsf@taco2.nixu.fi> <20111112024004.GX2658@mit.edu>
\r
30 User-Agent: Notmuch/0.9+23~g556c5fa (http://notmuchmail.org) Emacs/23.3.1
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Sat, 12 Nov 2011 11:57:22 +0200
\r
36 Message-ID: <yf68vnlll31.fsf@taco2.nixu.fi>
\r
38 Content-Type: text/plain; charset=us-ascii
\r
39 Cc: notmuch@notmuchmail.org
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Sat, 12 Nov 2011 09:57:28 -0000
\r
54 Any junk bytes in sockaddr_in structure before passing that
\r
55 to bind() system call may cause problems.
\r
58 Thanks Austin. Consistent style matters... And dropped the peer_addr
\r
59 setting after reading accept(2) namual page.
\r
61 test/smtp-dummy.c | 1 +
\r
62 1 files changed, 1 insertions(+), 0 deletions(-)
\r
64 diff --git a/test/smtp-dummy.c b/test/smtp-dummy.c
\r
65 index 9da8202..1778a45 100644
\r
66 --- a/test/smtp-dummy.c
\r
67 +++ b/test/smtp-dummy.c
\r
68 @@ -159,6 +159,7 @@ main (int argc, char *argv[])
\r
72 + memset (&addr, 0, sizeof (addr));
\r
73 addr.sin_family = AF_INET;
\r
74 addr.sin_port = htons (25025);
\r
75 addr.sin_addr = *(struct in_addr *) hostinfo->h_addr;
\r