1 Return-Path: <bremner@pivot.cs.unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 61BCB4196F4
\r
6 for <notmuch@notmuchmail.org>; Sat, 3 Apr 2010 14:22:05 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5
\r
12 tests=[BAYES_00=-1.9] autolearn=unavailable
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id FR-8HeeSfHlh for <notmuch@notmuchmail.org>;
\r
16 Sat, 3 Apr 2010 14:22:05 -0700 (PDT)
\r
17 Received: from pivot.cs.unb.ca (pivot.cs.unb.ca [131.202.240.57])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 091A34196F2
\r
19 for <notmuch@notmuchmail.org>; Sat, 3 Apr 2010 14:22:05 -0700 (PDT)
\r
21 fctnnbsc30w-142167190087.pppoe-dynamic.high-speed.nb.bellaliant.net
\r
22 ([142.167.190.87] helo=rocinante.cs.unb.ca)
\r
23 by pivot.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)
\r
24 (Exim 4.69) (envelope-from <bremner@pivot.cs.unb.ca>)
\r
25 id 1NyAn5-0002GY-3l; Sat, 03 Apr 2010 18:22:03 -0300
\r
26 Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.71)
\r
27 (envelope-from <bremner@rocinante.cs.unb.ca>)
\r
28 id 1NyAmz-0007BP-A6; Sat, 03 Apr 2010 18:21:57 -0300
\r
29 From: David Bremner <bremner@unb.ca>
\r
30 To: Carl Worth <cworth@cworth.org>, David Edmondson <dme@dme.org>, notmuch
\r
31 <notmuch@notmuchmail.org>
\r
32 In-Reply-To: <87tyrsz5rp.fsf@yoom.home.cworth.org>
\r
33 References: <87oci344n4.fsf@ut.hh.sledj.net>
\r
34 <87bpe2j2vu.fsf@yoom.home.cworth.org> <87oci2xmkv.fsf@ut.hh.sledj.net>
\r
35 <87d3yhihzl.fsf@yoom.home.cworth.org> <87k4spxcz7.fsf@ut.hh.sledj.net>
\r
36 <87tyrsz5rp.fsf@yoom.home.cworth.org>
\r
37 Date: Sat, 03 Apr 2010 18:21:57 -0300
\r
38 Message-ID: <87pr2gs03u.fsf@rocinante.cs.unb.ca>
\r
40 Content-Type: text/plain; charset=us-ascii
\r
41 X-Sender-Verified: bremner@pivot.cs.unb.ca
\r
42 Subject: Re: [notmuch] pull request [was Re: pull request]
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Sat, 03 Apr 2010 21:22:05 -0000
\r
57 On Sat, 03 Apr 2010 12:37:46 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
59 > If I apply this patch as is, then when compiling the notmuch-show.el I
\r
60 > get the following warnings:
\r
63 > notmuch-show.el:969:34:Warning: reference to free variable `notmuch-command'
\r
66 > notmuch-show.el:983:1:Warning: the following functions are not known to be
\r
67 > defined: point-invisible-p, mail-header-extract-no-properties,
\r
68 > notmuch-select-tag-with-completion, union, intersection, set-difference,
\r
69 > notmuch-search-show-thread, mm-display-parts, mm-dissect-buffer,
\r
70 > notmuch-save-attachments, notmuch-count-attachments, notmuch-reply,
\r
71 > mm-handle-type, mm-display-part, notmuch-fontify-headers
\r
74 This is my understanding from staring at the code for a few other
\r
75 packages; any experts feel free to contradict.
\r
77 The warnings about unknown functions can be eliminated by use the
\r
78 declare-function macro; if you have emacs lisp reference manual (it
\r
79 required the package emacs23-common-non-dfsg on Debian) then you can
\r
82 ESC ESC : (info "(elisp)Declaring Functions") <RETURN>
\r
84 For variables, the obvious approach is to make a file 'notmuch-vars.el'
\r
85 and put the variables we need in several files there.
\r