1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A250B431FBC
\r
6 for <notmuch@notmuchmail.org>; Sat, 7 Mar 2015 08:52:33 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.738 tagged_above=-999 required=5
\r
12 tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_LOW=-0.7]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id rzr9WDn9thhd for <notmuch@notmuchmail.org>;
\r
17 Sat, 7 Mar 2015 08:52:30 -0800 (PST)
\r
18 Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
\r
19 [209.85.212.182]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 34C42431FAE
\r
22 for <notmuch@notmuchmail.org>; Sat, 7 Mar 2015 08:52:30 -0800 (PST)
\r
23 Received: by wiwl15 with SMTP id l15so10425168wiw.0
\r
24 for <notmuch@notmuchmail.org>; Sat, 07 Mar 2015 08:52:29 -0800 (PST)
\r
25 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
26 d=1e100.net; s=20130820;
\r
27 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
28 :user-agent:date:message-id:mime-version:content-type;
\r
29 bh=A23WUMtuldzubV9z5XrSjHLPAWUBWUaHg5gUWi2WV+E=;
\r
30 b=g+7bUXwUFf2T5dSaEmNRPI+9GzabDEVvzBGgwK2xZiKNcHOY8PcJGS1juhayrjUNEQ
\r
31 mNy+wIPXmAyDjyNGmeqou0r/nmKAeLnvIE+iLvSCzJxZArtCVOVC3iiWwdis7lCpVL1D
\r
32 FrH9IMB34KyyuoiXcoCISxirPZ63BmsxCh8fZa1H/JeTsVBUvyJ1xph5o+pelDeWoqve
\r
33 mUerTKapwKOCxrWgYuO7J7CrYc1CYEU1YlrDbxVLFws2LQsmr7ewKisN/BRglsI+OgnM
\r
34 2LVZ+KSwUdxrHkzCja8O5YxjnuuuOGQQzsk2GFF94XdwEtc/nkzBC4WrR6xYg36/3YVA
\r
37 ALoCoQlVm8EhjcEISK9XfIr8rM/bxRS4I+GifeFQ1b0mdlgYIEUKjBlwIYwT3M0EKzMyyyJQdiDR
\r
38 X-Received: by 10.180.219.102 with SMTP id pn6mr43017026wic.50.1425747149213;
\r
39 Sat, 07 Mar 2015 08:52:29 -0800 (PST)
\r
40 Received: from localhost (mobile-internet-bcee3b-76.dhcp.inet.fi.
\r
41 [188.238.59.76]) by mx.google.com with ESMTPSA id
\r
42 a13sm20043420wjx.30.2015.03.07.08.52.28
\r
43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
44 Sat, 07 Mar 2015 08:52:28 -0800 (PST)
\r
45 From: Jani Nikula <jani@nikula.org>
\r
46 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
47 Subject: Re: [PATCH 1/2] lib: define DEPRECATED macro, document its use.
\r
48 In-Reply-To: <1425746508-16224-1-git-send-email-david@tethera.net>
\r
49 References: <1425746508-16224-1-git-send-email-david@tethera.net>
\r
50 User-Agent: Notmuch/0.19+74~g6aeef2e (http://notmuchmail.org) Emacs/24.4.1
\r
51 (x86_64-pc-linux-gnu)
\r
52 Date: Sat, 07 Mar 2015 18:52:48 +0200
\r
53 Message-ID: <87k2ysiwbj.fsf@nikula.org>
\r
55 Content-Type: text/plain
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Sat, 07 Mar 2015 16:52:33 -0000
\r
70 On Sat, 07 Mar 2015, David Bremner <david@tethera.net> wrote:
\r
71 > This has been tested with gcc and clang.
\r
73 > devel/STYLE | 10 ++++++++++
\r
74 > doc/doxygen.cfg | 2 +-
\r
75 > lib/notmuch.h | 2 ++
\r
76 > 3 files changed, 13 insertions(+), 1 deletion(-)
\r
78 > diff --git a/devel/STYLE b/devel/STYLE
\r
79 > index 92de42c..fcd5e99 100644
\r
82 > @@ -93,3 +93,13 @@ libnotmuch conventions
\r
84 > * Code which needs to be accessed from both the CLI and from
\r
85 > libnotmuch should be factored out into libutil (under util/).
\r
87 > +* Deprecated functions should be marked with the DEPRECATED macro
\r
88 > + which generates run time warnings with gcc and clang. In order not
\r
89 > + to confuse doxygen this should go at the beginning of the
\r
90 > + declaration like:
\r
92 > + DEPRECATED(major,minor) notmuch_status_t notmuch_dwim(void *arg);
\r
94 > + The @deprecated doxygen command can be used to generate markup in
\r
96 > diff --git a/doc/doxygen.cfg b/doc/doxygen.cfg
\r
97 > index 42b6339..c033f34 100644
\r
98 > --- a/doc/doxygen.cfg
\r
99 > +++ b/doc/doxygen.cfg
\r
100 > @@ -74,7 +74,7 @@ STRICT_PROTO_MATCHING = NO
\r
101 > GENERATE_TODOLIST = NO
\r
102 > GENERATE_TESTLIST = NO
\r
103 > GENERATE_BUGLIST = NO
\r
104 > -GENERATE_DEPRECATEDLIST= NO
\r
105 > +GENERATE_DEPRECATEDLIST= YES
\r
106 > ENABLED_SECTIONS =
\r
107 > MAX_INITIALIZER_LINES = 30
\r
108 > SHOW_USED_FILES = NO
\r
109 > diff --git a/lib/notmuch.h b/lib/notmuch.h
\r
110 > index 3e326bf..5fb51ba 100644
\r
111 > --- a/lib/notmuch.h
\r
112 > +++ b/lib/notmuch.h
\r
113 > @@ -59,6 +59,8 @@ NOTMUCH_BEGIN_DECLS
\r
114 > #define LIBNOTMUCH_MINOR_VERSION 1
\r
115 > #define LIBNOTMUCH_MICRO_VERSION 0
\r
117 > +#define DEPRECATED(major,minor) \
\r
119 Is that perhaps a too generic name for a macro? NOTMUCH_DEPRECATED?
\r
121 Otherwise seems nice. Did not actually try it.
\r
126 > + __attribute__ ((deprecated ("function deprecated as of libnotmuch " #major "." #minor)))
\r
127 > #endif /* __DOXYGEN__ */
\r
133 > _______________________________________________
\r
134 > notmuch mailing list
\r
135 > notmuch@notmuchmail.org
\r
136 > http://notmuchmail.org/mailman/listinfo/notmuch
\r