Applying patches directly from emails?

[notmuch-archives.git] / 84 / 3cf43a1ab3d3a14ed0103b50e61e4b79bf2c92

Return-Path: <tomi.ollila@iki.fi>\r
X-Original-To: notmuch@notmuchmail.org\r
Delivered-To: notmuch@notmuchmail.org\r
Received: from localhost (localhost [127.0.0.1])\r
 by arlo.cworth.org (Postfix) with ESMTP id 1537E6DE01D0\r
 for <notmuch@notmuchmail.org>; Sun,  5 Jun 2016 03:43:49 -0700 (PDT)\r
X-Virus-Scanned: Debian amavisd-new at cworth.org\r
X-Spam-Flag: NO\r
X-Spam-Score: 0.578\r
X-Spam-Level: \r
X-Spam-Status: No, score=0.578 tagged_above=-999 required=5 tests=[AWL=-0.074,\r
  SPF_NEUTRAL=0.652] autolearn=disabled\r
Received: from arlo.cworth.org ([127.0.0.1])\r
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
 with ESMTP id GOBHb_aVrFjd for <notmuch@notmuchmail.org>;\r
 Sun,  5 Jun 2016 03:43:41 -0700 (PDT)\r
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
 by arlo.cworth.org (Postfix) with ESMTP id E6AFF6DE01F7\r
 for <notmuch@notmuchmail.org>; Sun,  5 Jun 2016 03:43:40 -0700 (PDT)\r
Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
 by guru.guru-group.fi (Postfix) with ESMTP id CBFB410019D;\r
 Sun,  5 Jun 2016 13:43:26 +0300 (EEST)\r
From: Tomi Ollila <tomi.ollila@iki.fi>\r
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
Subject: Re: [PATCH v3] emacs:  postpone/resume support\r
In-Reply-To: <1465001026-29392-1-git-send-email-markwalters1009@gmail.com>\r
References: <1465001026-29392-1-git-send-email-markwalters1009@gmail.com>\r
User-Agent: Notmuch/0.22+32~gd4854c5 (http://notmuchmail.org) Emacs/24.5.1\r
 (x86_64-unknown-linux-gnu)\r
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
 !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
Date: Sun, 05 Jun 2016 13:43:26 +0300\r
Message-ID: <m2y46jrk4x.fsf@guru.guru-group.fi>\r
MIME-Version: 1.0\r
Content-Type: text/plain\r
X-BeenThere: notmuch@notmuchmail.org\r
X-Mailman-Version: 2.1.20\r
Precedence: list\r
List-Id: "Use and development of the notmuch mail system."\r
 <notmuch.notmuchmail.org>\r
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
List-Post: <mailto:notmuch@notmuchmail.org>\r
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
X-List-Received-Date: Sun, 05 Jun 2016 10:43:49 -0000\r
\r
On Sat, Jun 04 2016, Mark Walters <markwalters1009@gmail.com> wrote:\r
\r
> This provides preliminary support for postponing and resuming in the\r
> emacs frontend. On postponing it uses notmuch insert to put the\r
> message in the notmuch database; resume gets the raw file from notmuch\r
> and using the emacs function mime-to-mml reconstructs the message\r
> (including attachments).\r
>\r
> Current bindings are C-x C-s to save a draft, C-c C-p to postpone a\r
\r
According to the discussion on IRC this feature seems like a thing\r
many people are enthusiastically eager to have...\r
\r
... but I am not -- I've been happy with the current draft handling\r
(yes, I had to set message-save-directory)...\r
\r
... but I think I am not biased when I think that if ctrl-x ctrl-s\r
does something more magical than simple (save-buffer) in buffers that\r
looks like text editing buffer, that is going to be unexpected disturbing\r
functionality to someone (else like me)...\r
\r
... I can easily add (and will do if this functionaly lands... :):\r
\r
(put 'notmuch-message-save-draft 'disabled t)\r
(define-key notmuch-message-mode-map (kbd "C-x C-s") #'save-buffer)\r
\r
to my $HOME/.emacs.d/notmuch-config.el\r
\r
(or actually my init-notmuch.el which is in my git-clonable dotfiles so it\r
goes automatically everywhere; notmuch-config.el is for system-local configs)\r
\r
but how are others protected?\r
\r
It might be that no-one else notices nor cares (or they can handle the\r
situation themselves). anyway, now if this lands and we get tons of\r
angry responses then I can say 'I said so' >;/\r
\r
Tomi\r
\r
PS: the brief look I had to the code I can say Mark has done pretty good\r
work with it.\r
\r
\r
> draft (save and exit compose buffer), and e to resume a draft from\r
> show or tree mode.\r
>\r
> Previous drafts get tagged deleted on subsequent saves, or on the\r
> message being sent.\r
>\r
> Each draft gets its own message-id, and we use the namespace\r
> draft-.... for draft message ids (so, at least for most people, drafts\r
> are easily distinguisable).\r
> ---\r
>\r
> Sorry to be rather spamming the list. This is another version of the\r
> postpone/resume series. This replaces the third patch in the series at\r
> id:1464976195-23134-1-git-send-email-markwalters1009@gmail.com (so\r
> should be applied on top of the first two).\r
>\r
> There are three main changes --\r
>\r
> 1) It seems that editing an already sent message does work -- as it is\r
> not heavily tested we warn before doing it. But now when you send the\r
> new version it does not tag the old version as deleted (we only tag\r
> drafts deleted).\r
>\r
> 2) We quote secure mml tags before saving. This avoids problems with\r
> signing the wrong message, stale signatures, and using the wrong keys\r
> for encryption. Note the draft message will be stored in the mail\r
> store unencrypted.\r
>\r
> 3) You can choose to quote more mml tags than just secure; there is a\r
> custom variable notmuch-message-quoted-tags under notmuch-send which\r
> should be a list of tags to quote. If you set it to '("secure" "part")\r
> then attachments won't be saved with the draft. This may be desired in\r
> some cases (but may break things like postponing rfc822 forwarded\r
> messages).  Anyway the option is there for anyone who wants to test!\r
>\r
> Best wishes\r
>\r
> Mark\r
>\r
>\r