1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1D635431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 7 Mar 2013 06:39:05 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id BtJJ2id0woBB for <notmuch@notmuchmail.org>;
\r
16 Thu, 7 Mar 2013 06:39:04 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 12F24431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 7 Mar 2013 06:39:04 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 1AA57100051;
\r
22 Thu, 7 Mar 2013 16:38:53 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
\r
25 notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new"
\r
27 parameter input only
\r
28 In-Reply-To: <87boavxr1u.fsf@zancas.localnet>
\r
29 References: <cover.1362347362.git.jani@nikula.org>
\r
30 <5faebfc5d36d7e85a4dd1acbca0417d8a6a2602d.1362347362.git.jani@nikula.org>
\r
31 <87boavxr1u.fsf@zancas.localnet>
\r
32 User-Agent: Notmuch/0.15.2+50~g43fdda5 (http://notmuchmail.org) Emacs/24.2.1
\r
33 (x86_64-unknown-linux-gnu)
\r
34 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
35 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
36 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
37 Date: Thu, 07 Mar 2013 16:38:52 +0200
\r
38 Message-ID: <m26213nukj.fsf@guru.guru-group.fi>
\r
40 Content-Type: text/plain
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Thu, 07 Mar 2013 14:39:05 -0000
\r
55 On Thu, Mar 07 2013, David Bremner <david@tethera.net> wrote:
\r
57 > Jani Nikula <jani@nikula.org> writes:
\r
59 >> We now have a notmuch_config_is_new() function to query whether a
\r
60 >> config was created or not. Change the notmuch_config_open() is_new
\r
61 >> parameter into boolean create_new to determine whether the function
\r
62 >> should create a new config if one doesn't exist. This reduces the
\r
63 >> complexity of the API.
\r
65 > I have pushed the first 4 patches in this series. I'd like a second
\r
66 > (third?) pair of eyes on 5/6.
\r
68 The changes in 5/6 (and 6/6 & manpage) LGTM. Using config for the context
\r
69 is good. The reply context of this mail has been produced by notmuch
\r
70 with these patches applied.
\r