1 Return-Path: <amdragon@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 96483431FD0
\r
6 for <notmuch@notmuchmail.org>; Thu, 12 May 2011 10:52:47 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id cwSEoWBxnMG3 for <notmuch@notmuchmail.org>;
\r
17 Thu, 12 May 2011 10:52:46 -0700 (PDT)
\r
18 Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com
\r
19 [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 875EE431FB6
\r
22 for <notmuch@notmuchmail.org>; Thu, 12 May 2011 10:52:46 -0700 (PDT)
\r
23 Received: by qyg14 with SMTP id 14so1177217qyg.5
\r
24 for <notmuch@notmuchmail.org>; Thu, 12 May 2011 10:52:45 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=domainkey-signature:mime-version:sender:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=dbHc1qUr+t/IfRy2WNGgnVOtXwQ1/FlpeqZV6d6Tf2Y=;
\r
30 b=c9Vk5fN4FiGYvgUWkf3lQvgQK+xGTgTRBETlXQwLWTWcXY4bUHVMVtpI+ny2YvsFi2
\r
31 ZKl9v8ythaMU+OoObahuv6tkwA3tfo5z9mp4I+6OHidW55R6dInJmqubfyabrIERUbTh
\r
32 u3ZyVZT2bhtvbPZTTArkY1UBKba62I8TBSxrs=
\r
33 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
\r
34 h=mime-version:sender:in-reply-to:references:date
\r
35 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
36 :content-transfer-encoding;
\r
37 b=j8VCEZNqXmv5YeNauF3WkhAyadWsxkS4YWfwFyoICMDIPf7S34SU3R08jfoOcU2+qo
\r
38 b0X0qW3bM3WgTHBO25QORXcQOAkCUa3p5zNgiCOIz5tze01DY6dh6pRHzXon+fqJBQKz
\r
39 Jae+8WTn0b0Irv2lWxga0BiOdF+CMoG56do60=
\r
41 Received: by 10.229.251.13 with SMTP id mq13mr463877qcb.36.1305222765560; Thu,
\r
42 12 May 2011 10:52:45 -0700 (PDT)
\r
43 Sender: amdragon@gmail.com
\r
44 Received: by 10.229.233.17 with HTTP; Thu, 12 May 2011 10:52:45 -0700 (PDT)
\r
45 In-Reply-To: <87zkms80zf.fsf@praet.org>
\r
46 References: <8762pn7gth.fsf@servo.factory.finestructure.net>
\r
47 <87iptkfzwx.fsf@servo.factory.finestructure.net>
\r
48 <877h9zokod.fsf@servo.factory.finestructure.net>
\r
49 <878vuencm5.fsf@servo.factory.finestructure.net>
\r
50 <878vuejym8.fsf@servo.factory.finestructure.net>
\r
51 <87wrhw2jmm.fsf@praet.org>
\r
52 <BANLkTi=iz6F+1-WQ5KDno6N-MF=dQeTbEA@mail.gmail.com>
\r
53 <87zkms80zf.fsf@praet.org>
\r
54 Date: Thu, 12 May 2011 13:52:45 -0400
\r
55 X-Google-Sender-Auth: __gYILAinbRgkO57-zWXei8Lf4s
\r
56 Message-ID: <BANLkTikT4AK0wo8j7AP7CT0yvD57+g2HzA@mail.gmail.com>
\r
57 Subject: Re: release-candidate/0.6
\r
58 From: Austin Clements <amdragon@mit.edu>
\r
59 To: Pieter Praet <pieter@praet.org>
\r
60 Content-Type: text/plain; charset=ISO-8859-1
\r
61 Content-Transfer-Encoding: quoted-printable
\r
62 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
63 X-BeenThere: notmuch@notmuchmail.org
\r
64 X-Mailman-Version: 2.1.13
\r
66 List-Id: "Use and development of the notmuch mail system."
\r
67 <notmuch.notmuchmail.org>
\r
68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
71 List-Post: <mailto:notmuch@notmuchmail.org>
\r
72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
74 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
75 X-List-Received-Date: Thu, 12 May 2011 17:52:47 -0000
\r
77 Nifty. I was afraid to go romping through all of the other test
\r
78 dependencies; I'm glad somebody wasn't. ]:--8)
\r
80 It should be noted that these patches depend on
\r
81 id:1305206110-17511-1-git-send-email-amdragon@mit.edu for correctness
\r
82 and id:1305206080-17461-1-git-send-email-amdragon@mit.edu for sanity.
\r
84 Given that these patches aren't specifically 0.6-related and that it's
\r
85 good practice to send patches to the list, perhaps you could git
\r
86 send-email these patches as a new thread to the list?
\r
88 On Thu, May 12, 2011 at 10:09 AM, Pieter Praet <pieter@praet.org> wrote:
\r
89 > On Thu, 12 May 2011 09:18:48 -0400, Austin Clements <amdragon@mit.edu> wr=
\r
91 >> On Thu, May 12, 2011 at 8:22 AM, Pieter Praet <pieter@praet.org> wrote:
\r
92 >> > The atomicity tests were failing here because I didn't have GDB
\r
93 >> > installed, so I've added it as a prereq.
\r
95 >> Sorry, I've had a patch to address that sitting around, but hadn't
\r
96 >> sent it out (and I only fixed that one test). =A0I would suggest a
\r
97 >> somewhat gentler approach than "error", though:
\r
99 >> if test_expect_success "prereq: gdb is present" "which gdb"; then
\r
100 >> =A0 =A0 test_set_prereq GDB
\r
103 >> (Plus the two test-lib patches I just sent:
\r
104 >> id:1305206080-17461-1-git-send-email-amdragon@mit.edu and
\r
105 >> id:1305206110-17511-1-git-send-email-amdragon@mit.edu).
\r
107 >> "error" has the disadvantage that it doesn't get counted as a failed
\r
108 >> test in the final tally (because, indeed, it's not a failed test) and
\r
109 >> also that it immediately terminates the test script so it's not
\r
110 >> actually using the prereq system (which is fine for the atomicity test
\r
111 >> since all of the test cases depend on GDB, but the pattern I'm
\r
112 >> proposing works for finer-grained prerequisites). =A0Plus, with the
\r
113 >> above approach, if you don't have a prerequisite, the final tally
\r
114 >> shows one failed test plus some number of skipped tests (and the total
\r
115 >> number of tests never changes), which I would argue is cleaner.
\r
117 > Much obliged for the correction!
\r
123 > [0] git://github.com/praet/notmuch.git
\r
124 > =A0 =A0for-review/test-prereqs-v2
\r
125 > =A0 =A0c9a785fc5c48db13
\r
129 > _______________________________________________
\r
130 > notmuch mailing list
\r
131 > notmuch@notmuchmail.org
\r
132 > http://notmuchmail.org/mailman/listinfo/notmuch
\r