81/7a1a2f399c13073989ed8b077ae1cd2d7e6189

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 6BEE1431FBC\r
   6         for <notmuch@notmuchmail.org>; Sat, 15 Dec 2012 11:45:55 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id j8XqHIcXZKZZ for <notmuch@notmuchmail.org>;\r
  16         Sat, 15 Dec 2012 11:45:54 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
  18         [18.7.68.36])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 7B391431FB6\r
  20         for <notmuch@notmuchmail.org>; Sat, 15 Dec 2012 11:45:54 -0800 (PST)\r
  21 X-AuditID: 12074424-b7fe06d0000008f0-a9-50ccd3705bcb\r
  22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  23         by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 55.B3.02288.073DCC05; Sat, 15 Dec 2012 14:45:53 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id qBFJjqOg011443; \r
  27         Sat, 15 Dec 2012 14:45:52 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qBFJjmEI022364\r
  32         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
  33         Sat, 15 Dec 2012 14:45:51 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1TjxgB-0003Du-VN; Sat, 15 Dec 2012 14:45:48 -0500\r
  37 From: Austin Clements <amdragon@MIT.EDU>\r
  38 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
  39 Subject: Re: [PATCH 1/7] emacs: Centralize notmuch command error handling\r
  40 In-Reply-To: <m2obhvp9rl.fsf@guru.guru-group.fi>\r
  41 References: <1355548513-10085-1-git-send-email-amdragon@mit.edu>\r
  42         <1355548513-10085-2-git-send-email-amdragon@mit.edu>\r
  43         <m2obhvp9rl.fsf@guru.guru-group.fi>\r
  44 User-Agent: Notmuch/0.14+184~gc26cc51 (http://notmuchmail.org) Emacs/23.4.1\r
  45         (i486-pc-linux-gnu)\r
  46 Date: Sat, 15 Dec 2012 14:45:47 -0500\r
  47 Message-ID: <877gojxfo4.fsf@awakening.csail.mit.edu>\r
  48 MIME-Version: 1.0\r
  49 Content-Type: text/plain; charset=us-ascii\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFnrEIsWRmVeSWpSXmKPExsUixG6nrlt4+UyAwaILjBbXb85ktnizch6r\r
  52         A5PH4a8LWTyerbrFHMAUxWWTkpqTWZZapG+XwJXRv+gnW8EpjopzDX+YGhhfsHUxcnJICJhI\r
  53         fDh7nAXCFpO4cG89UJyLQ0hgH6PE+Zt/WSCcDYwSd7Ysh8pcZJL4tbWdHcJZwihxe9ZqRpB+\r
  54         NgENiW37l4PZIgK2EleWnGQFsYUFPCV6Ti4Ei3MKGEh0fbgANWkmo8THqTeBJnFwiArES5xd\r
  55         agJSwyKgKrFx5QSwm3iB7pvzfTcThC0ocXLmE7A4s4CWxI1/L5kmMArMQpKahSS1gJFpFaNs\r
  56         Sm6Vbm5iZk5xarJucXJiXl5qka65Xm5miV5qSukmRnBQuqjsYGw+pHSIUYCDUYmHd0fE6QAh\r
  57         1sSy4srcQ4ySHExKorwV584ECPEl5adUZiQWZ8QXleakFh9ilOBgVhLhTZoPlONNSaysSi3K\r
  58         h0lJc7AoifNeT7npLySQnliSmp2aWpBaBJOV4eBQkuCddQmoUbAoNT21Ii0zpwQhzcTBCTKc\r
  59         B2h4P0gNb3FBYm5xZjpE/hSjopQ471SQhABIIqM0D64XljReMYoDvSLMWwdSxQNMOHDdr4AG\r
  60         MwENXm4DNrgkESEl1cDY7OXg/l391Kq3c9q/5zw9n832+MINm8hN/cd7b4h3bLSNnl/jpX/F\r
  61         srmzNUuT7RtrSfj2y98eW/yfdXX1q5wQvhbXN75MFlE7HZ5e3WVR93uba3+SC+eB1/usjxX8\r
  62         36/8p/Q4k3T6dtv6ZayaTiwTeyQurbSIUbD/feDAEQej1UuNrJZmpi9WYinOSDTUYi4qTgQA\r
  63         gTBFivUCAAA=\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Sat, 15 Dec 2012 19:45:55 -0000\r
  77 \r
  78 On Sat, 15 Dec 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
  79 > On Sat, Dec 15 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
  80 >\r
  81 >> This provides library functions for unified handling of errors from\r
  82 >> the notmuch CLI.  Follow-up patches will convert some scattered error\r
  83 >> handling to use this and add error handling where we currently ignore\r
  84 >> errors.\r
  85 >> ---\r
  86 >\r
  87 > The series looks pretty good, some hardcoded patchs Mark noticed\r
  88 > and it looks to me (after viewing id:8738z7hd6x.fsf@qmul.ac.uk\r
  89 > that err -> nil could be done.\r
  90 \r
  91 Fixed.\r
  92 \r
  93 > Would (goto-char (point-min)) be needed before (insert msg) in\r
  94 > this patch -- what If user has moved cursor while viewing old\r
  95 > error messages but not pressed q (dismissed) on the buffer. \r
  96 \r
  97 Good idea.  Actually, I had intended to *append* the error to the buffer\r
  98 so it would be in chronological order.  I tweaked things a bit so\r
  99 messages should always be appended and point will be left at the end of\r
 100 the error log.\r
 101 \r
 102 > Also, what about (unless (eobp) (insert "\n")) to add empty\r
 103 > line between error messages ?\r
 104 \r
 105 Done.\r
 106 \r
 107 > Tomi\r