1 Return-Path: <ethan.glasser.camp@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 85728431FAF
\r
6 for <notmuch@notmuchmail.org>; Tue, 23 Oct 2012 18:37:00 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 6e6t--ZmSLPA for <notmuch@notmuchmail.org>;
\r
17 Tue, 23 Oct 2012 18:36:59 -0700 (PDT)
\r
18 Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com
\r
19 [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 33F1D431FAE
\r
22 for <notmuch@notmuchmail.org>; Tue, 23 Oct 2012 18:36:59 -0700 (PDT)
\r
23 Received: by mail-vb0-f53.google.com with SMTP id fc21so5028vbb.26
\r
24 for <notmuch@notmuchmail.org>; Tue, 23 Oct 2012 18:36:57 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=i6shZUBWKoWPxYBb7CsVdQ9BSxSeTWY69sMo2G3cv9g=;
\r
29 b=aeoLJzYfk2X6PC8XhbBVen7hH8ApCP5AG2fUv5SRvMWoHmUbtUR5C/UPrnDJ16Vkir
\r
30 cAXfg9ZUHWpifga2VO1jmq7tuxH/BsImSyfr+5a6xJVjppacXVC2RRlX+mmrN10TJ+Jz
\r
31 m6TbFyh6aWbJxN2ueVVPtnfquaJkUjqgDXJxD/RQu5LqHzpsp4oe1O9XUCGx/vjhVynp
\r
32 6EzKbhNJH8MvRSalcAdL5SPeEYvilQxrfMWn4kAxg41o/OgsogPvedCsTigld5RZm5g0
\r
33 dNY3gkSKkMWkURBzgQB1bW8dBozAA8k9guvqSG0gWXYBzeWF+3v1VyHjZgI3WXKriIhW
\r
35 Received: by 10.58.137.229 with SMTP id ql5mr26724968veb.11.1351042617357;
\r
36 Tue, 23 Oct 2012 18:36:57 -0700 (PDT)
\r
37 Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])
\r
38 by mx.google.com with ESMTPS id q7sm7615899vdw.22.2012.10.23.18.36.55
\r
39 (version=TLSv1/SSLv3 cipher=OTHER);
\r
40 Tue, 23 Oct 2012 18:36:56 -0700 (PDT)
\r
41 From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
42 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
43 Subject: Re: [PATCH v3 2/3] emacs: Rename incremental JSON internal variables.
\r
44 In-Reply-To: <1351037602-11157-3-git-send-email-markwalters1009@gmail.com>
\r
45 References: <1351037602-11157-1-git-send-email-markwalters1009@gmail.com>
\r
46 <1351037602-11157-3-git-send-email-markwalters1009@gmail.com>
\r
47 User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Tue, 23 Oct 2012 21:36:52 -0400
\r
50 Message-ID: <876260k5vv.fsf@betacantrips.com>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Wed, 24 Oct 2012 01:37:00 -0000
\r
67 Mark Walters <markwalters1009@gmail.com> writes:
\r
69 > This patch just renames the internal variables for the JSON parser now
\r
70 > it is no longer specific to search mode. It also fixes up the white
\r
71 > space after the previous patch. There should be no functional changes.
\r
73 This series looks very good to me. I still have a couple of quibbles that I wouldn't say
\r
74 should hold the series up. First, your commit messages have periods at
\r
75 the end of the first line. I think it is considered good practice that
\r
76 they not (see, e.g.,
\r
77 http://blogs.gnome.org/danni/2011/10/25/a-guide-to-writing-git-commit-messages/ ).
\r
79 > -(defvar notmuch-search-process-state nil
\r
80 > - "Parsing state of the search process filter.")
\r
81 > +(defvar notmuch-json-state nil
\r
82 > + "State of the internal JSON parser.")
\r
86 "State of the shared JSON parser.
\r
88 This variable will be a symbol, corresponding to the state of the JSON
\r
89 parser's state machine. 'begin means we haven't yet entered a JSON
\r
90 list. 'result means we are ready to parse a JSON object. 'end means we
\r
91 have exited the JSON list."
\r
93 (Or whatever the correct meanings of the parser's states are...)
\r
95 > -(defvar notmuch-search-json-parser nil
\r
96 > - "Incremental JSON parser for the search process filter.")
\r
97 > +(defvar notmuch-json-parser nil
\r
98 > + "Internal Incremental JSON parser Object.")
\r
102 "Shared notmuch JSON parser object, as created by
\r
103 (notmuch-json-create-parser).
\r
105 Any notmuch code can parse part of a JSON list object by setting this
\r
106 variable to their JSON parser and calling
\r
107 notmuch-json-parse-partial-list (which see)."
\r
109 (Or whatever one is supposed to do with the parser object...)
\r