7f/e51f418e33919177cc6dabeae632e8299701d5

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 1A430431FB6\r
   6         for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:02:44 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id EBpeoO-mrm9j for <notmuch@notmuchmail.org>;\r
  16         Thu, 12 Jan 2012 09:02:43 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
  18         [18.7.68.36])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 8D90E429E25\r
  20         for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:02:43 -0800 (PST)\r
  21 X-AuditID: 12074424-b7fae6d000000906-2c-4f0f12334462\r
  22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  23         by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 2C.61.02310.3321F0F4; Thu, 12 Jan 2012 12:02:43 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q0CH2g6t006832; \r
  27         Thu, 12 Jan 2012 12:02:42 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0CH2fOl003278\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Thu, 12 Jan 2012 12:02:41 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1RlO32-0006CN-JG; Thu, 12 Jan 2012 12:02:44 -0500\r
  37 Date: Thu, 12 Jan 2012 12:02:44 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Tomi Ollila <tomi.ollila@iki.fi>\r
  40 Subject: Re: [PATCH] make (kill-emacs) from emacsclient work with emacs\r
  41         23.(1|2)\r
  42 Message-ID: <20120112170244.GB18625@mit.edu>\r
  43 References: <87d3b01qus.fsf@qmul.ac.uk>\r
  44         <1326293378-25248-1-git-send-email-tomi.ollila@iki.fi>\r
  45         <20120112041344.GZ20796@mit.edu> <yf6boq9482p.fsf@taco2.nixu.fi>\r
  46 MIME-Version: 1.0\r
  47 Content-Type: text/plain; charset=us-ascii\r
  48 Content-Disposition: inline\r
  49 In-Reply-To: <yf6boq9482p.fsf@taco2.nixu.fi>\r
  50 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  51 X-Brightmail-Tracker:\r
  52  H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IRYrdT1zUW4vc3mLSZ3eL6zZnMFm9WzmN1\r
  53         YPI4/HUhi8ezVbeYA5iiuGxSUnMyy1KL9O0SuDIaFq9hLXjEVXH0xVXGBsZTHF2MnBwSAiYS\r
  54         nQtesEHYYhIX7q0Hsrk4hAT2MUq8eNUPlhAS2MAo0bS+BiJxkkmifdU8qMQSRonNz+VBbBYB\r
  55         VYmt3S9YQGw2AQ2JbfuXM4LYIgIqEg/a1rOC2MwC0hLffjczgdjCAkEST25fB6vnFdCROLnv\r
  56         CiPEzKWMEv0fNCDighInZz5hgejVkrjx7yVQLwfYnOX/wB7gBGr90L+WHcQWBVo15eQ2tgmM\r
  57         QrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXXO93MwSvdSU0k2M4KB2UdnB\r
  58         2HxI6RCjAAejEg/vjr28/kKsiWXFlbmHGCU5mJREea34+P2F+JLyUyozEosz4otKc1KLDzFK\r
  59         cDArifBOPs/nL8SbklhZlVqUD5OS5mBREufV0HrnJySQnliSmp2aWpBaBJOV4eBQkuBtFwQa\r
  60         KliUmp5akZaZU4KQZuLgBBnOAzT8qABQDW9xQWJucWY6RP4Uoy7HybVXzjEKseTl56VKifPG\r
  61         gQwSACnKKM2DmwNLRq8YxYHeEuZ1B6niASYyuEmvgJYwAS0pSwH5oLgkESEl1cCYuuvxm305\r
  62         pubBJl79wgLv934+0NWiNOPi2W6mF3z3Sg97HlFbJ6rPK6siftJp35HPr6bW3/KSW7n5wrf+\r
  63         K4ZnteJXtQhP7kpSu6Z8YgdH8kc/+SVnPMt83BMYTQy4GQIfFXyeHLH8WJ9rWatcsGgGf1aM\r
  64         kN28ov2Gx38yZuX9r5MweS92PkGJpTgj0VCLuag4EQBb4jycIQMAAA==\r
  65 Cc: notmuch@notmuchmail.org\r
  66 X-BeenThere: notmuch@notmuchmail.org\r
  67 X-Mailman-Version: 2.1.13\r
  68 Precedence: list\r
  69 List-Id: "Use and development of the notmuch mail system."\r
  70         <notmuch.notmuchmail.org>\r
  71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  72         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  74 List-Post: <mailto:notmuch@notmuchmail.org>\r
  75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  77         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  78 X-List-Received-Date: Thu, 12 Jan 2012 17:02:44 -0000\r
  79 \r
  80 Quoth Tomi Ollila on Jan 12 at 10:51 am:\r
  81 > On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements <amdragon@mit.edu> wrote:\r
  82 > > This is important to fix, but this solution seems needlessly\r
  83 > > roundabout.  What about using an after-advice and simply delq'ing\r
  84 > > whatever the offending hook is?  That wouldn't even need a version\r
  85 > > check.\r
  86 > \r
  87 > delq could work -- thanks for the idea -- but removing the hook was\r
  88 > wrong shot from my part (the hook removes the cleanup I mentioned in\r
  89 > one of my previous mails).\r
  90 \r
  91 Ah, interesting.\r
  92 \r
  93 > To minimise behaviour changes (to zero in emacs 23.3+) to minimal\r
  94 > in 23.(1|2) my next suggestion goes along lines:\r
  95 > \r
  96 > ;; Work around a bug in emacs 23.1 and emacs 23.2 which prevents\r
  97 > ;; noninteractive (kill-emacs) from emacsclient.\r
  98 > (when (and (= emacs-major-version 23) (< emacs-minor-version 3))\r
  99 >   (defadvice kill-emacs (before disable-yes-or-no-p)\r
 100 >     "Disable yes-or-no-p before executing kill-emacs"\r
 101 >     (defun yes-or-no-p (prompt) t))\r
 102 >   (ad-activate 'kill-emacs))\r
 103 \r
 104 This seems reasonable.  You could shorten it a bit by changing\r
 105   (before disable-yes-or-no-p)\r
 106 to\r
 107   (before disable-yes-or-no-p activate)\r
 108 rather than calling ad-activate, but that's just a nit.\r
 109 \r
 110 > Now just (accidental) additions which use yes-or-no-p \r
 111 > into kill-emacs-hook are not noticed in emacs 23.1 & 23.2.\r
 112 > \r
 113 > \r
 114 > Tomi\r