1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DB51C431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 27 May 2013 15:30:50 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id KR0pil+fFfTq for <notmuch@notmuchmail.org>;
\r
17 Mon, 27 May 2013 15:30:45 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id A35B1431FAE
\r
22 for <notmuch@notmuchmail.org>; Mon, 27 May 2013 15:30:45 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1Uh5w7-0005Mc-5b; Mon, 27 May 2013 23:30:44 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1Uh5w6-0000DD-Si; Mon, 27 May 2013 23:30:39 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 0/4] emacs: Part command improvements
\r
34 In-Reply-To: <1369687594-31774-1-git-send-email-amdragon@mit.edu>
\r
35 References: <1369687594-31774-1-git-send-email-amdragon@mit.edu>
\r
36 User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1
\r
38 Date: Mon, 27 May 2013 23:30:37 +0100
\r
39 Message-ID: <87zjvghx82.fsf@qmul.ac.uk>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-Sender-Host-Address: 93.97.24.31
\r
43 X-QM-SPAM-Info: Sender has good ham record. :)
\r
44 X-QM-Body-MD5: 45b9b14c3ff81e8ea343cc6b3369bac8 (of first 20000 bytes)
\r
45 X-SpamAssassin-Score: -0.1
\r
46 X-SpamAssassin-SpamBar: /
\r
47 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
49 spam. We require at least 5.0 points to mark a message as spam.
\r
50 This message scored -0.1 points.
\r
51 Summary of the scoring:
\r
52 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
53 provider * (markwalters1009[at]gmail.com)
\r
54 * -0.1 AWL AWL: From: address is in the auto white-list
\r
55 X-QM-Scan-Virus: ClamAV says the message is clean
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Mon, 27 May 2013 22:30:51 -0000
\r
70 Austin Clements <amdragon@MIT.EDU> writes:
\r
72 > This is a follow-up of sorts to id:"8761ycc19t.fsf@qmul.ac.uk", where
\r
73 > Mark suggested that the part handling commands could all use the
\r
74 > correponding mm-* functions. I ran with the idea and wound up with
\r
75 > this series, which, in addition to standardizing on the mm-* functions
\r
76 > for everything and simplifying the implementation overall, decouples
\r
77 > the part commands from part buttons, which removes an entire layer
\r
78 > from the implementation and adds the ability to invoke part commands
\r
79 > with point anywhere in a part (something I often find myself wanting).
\r
81 Overall I really like this series. In addition to the clean up etc it
\r
82 makes it easy to export the text/plain part (which doesn't have a part
\r
83 button). I have recollection of this being difficult if it is base64
\r
86 I have a few small comments
\r
88 As mentioned on irc (just included here in case other people are
\r
89 testing) make-composed-keymap is emacs 24 only.
\r
91 This does change the default directory for saving: not serious but it's
\r
92 probably worth deciding do we want to use mailcap-download-directory or
\r
93 home or where emacs was started or?
\r
95 I don't know if we want to keep a special keymap for the button or just
\r
96 always use the . prefix; the advantage is that you don't have 's' on a
\r
97 button acting differently from 's' in the text (which has annoyed me
\r
98 several times) otoh it is the extra keystroke which may annoy people
\r
99 too. Let the bikeshedding begin! (obviously return for the default
\r
100 action would remain.
\r
102 Would it be worth having . return in the part body as the default
\r
105 Finally, with message indenting it's the start/end of the part are a
\r
106 little unclear. I think it's the [ of the part button at the start of
\r
107 the part to the character before the [ of the next part button. In
\r
108 particular on the line of a new part but before the button is still the
\r
109 old part. Since parts are whole lines it would be nice if the region
\r
110 were line based but I don't know if that is easy.
\r
projects / notmuch-archives.git / blob