1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1DE69431FD6
\r
6 for <notmuch@notmuchmail.org>; Thu, 4 Jul 2013 00:38:48 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id cPPgODNus2mM for <notmuch@notmuchmail.org>;
\r
16 Thu, 4 Jul 2013 00:38:39 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id BB25F431FBF
\r
19 for <notmuch@notmuchmail.org>; Thu, 4 Jul 2013 00:38:39 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id A737B100051;
\r
22 Thu, 4 Jul 2013 10:38:33 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] contrib: pick: use notmuch-start-notmuch
\r
26 In-Reply-To: <1372921788-16042-1-git-send-email-markwalters1009@gmail.com>
\r
27 References: <1372921788-16042-1-git-send-email-markwalters1009@gmail.com>
\r
28 User-Agent: Notmuch/0.15.2+193~g7350bd4 (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Thu, 04 Jul 2013 10:38:33 +0300
\r
34 Message-ID: <m2zju2lqpy.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Thu, 04 Jul 2013 07:38:48 -0000
\r
51 On Thu, Jul 04 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
53 > This uses the new notmuch-start-notmuch function which should give
\r
54 > better handling of stderr and errors generally.
\r
59 > This converts pick to Austin's new async error handling code (see
\r
60 > commit 08fde50bf3a4c54f6413aff4052e0d84392463f9). That code separates
\r
61 > stderr from stdout and makes sure that appropriate messages are
\r
62 > displayed to the user.
\r
64 > I think this is simple enough and beneficial enough to go in for 0.16
\r
65 > (so I will tag it 0.16). Of course it only affects notmuch-pick so
\r
66 > is relatively safe.
\r
68 FWIW the code LGTM. Do the pick tests use this and do those pass ?
\r
78 > contrib/notmuch-pick/notmuch-pick.el | 7 +++----
\r
79 > 1 files changed, 3 insertions(+), 4 deletions(-)
\r
81 > diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
\r
82 > index fbd7c0b..7f5f729 100644
\r
83 > --- a/contrib/notmuch-pick/notmuch-pick.el
\r
84 > +++ b/contrib/notmuch-pick/notmuch-pick.el
\r
85 > @@ -817,16 +817,15 @@ Complete list of currently available key bindings:
\r
86 > (if (equal (car (process-lines notmuch-command "count" search-args)) "0")
\r
87 > (setq search-args basic-query))
\r
88 > (if notmuch-pick-asynchronous-parser
\r
89 > - (let ((proc (start-process
\r
90 > - "notmuch-pick" buffer
\r
91 > - notmuch-command "show" "--body=false" "--format=sexp"
\r
92 > + (let ((proc (notmuch-start-notmuch
\r
93 > + "notmuch-pick" buffer #'notmuch-pick-process-sentinel
\r
94 > + "show" "--body=false" "--format=sexp"
\r
95 > message-arg search-args))
\r
96 > ;; Use a scratch buffer to accumulate partial output.
\r
97 > ;; This buffer will be killed by the sentinel, which
\r
98 > ;; should be called no matter how the process dies.
\r
99 > (parse-buf (generate-new-buffer " *notmuch pick parse*")))
\r
100 > (process-put proc 'parse-buf parse-buf)
\r
101 > - (set-process-sentinel proc 'notmuch-pick-process-sentinel)
\r
102 > (set-process-filter proc 'notmuch-pick-process-filter)
\r
103 > (set-process-query-on-exit-flag proc nil))
\r
108 > _______________________________________________
\r
109 > notmuch mailing list
\r
110 > notmuch@notmuchmail.org
\r
111 > http://notmuchmail.org/mailman/listinfo/notmuch
\r