1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0F83E431FB6
\r
6 for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 13:18:13 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id lpKb6JWMZJB3 for <notmuch@notmuchmail.org>;
\r
16 Fri, 24 Jan 2014 13:18:04 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 2A2E1431FC0
\r
20 for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 13:18:04 -0800 (PST)
\r
21 X-AuditID: 12074422-f79526d000000c47-ed-52e2d88b1ddf
\r
22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])
\r
23 (using TLS with cipher AES256-SHA (256/256 bits))
\r
24 (Client did not present a certificate)
\r
25 by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP
\r
26 id 99.0F.03143.B88D2E25; Fri, 24 Jan 2014 16:18:03 -0500 (EST)
\r
27 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
\r
28 by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id s0OLI2eT026233;
\r
29 Fri, 24 Jan 2014 16:18:03 -0500
\r
30 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
31 (authenticated bits=0)
\r
32 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
33 by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s0OLHx5F020179
\r
34 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
35 Fri, 24 Jan 2014 16:18:01 -0500
\r
36 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
37 (envelope-from <amdragon@mit.edu>)
\r
38 id 1W6o8V-0006Dc-9F; Fri, 24 Jan 2014 16:17:59 -0500
\r
39 From: Austin Clements <aclements@csail.mit.edu>
\r
40 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH 0/5] lib: make folder: prefix literal
\r
42 In-Reply-To: <cover.1389304779.git.jani@nikula.org>
\r
43 References: <cover.1389304779.git.jani@nikula.org>
\r
44 User-Agent: Notmuch/0.17~rc2+14~g06f47e0 (http://notmuchmail.org) Emacs/23.4.1
\r
46 Date: Fri, 24 Jan 2014 16:17:58 -0500
\r
47 Message-ID: <87y525m649.fsf@awakening.csail.mit.edu>
\r
49 Content-Type: text/plain; charset=us-ascii
\r
50 X-Brightmail-Tracker:
\r
51 H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsUixCmqrdt941GQwbz9yhZN050trt+cyezA
\r
52 5HHr/mt2j2erbjEHMEVx2aSk5mSWpRbp2yVwZbT17mEuuCxZMXmCSwPjMeEuRk4OCQETif4n
\r
53 D1ghbDGJC/fWs3UxcnEICcxmkjj7awMLhLORUaJt3i1GCOc0k8Sk+bOhMksYJXafbAXrZxPQ
\r
54 l1ixdhKYLSJgJXHu4WsWEFtYwFJi6p0pTCA2p4CxxJ7dixhBbCEBI4nTd9rZQGxRgSSJ01N/
\r
55 A/VycLAIqEpcm1oCEuYFOu9f50IWCFtQ4uTMJ2A2s4CWxI1/L5kmMArMQpKahSS1gJFpFaNs
\r
56 Sm6Vbm5iZk5xarJucXJiXl5qka6pXm5miV5qSukmRlA4srso7WD8eVDpEKMAB6MSD++MwIdB
\r
57 QqyJZcWVuYcYJTmYlER5p15+FCTEl5SfUpmRWJwRX1Sak1p8iFGCg1lJhHfuZqAcb0piZVVq
\r
58 UT5MSpqDRUmc9xaHfZCQQHpiSWp2ampBahFMVoaDQ0mCV/86UKNgUWp6akVaZk4JQpqJgxNk
\r
59 OA/QcBeQGt7igsTc4sx0iPwpRkUpcd4F14ASAiCJjNI8uF5YunjFKA70ijCvIUg7DzDVwHW/
\r
60 AhrMBDR4xdkHIINLEhFSUg2M868w2IXwvk507MlY2XY2d0/NjFfBvPY2t1NOex+q2rzx1rVK
\r
61 0UMLVBjaI/Vu3/3dernow9f/CcUM6vwHpq+4JK14Uzx53bc72gFvnwrL3eX0z9/vVM+gkG32
\r
62 0XPLt8eRzVvFNy3Yu2py0NkDxhF9H7b9ujND9a/fxdZA5QtL7CcGhvb2mj4+rMRSnJFoqMVc
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Fri, 24 Jan 2014 21:18:13 -0000
\r
78 On Thu, 09 Jan 2014, Jani Nikula <jani@nikula.org> wrote:
\r
79 > Hi all, this series makes the folder: search prefix literal, or switches
\r
80 > it from a probabilistic prefix to a boolean prefix. With this, you have
\r
81 > to give the path from the maildir root to the folder you want in full,
\r
82 > including the maildir cur/new component, if any. Examples:
\r
84 I strongly disagree with requiring the cur/new component. The cur/new
\r
85 directory is an internal implementation detail of Maildir (and a rather
\r
86 broken one at that) and no more a part of the "folder" of a piece of
\r
87 mail than its final file name component. It's also the less obvious
\r
88 user interface; if we require the cur/new component, we *will* get
\r
89 people asking why their folder searches aren't working, but if we strip
\r
90 the cur/new component, nobody will be surprised.
\r
92 I think the question is not whether we should strip cur/new, but when.
\r
93 We've already defined a "_filename_is_in_maildir" test in
\r
94 lib/message.cc, which we depend on for flag sync. It's simple, but I
\r
95 think this would be the right thing to use for consistency.
\r
101 > The last one can be used to refer to the maildir root (note that in
\r
102 > shell you'll need quoting to pass the double quotes to xapian,
\r
105 > The old probabilistic folder: prefix is problematic in a number of
\r
106 > ways. It's not possible to refer to the maildir root. It does stemming,
\r
107 > so "inboxing" would match "inbox" too. "cur" for the folder in maildir
\r
108 > root would match all "cur" folders across the maildir hierarchy. Likely
\r
109 > some others I forgot.
\r
111 > WARNING! The change requires a database format version bump, and a
\r
112 > database upgrade, which is automatically done on 'notmuch new'. The
\r
113 > upgrade is irreversible if you want to try this on your database! A
\r
114 > complete database rebuild is required for reverting the database format
\r
115 > version. Make sure your backups are in order!
\r
117 > The series includes some tests, including an initial upgrade test, along
\r
118 > with a test database in the previous format version.
\r
127 > lib: make folder: prefix literal
\r
128 > test: fix insert folder: searches
\r
129 > test: fix test for literal folder: search
\r
130 > test: add test database in format version 1
\r
131 > test: add database upgrade test from format version 1
\r
133 > lib/database.cc | 39 ++++++++-
\r
134 > lib/message.cc | 154 +++++++++++++++++----------------
\r
135 > lib/notmuch-private.h | 3 +
\r
136 > test/insert | 10 +--
\r
137 > test/notmuch-test | 1 +
\r
138 > test/search-by-folder | 24 ++++-
\r
139 > test/test-databases/README | 5 ++
\r
140 > test/test-databases/database-v1.tar.gz | Bin 0 -> 252243 bytes
\r
141 > test/upgrade | 25 ++++++
\r
142 > 9 files changed, 174 insertions(+), 87 deletions(-)
\r
143 > create mode 100644 test/test-databases/README
\r
144 > create mode 100644 test/test-databases/database-v1.tar.gz
\r
145 > create mode 100755 test/upgrade
\r
150 > _______________________________________________
\r
151 > notmuch mailing list
\r
152 > notmuch@notmuchmail.org
\r
153 > http://notmuchmail.org/mailman/listinfo/notmuch
\r