1 Return-Path: <bijan.chokoufe@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 8AE4D6DE02AF
\r
6 for <notmuch@notmuchmail.org>; Mon, 13 Jun 2016 08:18:21 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.82 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01,
\r
14 RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled
\r
15 Received: from arlo.cworth.org ([127.0.0.1])
\r
16 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id qEB3HXpeO9VE for <notmuch@notmuchmail.org>;
\r
18 Mon, 13 Jun 2016 08:18:12 -0700 (PDT)
\r
19 Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com
\r
20 [74.125.82.66]) by arlo.cworth.org (Postfix) with ESMTPS id E7FBE6DE0008 for
\r
21 <notmuch@notmuchmail.org>; Mon, 13 Jun 2016 08:18:11 -0700 (PDT)
\r
22 Received: by mail-wm0-f66.google.com with SMTP id m124so15647052wme.3
\r
23 for <notmuch@notmuchmail.org>; Mon, 13 Jun 2016 08:18:11 -0700 (PDT)
\r
24 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
25 h=date:from:to:cc:subject:message-id:references:mime-version
\r
26 :content-disposition:content-transfer-encoding:in-reply-to
\r
27 :user-agent; bh=xRQcGOY090lr0oz1lJApX9l5BQX2YIFoUOqK2Ffw1pA=;
\r
28 b=uZwWXnHZiEe9tiNPqbE0hpbImqInnAaAnaxshhulsoplA8UduveKU3MMTFiLEnyxgw
\r
29 s5v4iWA4ES55XRCWWLtZCQgEavTZtyd1Fnq8dyp+xV1pnps1GWfT49s/Jf7TQyyR1wZU
\r
30 bvKPQ9d291uJi8BJaxC06RgP4rCm5ukwXIQvj8VfIiJgOiwrzbjXMetsuTYL4u5fLPyC
\r
31 Xm7jM2o9RDr3i3LK/gAW7NJNzyujMr4W6ZM1C4GjLzr0r19xED/e3AyTkLQxDwflY82B
\r
32 J8u5wHOqElkuzHKhD7jFO0gIvszbIBc9F9P1virA+uDqtG5SrfbXij4dELyG+5s4stGb
\r
34 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
35 d=1e100.net; s=20130820;
\r
36 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
\r
37 :mime-version:content-disposition:content-transfer-encoding
\r
38 :in-reply-to:user-agent;
\r
39 bh=xRQcGOY090lr0oz1lJApX9l5BQX2YIFoUOqK2Ffw1pA=;
\r
40 b=VtGyc6nnlcXKvRQoNiK6x4TMI0DODO8IS6K0ruReH+ODXkjkr/v/fytJ2+02onaJuU
\r
41 FsCB+8HyyiUhhX0gqsusFIogWJxgI66j6RHfti3z6HaXee62RPelqjYUfTOiN3x3r1eo
\r
42 LXVQNsrBb6VUV+U+COacvN5/xUZfta9J0X3Q4nmPoe+3t259fqEXo1emIyM/33LVKUGD
\r
43 vqIdPypa8RBuuWBMbe1PCiEDVxMCjD6yz0LGMd0EwtseBCCoDpYsDpD6B15j6i+6ykhZ
\r
44 oj/RAjOwG8uOw5PFViFfTyBUG5sJ9AGaUMneqyVhmKsTcHrpU/TBpTOIFmXLdDpbpUyw
\r
47 ALyK8tJ7LMVerG+nH2s6vNxhX7wPQj9x6rxM4CLtzfHeuBv2u9rHD9vOIb9CMJdhFSpJTw==
\r
48 X-Received: by 10.28.48.15 with SMTP id w15mr156639wmw.28.1465831090024;
\r
49 Mon, 13 Jun 2016 08:18:10 -0700 (PDT)
\r
50 Received: from localhost ([2001:638:700:e000:0:1:0:61a])
\r
51 by smtp.gmail.com with ESMTPSA id w76sm13061200wmd.11.2016.06.13.08.18.08
\r
52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
53 Mon, 13 Jun 2016 08:18:08 -0700 (PDT)
\r
54 Date: Mon, 13 Jun 2016 17:18:07 +0200
\r
55 From: Bijan Chokoufe Nejad <bijan.chokoufe@gmail.com>
\r
56 To: David Bremner <david@tethera.net>
\r
57 Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
58 Subject: Re: [PATCH 2/8] lib: private string map (associative array) API
\r
59 Message-ID: <20160613151807.GA2109@bijan-TPX1Yoga>
\r
60 References: <1465779955-5539-1-git-send-email-david@tethera.net>
\r
61 <1465779955-5539-3-git-send-email-david@tethera.net>
\r
62 <m2oa755x11.fsf@guru.guru-group.fi>
\r
63 <871t41utqi.fsf@zancas.localnet>
\r
65 Content-Type: text/plain; charset=utf-8
\r
66 Content-Disposition: inline
\r
67 Content-Transfer-Encoding: 8bit
\r
68 In-Reply-To: <871t41utqi.fsf@zancas.localnet>
\r
69 User-Agent: Mutt/1.5.24 (2015-08-30)
\r
70 X-BeenThere: notmuch@notmuchmail.org
\r
71 X-Mailman-Version: 2.1.20
\r
73 List-Id: "Use and development of the notmuch mail system."
\r
74 <notmuch.notmuchmail.org>
\r
75 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
77 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
78 List-Post: <mailto:notmuch@notmuchmail.org>
\r
79 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
80 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
81 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
82 X-List-Received-Date: Mon, 13 Jun 2016 15:18:21 -0000
\r
84 On 16-06-13, David Bremner wrote:
\r
85 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
87 > > On Mon, Jun 13 2016, David Bremner <david@tethera.net> wrote:
\r
89 > >> The choice of array implementation is deliberate, for future iterator support
\r
91 > >> lib/Makefile.local | 1 +
\r
92 > >> lib/notmuch-private.h | 11 ++++
\r
93 > >> lib/string-map.c | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++
\r
94 > >> 3 files changed, 165 insertions(+)
\r
95 > >> create mode 100644 lib/string-map.c
\r
97 > >> diff --git a/lib/Makefile.local b/lib/Makefile.local
\r
98 > >> index beb9635..9280880 100644
\r
99 > >> --- a/lib/Makefile.local
\r
100 > >> +++ b/lib/Makefile.local
\r
101 > >> @@ -40,6 +40,7 @@ libnotmuch_c_srcs = \
\r
102 > >> $(dir)/messages.c \
\r
103 > >> $(dir)/sha1.c \
\r
104 > >> $(dir)/built-with.c \
\r
105 > >> + $(dir)/string-map.c \
\r
108 > > I suggest everyone to install editor which supports showing tabs & spaces
\r
109 > > e.g. in different color and also visualizes trailing whitespace & trailing
\r
113 > Heh. If only such a thing existed. What about a pre-commit hook?
\r
114 > The default (that I have) uses git diff --index --check --cached, but
\r
115 > that seems not to be enough.
\r
118 > _______________________________________________
\r
120 I know you guys are more in the emacs camp but just for reference/inspiration:
\r
121 in VIM I have a mapping to strip trailing spaces from a file
\r
123 noremap <leader>st :%s/\s\+$/<CR>
\r
125 This could of course go as a sed/grep command in the pre-commit hook. Concerning
\r
128 " Tabs. Note: Use :retab to clean up mixed indentation
\r
129 set expandtab " Always uses spaces instead of tab characters
\r
130 set tabstop=2 " Size of insterted spaces if tab is pressed
\r
131 set list " Highlight tab characters in files
\r
132 set listchars=tab:▸\ ,extends:#,nbsp:.,trail:⋅
\r
134 For the pre-commit hook one could `grep -P '\t' *`. Maybe even better would be
\r
135 the use of a linter but I am not sure what is most flexible for C code.
\r