1 Return-Path: <awg@xvx.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 39040431FAF
\r
6 for <notmuch@notmuchmail.org>; Fri, 3 Feb 2012 22:01:26 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id umdDb1bX5NVx for <notmuch@notmuchmail.org>;
\r
16 Fri, 3 Feb 2012 22:01:25 -0800 (PST)
\r
17 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
18 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 5AEA1431FAE
\r
21 for <notmuch@notmuchmail.org>; Fri, 3 Feb 2012 22:01:25 -0800 (PST)
\r
22 Received: by bke11 with SMTP id 11so4092952bke.26
\r
23 for <notmuch@notmuchmail.org>; Fri, 03 Feb 2012 22:01:24 -0800 (PST)
\r
25 Received: by 10.204.145.82 with SMTP id c18mr4612994bkv.121.1328335283831;
\r
26 Fri, 03 Feb 2012 22:01:23 -0800 (PST)
\r
28 Received: by 10.204.104.13 with HTTP; Fri, 3 Feb 2012 22:01:23 -0800 (PST)
\r
29 X-Originating-IP: [96.52.216.56]
\r
30 In-Reply-To: <1328315554-16085-1-git-send-email-awg+notmuch@xvx.ca>
\r
31 References: <1328315554-16085-1-git-send-email-awg+notmuch@xvx.ca>
\r
32 Date: Fri, 3 Feb 2012 23:01:23 -0700
\r
33 X-Google-Sender-Auth: -g25LXHdD1HAOOLNHurAMVf0BhM
\r
35 <CAMoJFUsfPwmLPxhK_mCbJ7N66u5+62QQne-oNJjVawSUzfFrjg@mail.gmail.com>
\r
36 Subject: Re: [PATCH 0/2] Bug and potential fix: forwarded messages
\r
37 From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
\r
38 To: notmuch@notmuchmail.org
\r
39 Content-Type: text/plain; charset=ISO-8859-1
\r
40 Content-Transfer-Encoding: quoted-printable
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Sat, 04 Feb 2012 06:01:26 -0000
\r
55 Oh, and I just noticed that Dmitry has already fixed this, probably in
\r
56 a better way [1] (though I maintain that there still may be a problem
\r
57 with the approach in general). I clearly haven't been following the
\r
58 list closely enough this week.
\r
60 [1] id:"1327926286-16680-1-git-send-email-dmitry.kurochkin@gmail.com"
\r
62 On Fri, Feb 3, 2012 at 17:32, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:
\r
65 > I encountered today a bug that I remember being mentioned on IRC where
\r
66 > some messages are shown in emacs as completely empty, even though their
\r
67 > content is present and simple. For me, the bug shows up with messages tha=
\r
69 > have been forwarded by an Outlook user who didn't add any content to the =
\r
71 > of the message. The first line of the message is "-----Original Message--=
\r
73 > and the rest is the forwarded text. Notmuch tries to collapse the forward=
\r
75 > content into a button, but fails mysteriously.
\r
77 > The first patch in this series adds a test (marked as broken) that demons=
\r
79 > the bug. I think this should be pushed regardless of whether my solution =
\r
81 > the right one. My solution is to check whether we're collapsing the entir=
\r
83 > message before doing so, and avoid turning it into a button if that's the=
\r
85 > I think this is a desirable behavior, since if someone has forwarded a me=
\r
87 > without adding anything the user probably wants to read that message. But=
\r
89 > I'll admit that I didn't figure out the real cause of the problem, and I
\r
90 > would be happy to hear other suggestions.
\r
92 > It also occurs to me that this might indicate a bigger problem with how
\r
93 > notmuch-wash.el handles messages starting with "-----Original Message----=
\r
95 > Notmuch seems to assume that this indicates the rest of the message is qu=
\r
97 > stuff that's been top-posted on. In my office this isn't necessarily the =
\r
99 > since Outlook produces that line at the top of every reply, and it's up t=
\r
101 > the user whether to top-post or not (and not everyone does).
\r
103 > I'll have to experiment a bit more to verify whether a problem (i.e. whet=
\r
105 > Notmuch hides inappropriate things when someone replies inline with Outlo=
\r
107 > Someone please correct me if I'm missing something in how the code operat=
\r
110 > Adam Wolfe Gordon (2):
\r
111 > =A0test: Add broken test for showing forwarded messages
\r
112 > =A0emacs: Fix broken showing of forwarded messages.
\r
114 > =A0emacs/notmuch-wash.el | =A0 =A05 +++--
\r
115 > =A0test/emacs =A0 =A0 =A0 =A0 =A0 =A0| =A0 32 +++++++++++++++++++++++++++=
\r
117 > =A02 files changed, 35 insertions(+), 2 deletions(-)
\r