1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1784B431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 14 Sep 2013 02:54:18 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 2WFVm4CDnL7O for <notmuch@notmuchmail.org>;
\r
16 Sat, 14 Sep 2013 02:54:10 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 71E80431FAE
\r
19 for <notmuch@notmuchmail.org>; Sat, 14 Sep 2013 02:54:10 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 2426510007D;
\r
22 Sat, 14 Sep 2013 12:54:01 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 0/4] contrib: pick: allow more general format lines
\r
26 In-Reply-To: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com>
\r
27 References: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com>
\r
28 User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Sat, 14 Sep 2013 12:54:00 +0300
\r
34 Message-ID: <m2ob7vg24n.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Sat, 14 Sep 2013 09:54:18 -0000
\r
51 On Mon, Sep 02 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
53 > Currently pick makes the tree box graphics part of the "subject". This
\r
54 > is rather unsatisfactory: the tree graphics should be a field in their
\r
57 > However, there is no mechanism in the current setup for allowing 2
\r
58 > fields to have fixed combined width but variable individual
\r
59 > width. Thus making the tree graphics a seperate field means that we
\r
60 > cannot keep the current display which is
\r
62 > date (12 characters) authors (20 characters) tree+subject (54 characters) tags
\r
64 > We solve this by extending the format specifier. Previously this was a
\r
65 > list of cons cells (field-name . format-string) We now allow the
\r
66 > left-side (the field-name) itself to be a list of cons cells in which case we
\r
67 > apply the formatting recursively.
\r
69 > This means we can separate the tree box graphics into their own field
\r
70 > while maintaining the current format.
\r
72 > Note that this will mean that people who have customised the
\r
73 > result-format will need to update their customisation.
\r
75 > The patch is larger but relatively simple.
\r
77 > Patch 1/4 is unrelated except I found it while doing this update: we
\r
78 > consistency we should print () for messages with no tags.
\r
80 > Patch 2/4 is large but trivial: it moves the insertion up a level in
\r
81 > preparation for the recursive formatting.
\r
83 > Patch 3/4 is also simple: it just allows the recursive formatting.
\r
85 > Patch 4/4 separates out the tree field. This patch is large as
\r
86 > it allows separate tree faces (matching and non-matching). The
\r
87 > "genuine code" part of the patch is relatively small.
\r
89 > Finally, this is the last series (apart from some extra tests and
\r
90 > keeping up with mainline progress) that I think pick needs before it's
\r
91 > ready for consideration in non-contrib mainline.
\r
93 This series LGTM. One thing that I saw could be "improved" a bit:
\r
94 in notmuch-pick-format-field drop the formatted-field parameter
\r
95 and setq's to it. Something that can be done in follow-up patch
\r
96 if there is nothing else to be changed. I don't want to have any
\r
97 more review effort on this patchset due to that change :D
\r
112 > Mark Walters (4):
\r
113 > contrib: pick: print () for a message with no tags
\r
114 > contrib: pick: move the insertion of fields up a level
\r
115 > contrib: pick: allow recursive message field formats
\r
116 > contrib: pick: make the tree graphics a proper part of the format
\r
118 > contrib/notmuch-pick/notmuch-pick.el | 93 ++++++++++++++++++++++++---------
\r
119 > 1 files changed, 67 insertions(+), 26 deletions(-)
\r
124 > _______________________________________________
\r
125 > notmuch mailing list
\r
126 > notmuch@notmuchmail.org
\r
127 > http://notmuchmail.org/mailman/listinfo/notmuch
\r