1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8DCAF431FC0
\r
6 for <notmuch@notmuchmail.org>; Wed, 23 Jan 2013 00:26:47 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 1WgUbHcXZRpP for <notmuch@notmuchmail.org>;
\r
16 Wed, 23 Jan 2013 00:26:43 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 5B163431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 23 Jan 2013 00:26:43 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 41C2E100086;
\r
22 Wed, 23 Jan 2013 10:26:31 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Peter Wang <novalazy@gmail.com>, Jani Nikula <jani@nikula.org>
\r
25 Subject: Re: [PATCH v3 01/20] cli: add stub for insert command
\r
26 In-Reply-To: <20130123190424.GA1980@hili.localdomain>
\r
27 References: <1358643004-14522-1-git-send-email-novalazy@gmail.com>
\r
28 <1358643004-14522-2-git-send-email-novalazy@gmail.com>
\r
29 <87vcaoj3i0.fsf@nikula.org>
\r
30 <20130123190424.GA1980@hili.localdomain>
\r
31 User-Agent: Notmuch/0.15+11~ge1e719d (http://notmuchmail.org) Emacs/24.2.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Wed, 23 Jan 2013 10:26:31 +0200
\r
37 Message-ID: <m2y5fkz4nc.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain
\r
40 Cc: notmuch@notmuchmail.org
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Wed, 23 Jan 2013 08:26:47 -0000
\r
55 On Wed, Jan 23 2013, Peter Wang <novalazy@gmail.com> wrote:
\r
57 > On Tue, 22 Jan 2013 23:45:43 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
59 >> > +/* Copy the contents of standard input (fdin) into fdout. */
\r
60 >> > +static notmuch_bool_t
\r
61 >> > +copy_stdin (int fdin, int fdout)
\r
63 >> The comment and the function name imply the function has something to do
\r
64 >> with stdin, while it only cares about file descriptors.
\r
66 > Tomi pointed out that the error message refers to standard input.
\r
68 Was that me or some other Tomi ;)... Nevertheless the function here called
\r
69 'copy_stdin' copies fdin to fdout, whatever the file descriptors are,
\r
70 it doesn't enforce fdin to be fd 0 (default stdin).
\r
71 I.e. the function name should be more generic (or then drop fdin argument --
\r
72 should better name then be 'copy_from_stdin' or copy_stdin_to.. or
\r
73 copy_[from_]stdin_to_some_magic_fd -- ok, no more bikeshedding now >;)).
\r