77/ec978de1e85e06018fb8accbf087bc1e64aa3b

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id B56FF431FBC\r
   6         for <notmuch@notmuchmail.org>; Fri, 25 May 2012 07:44:06 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id GJnmCLKTejrU for <notmuch@notmuchmail.org>;\r
  16         Fri, 25 May 2012 07:44:06 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
  18         [18.7.68.37])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 462B3431FB6\r
  20         for <notmuch@notmuchmail.org>; Fri, 25 May 2012 07:44:06 -0700 (PDT)\r
  21 X-AuditID: 12074425-b7f966d0000008b6-ff-4fbf9ab52f5f\r
  22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  23         by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 9D.D5.02230.5BA9FBF4; Fri, 25 May 2012 10:44:05 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q4PEi56u015057; \r
  27         Fri, 25 May 2012 10:44:05 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4PEi3ZS007933\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Fri, 25 May 2012 10:44:04 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SXvkJ-0000dw-Ol; Fri, 25 May 2012 10:44:03 -0400\r
  37 Date: Fri, 25 May 2012 10:44:03 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Jameson Graef Rollins <jrollins@finestructure.net>\r
  40 Subject: Re: [PATCH v4 0/7] cli: improved crypto internals\r
  41 Message-ID: <20120525144403.GD11804@mit.edu>\r
  42 References: <1337812843-14986-1-git-send-email-jrollins@finestructure.net>\r
  43 MIME-Version: 1.0\r
  44 Content-Type: text/plain; charset=us-ascii\r
  45 Content-Disposition: inline\r
  46 In-Reply-To: <1337812843-14986-1-git-send-email-jrollins@finestructure.net>\r
  47 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  48 X-Brightmail-Tracker:\r
  49  H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT1906a7+/Qd9uY4s9+7wsrt+cyezA\r
  50         5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgyfv5Zz1RwkKXiw8FvzA2MJ5i7GDk5JARMJPa/\r
  51         P8YOYYtJXLi3nq2LkYtDSGAfo8T0pzeZIJwNjBKz17awQzgnmSQ2H1rPCuEsYZQ419HMCNLP\r
  52         IqAq8enYQTCbTUBDYtv+5WC2iICZRM+XP2A2s4CWxNaNH8BsYQEricWrpjCB2LwCOhJ/j00E\r
  53         u0lIwEti2uEjbBBxQYmTM5+wwPTe+PcSqJ4DyJaWWP6PAyTMKeAt8e9LH9gYUQEViSknt7FN\r
  54         YBSahaR7FpLuWQjdCxiZVzHKpuRW6eYmZuYUpybrFicn5uWlFula6OVmluilppRuYgQHtYvq\r
  55         DsYJh5QOMQpwMCrx8DJF7/MXYk0sK67MPcQoycGkJMp7ZuZ+fyG+pPyUyozE4oz4otKc1OJD\r
  56         jBIczEoivCxpQDnelMTKqtSifJiUNAeLkjjvOs3d/kIC6YklqdmpqQWpRTBZGQ4OJQleHmD0\r
  57         CgkWpaanVqRl5pQgpJk4OEGG8wANvwiymLe4IDG3ODMdIn+KUVFKnPcySEIAJJFRmgfXC0s6\r
  58         rxjFgV4R5p0JUsUDTFhw3a+ABjMBDd7yeC/I4JJEhJRUA6OISNlzbXaLf4KsZ7RvaCbPP2/O\r
  59         7Lj9x9V7gbu8gkpCf82ZUN53RDrF+p9PlezelxGuORnZwhk+1y+87+veuvwV38eX9hNnfnZW\r
  60         zv7yY8Ify0v3QpKvRW3PzDpy0PeOnvYTo1ubdGsnet3pyOG2NCzWe9b582pmc2xz8LS+RXWO\r
  61         rT3tLiu2uyqxFGckGmoxFxUnAgA7Jc6vFQMAAA==\r
  62 Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
  63 X-BeenThere: notmuch@notmuchmail.org\r
  64 X-Mailman-Version: 2.1.13\r
  65 Precedence: list\r
  66 List-Id: "Use and development of the notmuch mail system."\r
  67         <notmuch.notmuchmail.org>\r
  68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  71 List-Post: <mailto:notmuch@notmuchmail.org>\r
  72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  74         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  75 X-List-Received-Date: Fri, 25 May 2012 14:44:06 -0000\r
  76 \r
  77 Quoth Jameson Graef Rollins on May 23 at  3:40 pm:\r
  78 > Ok, hopefully last version.  This addresses Jani's latest comments.\r
  79 > \r
  80 > The first patch uses a typedef to handle the incompatibility between\r
  81 > the crypto context between GMIME 2.4 and 2.6.  We probably should have\r
  82 > done this originally, as it gets rid of a bunch of #ifdefs, and should\r
  83 > help reduce confusion.\r
  84 > \r
  85 > I also move to use strcasecmp for the crypto protocol, with a comment\r
  86 > that points to the relevant RFCs for justification.\r
  87 \r
  88 This series LGTM other than the one and a half comments I just sent.\r