1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 43B9B40D141
\r
6 for <notmuch@notmuchmail.org>; Wed, 13 Oct 2010 02:09:18 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5
\r
12 tests=[BAYES_00=-1.9] autolearn=ham
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id s1d4--HCKyYT for <notmuch@notmuchmail.org>;
\r
16 Wed, 13 Oct 2010 02:09:07 -0700 (PDT)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 603D240D143
\r
19 for <notmuch@notmuchmail.org>; Wed, 13 Oct 2010 02:09:07 -0700 (PDT)
\r
20 Received: from localhost (unknown [192.168.200.4])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id F01E419F33E2;
\r
22 Wed, 13 Oct 2010 11:09:05 +0200 (CEST)
\r
23 X-Virus-Scanned: IMAP AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,
\r
27 with ESMTP id 19dnV545cGsO; Wed, 13 Oct 2010 11:09:03 +0200 (CEST)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id 0E47919F33D9;
\r
30 Wed, 13 Oct 2010 11:09:02 +0200 (CEST)
\r
31 Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30])
\r
32 (Authenticated sender: sojkam1)
\r
33 by imap.feld.cvut.cz (Postfix) with ESMTPSA id 195D115C082;
\r
34 Wed, 13 Oct 2010 11:09:02 +0200 (CEST)
\r
35 Received: from wsh by steelpick.2x.cz with local (Exim 4.72)
\r
36 (envelope-from <sojkam1@fel.cvut.cz>)
\r
37 id 1P5xKX-0003uj-Fa; Wed, 13 Oct 2010 11:09:01 +0200
\r
38 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
39 To: Andreas Amann <andreas.amann@tyndall.ie>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH] Allow user to specify ignored directories
\r
41 In-Reply-To: <ylp7hi23mw8.fsf@tyndall.ie>
\r
42 References: <ylp7hi23mw8.fsf@tyndall.ie>
\r
43 User-Agent: Notmuch/0.3.1-83-g6fec75f (http://notmuchmail.org) Emacs/23.2.1
\r
44 (x86_64-pc-linux-gnu)
\r
45 Date: Wed, 13 Oct 2010 11:09:01 +0200
\r
46 Message-ID: <87zkui1mtu.fsf@steelpick.2x.cz>
\r
48 Content-Type: text/plain; charset=us-ascii
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Wed, 13 Oct 2010 09:09:18 -0000
\r
63 On Thu, 30 Sep 2010, Andreas Amann wrote:
\r
66 > this is my first post. I found notmuch a couple of days ago and it works
\r
67 > great. However I wanted to be able to ignore certain directories (mostly
\r
68 > .git in my case) when "notmuch new" is running.
\r
70 > With this patch the user can provide a list of directories which are
\r
71 > ignored during the recursive search for new messages. An "ignore"
\r
72 > label in the "new" section of the configuration file is added for this
\r
73 > purpose to enable for example something like
\r
77 thanks, the patch seems good to me. See the comment bellow.
\r
80 > @@ -202,7 +219,8 @@ _entries_resemble_maildir (struct dirent **entries, int count)
\r
81 > static notmuch_status_t
\r
82 > add_files_recursive (notmuch_database_t *notmuch,
\r
84 > - add_files_state_t *state)
\r
85 > + add_files_state_t *state,
\r
86 > + notmuch_config_t *config)
\r
88 I would not add additional parameter here. It's IMHO better to add field
\r
89 "ignored_files" to add_files_state_t similarly as it is done for
\r