76/801b6cab930bd42785e131beac810f6f416045

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 1460A429E34\r
   6         for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 21:08:43 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id VFuo5G9fBLu2 for <notmuch@notmuchmail.org>;\r
  16         Mon, 30 Jan 2012 21:08:42 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU\r
  18         [18.7.68.34])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 7A2A1431E64\r
  20         for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 21:08:42 -0800 (PST)\r
  21 X-AuditID: 12074422-b7fd66d0000008f9-78-4f27775a6f88\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 12.26.02297.A57772F4; Tue, 31 Jan 2012 00:08:42 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0V58fHc030126; \r
  27         Tue, 31 Jan 2012 00:08:42 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0V58ecs004095\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Tue, 31 Jan 2012 00:08:41 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1Rs5wa-0002pP-NX; Tue, 31 Jan 2012 00:07:48 -0500\r
  37 Date: Tue, 31 Jan 2012 00:07:48 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Mark Walters <markwalters1009@gmail.com>\r
  40 Subject: Re: [PATCH 4/7] lib: Add the exclude flag to\r
  41         notmuch_query_search_threads\r
  42 Message-ID: <20120131050748.GA10844@mit.edu>\r
  43 References: <8762fu4aqt.fsf@qmul.ac.uk>\r
  44         <1327862394-14334-4-git-send-email-markwalters1009@gmail.com>\r
  45 MIME-Version: 1.0\r
  46 Content-Type: text/plain; charset=us-ascii\r
  47 Content-Disposition: inline\r
  48 In-Reply-To: <1327862394-14334-4-git-send-email-markwalters1009@gmail.com>\r
  49 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hRV1o0qV/c36LrBarF6Lo/F9ZszmR2Y\r
  52         PHbOusvu8WzVLeYApigum5TUnMyy1CJ9uwSujJ2rz7AXHGWrmNM5ibWBcQNrFyMnh4SAicTz\r
  53         ExPYIWwxiQv31rN1MXJxCAnsY5TYdPIvE4SzgVHi0sbZzBDOSSaJWWcWsEA4Sxgl1vdtAetn\r
  54         EVCV+PntMhOIzSagIbFt/3JGEFtEQEfi9qEFYDXMAtIS3343g9UIC4RIPP64D+gODg5eoJrN\r
  55         q4tAwkIC6RKbn79lAbF5BQQlTs58wgLRqiVx499LJpBykDHL/3GAhDkFvCQ2XO8Fmy4qoCIx\r
  56         5eQ2tgmMQrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXVO93MwSvdSU0k2M\r
  57         oKBmd1HawfjzoNIhRgEORiUe3j3v1fyFWBPLiitzDzFKcjApifLOKVD3F+JLyk+pzEgszogv\r
  58         Ks1JLT7EKMHBrCTC+2Y1UDlvSmJlVWpRPkxKmoNFSZxXXeudH9C/iSWp2ampBalFMFkZDg4l\r
  59         Cd4jZUBDBYtS01Mr0jJzShDSTBycIMN5gIZvA6nhLS5IzC3OTIfIn2LU5Wh/u/s8oxBLXn5e\r
  60         qpQ4bzxIkQBIUUZpHtwcWDJ6xSgO9JYw7wWQKh5gIoOb9ApoCRPQkucMqiBLShIRUlINjCaC\r
  61         W/PL/Xb+Z8lzUv/memLa6T33Pq1yeLDPK0ti5THHXbKKE3cfvjDD8+n2E197typM9d36KuuW\r
  62         WOibGRuNF02VKZibnhS77nH3s5h38WoaXieTFeVYptv8M/6Rll52oko5W+nd7Z3J/LuaLtse\r
  63         cpX4nnLOwfpiZ5mr1OK0+DCrIrW5b+qKC5RYijMSDbWYi4oTAaXO9RkhAwAA\r
  64 Cc: notmuch@notmuchmail.org\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69         <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Tue, 31 Jan 2012 05:08:43 -0000\r
  78 \r
  79 Quoth Mark Walters on Jan 29 at  6:39 pm:\r
  80 > Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to\r
  81 > notmuch_query_search_threads. Implemented by inspecting the tags\r
  82 > directly in _notmuch_thread_create/_thread_add_message rather than as\r
  83 > a Xapian query for speed reasons.\r
  84 \r
  85 Hmm.  Won't the thread sort be influenced by excluded messages?\r
  86 \r
  87 It's not completely obvious to me if it should or shouldn't be.  If\r
  88 excluded messages are counted for thread sorting, it would be very\r
  89 natural to toggle their visibility in the search view; otherwise we\r
  90 probably need to perform the entire query again with exclusions\r
  91 disabled.\r
  92 \r
  93 If we do want to ignore excluded messages for sorting, I think\r
  94 notmuch_query_search_threads can simply shuffle excluded messages to\r
  95 the end of doc_ids (which is slightly awkward to implement, but not\r
  96 too bad).\r