1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C51B2431FBC
\r
6 for <notmuch@notmuchmail.org>; Sat, 26 May 2012 02:52:04 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id lVC-y45bKfYL for <notmuch@notmuchmail.org>;
\r
16 Sat, 26 May 2012 02:52:04 -0700 (PDT)
\r
17 Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com
\r
18 [209.85.214.181]) (using TLSv1 with cipher RC4-MD5 (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 0B96A431FB6
\r
21 for <notmuch@notmuchmail.org>; Sat, 26 May 2012 02:52:04 -0700 (PDT)
\r
22 Received: by obbuo19 with SMTP id uo19so2852496obb.26
\r
23 for <notmuch@notmuchmail.org>; Sat, 26 May 2012 02:52:02 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
\r
27 :cc:content-type:x-gm-message-state;
\r
28 bh=f9LmIhh23ZScy+KQx3j3k1A86dvLQoYkyOxSsXM0eMI=;
\r
29 b=N2THzcMsZ3V0MHVFGJ9/5aKdQ4712mVjqbuyBRBx2oc0Uk39NwPWiQEfoE7KZAdXsg
\r
30 r9VTqqfrWG17YgkSn+luazUyG8KNrL4RJdzDpAhNhkCo1avShh4cQMwwv540IZdnQn/d
\r
31 qFVKpfJ4NRQ0F2iA9Hh+qSxjsfUMX2Un4OAEcxeJJSmz5asG6iniTUhj+XUfLNzy4FCO
\r
32 QNZOWzeFvFhII1eX8ThMx2/AXXhqhY3OOuTR2EqBKfcPU1OWJ8a60TssEZeXpLL0OZka
\r
33 9OYwMJb2oUle/lg8W5XNo1Lxg1wjxO/+7KjO0dz8/Z8kaBVARROnv9CB6WPhsTXUeZVe
\r
36 Received: by 10.182.154.67 with SMTP id vm3mr1788127obb.57.1338025922379; Sat,
\r
37 26 May 2012 02:52:02 -0700 (PDT)
\r
38 Received: by 10.76.173.136 with HTTP; Sat, 26 May 2012 02:52:02 -0700 (PDT)
\r
39 Received: by 10.76.173.136 with HTTP; Sat, 26 May 2012 02:52:02 -0700 (PDT)
\r
40 In-Reply-To: <1337953411-21000-4-git-send-email-pioto@pioto.org>
\r
41 References: <1337953411-21000-1-git-send-email-pioto@pioto.org>
\r
42 <1337953411-21000-4-git-send-email-pioto@pioto.org>
\r
43 Date: Sat, 26 May 2012 12:52:02 +0300
\r
45 <CAB+hUn_M7m0KPnmGwSFao9wxnzmrct+U0ZO6tGy4nRoA8eht_Q@mail.gmail.com>
\r
46 Subject: Re: [PATCH 03/10] Fix compilation of smtp-dummy on FreeBSD
\r
47 From: Jani Nikula <jani@nikula.org>
\r
48 To: Mike Kelly <pioto@pioto.org>
\r
49 Content-Type: multipart/alternative; boundary=f46d0447a06bcdc00304c0ed6f6c
\r
51 ALoCoQkVsVTqpZ/IK4EWhLe3ojFuxEGEQwJssNrGYAuSN2u2eLQ5lDG2k2aUkK13lkElDgxoTCnP
\r
52 Cc: notmuch@notmuchmail.org
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Sat, 26 May 2012 09:52:05 -0000
\r
67 --f46d0447a06bcdc00304c0ed6f6c
\r
68 Content-Type: text/plain; charset=UTF-8
\r
70 On May 25, 2012 4:44 PM, "Mike Kelly" <pioto@pioto.org> wrote:
\r
73 > test/smtp-dummy.c | 5 ++++-
\r
74 > 1 file changed, 4 insertions(+), 1 deletion(-)
\r
76 > diff --git a/test/smtp-dummy.c b/test/smtp-dummy.c
\r
77 > index 3801a5e..aa82fa1 100644
\r
78 > --- a/test/smtp-dummy.c
\r
79 > +++ b/test/smtp-dummy.c
\r
80 > @@ -33,11 +33,14 @@
\r
81 > * have been warned.
\r
84 > +#define _GNU_SOURCE /* for getline */
\r
86 First of all, thanks for sharing your work.
\r
88 Independent of this patch, I've been thinking about defining _GNU_SOURCE in
\r
89 the makefile. I don't think it's very elegant to #define it everywhere. It
\r
90 would also pave the way towards building with -pedantic (and possibly
\r
91 -std=c99) in a portable way. For example, the compat test code #defines
\r
92 _GNU_SOURCE while the actual code does not, which I think is an error.
\r
94 I'll look into this after the weekend (unless you beat me to it).
\r
99 > #include <stdio.h>
\r
100 > #include <stdlib.h>
\r
101 > #include <string.h>
\r
102 > #include <errno.h>
\r
103 > -#include <netinet/ip.h>
\r
104 > +#include <sys/types.h>
\r
105 > +#include <sys/socket.h>
\r
106 > +#include <netinet/in.h>
\r
107 > #include <netdb.h>
\r
108 > #include <unistd.h>
\r
113 > _______________________________________________
\r
114 > notmuch mailing list
\r
115 > notmuch@notmuchmail.org
\r
116 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
118 --f46d0447a06bcdc00304c0ed6f6c
\r
119 Content-Type: text/html; charset=UTF-8
\r
120 Content-Transfer-Encoding: quoted-printable
\r
123 On May 25, 2012 4:44 PM, "Mike Kelly" <<a href=3D"mailto:pioto=
\r
124 @pioto.org">pioto@pioto.org</a>> wrote:<br>
\r
127 > =C2=A0test/smtp-dummy.c | =C2=A0 =C2=A05 ++++-<br>
\r
128 > =C2=A01 file changed, 4 insertions(+), 1 deletion(-)<br>
\r
130 > diff --git a/test/smtp-dummy.c b/test/smtp-dummy.c<br>
\r
131 > index 3801a5e..aa82fa1 100644<br>
\r
132 > --- a/test/smtp-dummy.c<br>
\r
133 > +++ b/test/smtp-dummy.c<br>
\r
134 > @@ -33,11 +33,14 @@<br>
\r
135 > =C2=A0* have been warned.<br>
\r
138 > +#define _GNU_SOURCE /* for getline */</p>
\r
139 <p>First of all, thanks for sharing your work.</p>
\r
140 <p>Independent of this patch, I've been thinking about defining _GNU_SO=
\r
141 URCE in the makefile. I don't think it's very elegant to #define it=
\r
142 everywhere. It would also pave the way towards building with -pedantic (an=
\r
143 d possibly -std=3Dc99) in a portable way. For example, the compat test code=
\r
144 #defines _GNU_SOURCE while the actual code does not, which I think is an e=
\r
147 <p>I'll look into this after the weekend (unless you beat me to it).</p=
\r
151 <p>> =C2=A0#include <stdio.h><br>
\r
152 > =C2=A0#include <stdlib.h><br>
\r
153 > =C2=A0#include <string.h><br>
\r
154 > =C2=A0#include <errno.h><br>
\r
155 > -#include <netinet/ip.h><br>
\r
156 > +#include <sys/types.h><br>
\r
157 > +#include <sys/socket.h><br>
\r
158 > +#include <netinet/in.h><br>
\r
159 > =C2=A0#include <netdb.h><br>
\r
160 > =C2=A0#include <unistd.h><br>
\r
165 > _______________________________________________<br>
\r
166 > notmuch mailing list<br>
\r
167 > <a href=3D"mailto:notmuch@notmuchmail.org">notmuch@notmuchmail.org</a>=
\r
169 > <a href=3D"http://notmuchmail.org/mailman/listinfo/notmuch">http://not=
\r
170 muchmail.org/mailman/listinfo/notmuch</a></p>
\r
172 --f46d0447a06bcdc00304c0ed6f6c--
\r