74/ec96ce8378695c6ed20114eb75b47d9b8a377b

   1 Return-Path: <markwalters1009@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 2EC02429E2F\r
   6         for <notmuch@notmuchmail.org>; Mon,  1 Jul 2013 14:07:56 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 0.201\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
  14         RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  15 Received: from olra.theworths.org ([127.0.0.1])\r
  16         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  17         with ESMTP id pJIBZ5PIMY2M for <notmuch@notmuchmail.org>;\r
  18         Mon,  1 Jul 2013 14:07:48 -0700 (PDT)\r
  19 Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com\r
  20  [74.125.82.46])        (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
  21  certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
  22  5BB33431FCF    for <notmuch@notmuchmail.org>; Mon,  1 Jul 2013 14:07:48 -0700\r
  23  (PDT)\r
  24 Received: by mail-wg0-f46.google.com with SMTP id c11so4078028wgh.1\r
  25         for <notmuch@notmuchmail.org>; Mon, 01 Jul 2013 14:07:47 -0700 (PDT)\r
  26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
  27         h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references;\r
  28         bh=uxMHSMeBZOVR5cdFB77ntLQJ0xh77XxD9LtHj0stMcM=;\r
  29         b=QHSwW4tUsMVjfokM04u/Sg7vUMv4XWhbPDugRgub27yYTV6pIuEZw1bTKo8XXGgprJ\r
  30         DzKuVh4F4QuDyIe1aLAi5MYp/z9qGbK8KfQPhAw5OQppMr59c99V9XWS4pasVmkql1O3\r
  31         QZ7pHlX9HcxuJe9QiwkA8j2O8yk52+7R59q4j3ZMSNzEjePZDTNIe2m40mmnYf9TI3JQ\r
  32         r2W5WnWU2seZ1X8QwEXwwOeIIdl2+hDfUvpx3V5YwQi7ExcVtjf1z+/0wqwIgGR3cMal\r
  33         Roo05NwRw0H2tXn74OcfZmTt+NifLFwUkcd4subQ65N0gwFbimYhAiDuzryB77AbmJ7I\r
  34         WTcw==\r
  35 X-Received: by 10.194.249.69 with SMTP id ys5mr22272912wjc.39.1372712867286;\r
  36         Mon, 01 Jul 2013 14:07:47 -0700 (PDT)\r
  37 Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
  38         by mx.google.com with ESMTPSA id\r
  39         fd3sm18842913wic.10.2013.07.01.14.07.46 for <multiple recipients>\r
  40         (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
  41         Mon, 01 Jul 2013 14:07:46 -0700 (PDT)\r
  42 From: Mark Walters <markwalters1009@gmail.com>\r
  43 To: notmuch@notmuchmail.org\r
  44 Subject: [PATCH 1/2] contrib: pick: remove unneeded variable\r
  45         notmuch-pick-buffer-name\r
  46 Date: Mon,  1 Jul 2013 22:07:40 +0100\r
  47 Message-Id: <1372712861-13515-2-git-send-email-markwalters1009@gmail.com>\r
  48 X-Mailer: git-send-email 1.7.9.1\r
  49 In-Reply-To: <1372712861-13515-1-git-send-email-markwalters1009@gmail.com>\r
  50 References: <1372712861-13515-1-git-send-email-markwalters1009@gmail.com>\r
  51 X-BeenThere: notmuch@notmuchmail.org\r
  52 X-Mailman-Version: 2.1.13\r
  53 Precedence: list\r
  54 List-Id: "Use and development of the notmuch mail system."\r
  55         <notmuch.notmuchmail.org>\r
  56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  57         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  59 List-Post: <mailto:notmuch@notmuchmail.org>\r
  60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  62         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  63 X-List-Received-Date: Mon, 01 Jul 2013 21:07:56 -0000\r
  64 \r
  65 This variable is essentially unused: it was only used for making sure\r
  66 it itself got reset after a refresh of the buffer.\r
  67 \r
  68 It did this by passing an unnecessary argument to notmuch-pick-worker\r
  69 so remove that too.\r
  70 ---\r
  71  contrib/notmuch-pick/notmuch-pick.el |   15 ++++-----------\r
  72  1 files changed, 4 insertions(+), 11 deletions(-)\r
  73 \r
  74 diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
  75 index fbd7c0b..ce627db 100644\r
  76 --- a/contrib/notmuch-pick/notmuch-pick.el\r
  77 +++ b/contrib/notmuch-pick/notmuch-pick.el\r
  78 @@ -166,10 +166,6 @@\r
  79    "A buffer local copy of argument open-target to the function notmuch-pick")\r
  80  (make-variable-buffer-local 'notmuch-pick-open-target)\r
  81  \r
  82 -(defvar notmuch-pick-buffer-name nil\r
  83 -  "A buffer local copy of argument buffer-name to the function notmuch-pick")\r
  84 -(make-variable-buffer-local 'notmuch-pick-buffer-name)\r
  85 -\r
  86  (defvar notmuch-pick-message-window nil\r
  87    "The window of the message pane.\r
  88  \r
  89 @@ -527,13 +523,11 @@ message will be \"unarchived\", i.e. the tag changes in\r
  90    (let ((inhibit-read-only t)\r
  91         (basic-query notmuch-pick-basic-query)\r
  92         (query-context notmuch-pick-query-context)\r
  93 -       (target (notmuch-pick-get-message-id))\r
  94 -       (buffer-name notmuch-pick-buffer-name))\r
  95 +       (target (notmuch-pick-get-message-id)))\r
  96      (erase-buffer)\r
  97      (notmuch-pick-worker basic-query\r
  98                          query-context\r
  99 -                        target\r
 100 -                        (get-buffer buffer-name))))\r
 101 +                        target)))\r
 102  \r
 103  (defmacro with-current-notmuch-pick-message (&rest body)\r
 104    "Evaluate body with current buffer set to the text of current message"\r
 105 @@ -799,12 +793,11 @@ Complete list of currently available key bindings:\r
 106         (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread\r
 107                                          results-buf)))))\r
 108  \r
 109 -(defun notmuch-pick-worker (basic-query &optional query-context target buffer open-target)\r
 110 +(defun notmuch-pick-worker (basic-query &optional query-context target open-target)\r
 111    (interactive)\r
 112    (notmuch-pick-mode)\r
 113    (setq notmuch-pick-basic-query basic-query)\r
 114    (setq notmuch-pick-query-context query-context)\r
 115 -  (setq notmuch-pick-buffer-name (buffer-name buffer))\r
 116    (setq notmuch-pick-target-msg target)\r
 117    (setq notmuch-pick-open-target open-target)\r
 118  \r
 119 @@ -864,7 +857,7 @@ The arguments are:\r
 120      ;; Don't track undo information for this buffer\r
 121      (set 'buffer-undo-list t)\r
 122  \r
 123 -    (notmuch-pick-worker query query-context target buffer open-target)\r
 124 +    (notmuch-pick-worker query query-context target open-target)\r
 125  \r
 126      (setq truncate-lines t)))\r
 127  \r
 128 -- \r
 129 1.7.9.1\r
 130 \r